Attachment 228815 Details for Bug 81627 – proposed fix

[patch] proposed fix

WKTR-auth.txt (text/plain), 40.46 KB, created by Alexey Proskuryakov on 2014-04-08 00:22:12 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Proskuryakov

Created: 2014-04-08 00:22:12 PDT

Size: 40.46 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 166914)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,27 @@
>+2014-04-07  Alexey Proskuryakov  <ap@apple.com>
>+
>+        [WK2] HTTP authentication regression tests fail
>+        https://bugs.webkit.org/show_bug.cgi?id=81627
>+        <rdar://problem/11079296>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitTestRunner/TestController.h:
>+        * WebKitTestRunner/TestController.cpp:
>+        (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
>+        to pageLoaderClient structure.
>+        (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Always return
>+        true. WebKitTestRunner only supports password based auth, but we know that tests
>+        don't sue anything else, and even if they will start to, we'll need to add support
>+        for that.
>+        When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
>+        calls won't be made (at least on CFNetwork based platforms). 
>+        (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
>+        to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
>+        make sense to associate auth requests with individual resources - there can be
>+        multiple resources loading at once from the same protection space, so WebKit1 API
>+        that had a resource identifier was inherently racy.
>+
> 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
> 
>         Build bmalloc on Mac
>Index: Tools/WebKitTestRunner/TestController.cpp
>===================================================================
>--- Tools/WebKitTestRunner/TestController.cpp	(revision 166854)
>+++ Tools/WebKitTestRunner/TestController.cpp	(working copy)
>@@ -474,8 +474,8 @@ void TestController::createWebViewWithOp
>         0, // didRemoveFrameFromHierarchy
>         0, // didFailToInitializePlugin
>         0, // didDisplayInsecureContentForFrame
>-        0, // canAuthenticateAgainstProtectionSpaceInFrame
>-        didReceiveAuthenticationChallengeInFrame, // didReceiveAuthenticationChallengeInFrame
>+        canAuthenticateAgainstProtectionSpaceInFrame,
>+        didReceiveAuthenticationChallengeInFrame,
>         0, // didStartProgress
>         0, // didChangeProgress
>         0, // didFinishProgress
>@@ -1124,6 +1124,11 @@ void TestController::didFinishLoadForFra
>     static_cast<TestController*>(const_cast<void*>(clientInfo))->didFinishLoadForFrame(page, frame);
> }
> 
>+bool TestController::canAuthenticateAgainstProtectionSpaceInFrame(WKPageRef, WKFrameRef, WKProtectionSpaceRef, const void*)
>+{
>+    return true;
>+}
>+
> void TestController::didReceiveAuthenticationChallengeInFrame(WKPageRef page, WKFrameRef frame, WKAuthenticationChallengeRef authenticationChallenge, const void *clientInfo)
> {
>     static_cast<TestController*>(const_cast<void*>(clientInfo))->didReceiveAuthenticationChallengeInFrame(page, frame, authenticationChallenge);
>@@ -1174,9 +1179,9 @@ void TestController::didReceiveAuthentic
> {
>     String message;
>     if (!m_handlesAuthenticationChallenges)
>-        message = "<unknown> - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet\n";
>+        message = "didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet\n";
>     else
>-        message = String::format("<unknown> - didReceiveAuthenticationChallenge - Responding with %s:%s\n", m_authenticationUsername.utf8().data(), m_authenticationPassword.utf8().data());
>+        message = String::format("didReceiveAuthenticationChallenge - Responding with %s:%s\n", m_authenticationUsername.utf8().data(), m_authenticationPassword.utf8().data());
>     m_currentInvocation->outputText(message);
> 
>     WKAuthenticationDecisionListenerRef decisionListener = WKAuthenticationChallengeGetDecisionListener(authenticationChallenge);
>Index: Tools/WebKitTestRunner/TestController.h
>===================================================================
>--- Tools/WebKitTestRunner/TestController.h	(revision 166854)
>+++ Tools/WebKitTestRunner/TestController.h	(working copy)
>@@ -151,6 +151,8 @@ private:
> 
>     static void unavailablePluginButtonClicked(WKPageRef, WKPluginUnavailabilityReason, WKDictionaryRef, const void*);
> 
>+    static bool canAuthenticateAgainstProtectionSpaceInFrame(WKPageRef, WKFrameRef, WKProtectionSpaceRef, const void *clientInfo);
>+
>     static void didReceiveAuthenticationChallengeInFrame(WKPageRef, WKFrameRef, WKAuthenticationChallengeRef, const void *clientInfo);
>     void didReceiveAuthenticationChallengeInFrame(WKPageRef, WKFrameRef, WKAuthenticationChallengeRef);
> 
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 166914)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,39 @@
>+2014-04-07  Alexey Proskuryakov  <ap@apple.com>
>+
>+        [WK2] HTTP authentication regression tests fail
>+        https://bugs.webkit.org/show_bug.cgi?id=81627
>+        <rdar://problem/11079296>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac-wk2/TestExpectations: Unskipped tests that now pass. Marked three
>+        tests as failing, because enabling auth uncovered that they are failing
>+        (in browser as well).
>+
>+        * platform/wk2/http: Added.
>+        * platform/wk2/http/tests: Added.
>+        * platform/wk2/http/tests/loading: Added.
>+        * platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials: Added.
>+        * platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Copied from LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt.
>+        * platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Copied from LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt.
>+        * platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Copied from LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt.
>+        * platform/wk2/http/tests/misc: Added.
>+        * platform/wk2/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt.
>+        * platform/wk2/http/tests/misc/authentication-redirect-1: Added.
>+        * platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt.
>+        * platform/wk2/http/tests/misc/authentication-redirect-2: Added.
>+        * platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt.
>+        * platform/wk2/http/tests/misc/authentication-redirect-4: Added.
>+        * platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt.
>+        * platform/wk2/http/tests/security: Added.
>+        * platform/wk2/http/tests/security/401-logout: Added.
>+        * platform/wk2/http/tests/security/401-logout/401-logout-expected.txt: Copied from LayoutTests/http/tests/security/401-logout/401-logout-expected.txt.
>+        * platform/wk2/http/tests/xmlhttprequest: Added.
>+        * platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt.
>+        * platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/remember-bad-password-expected.txt.
>+        WebKit2 results are the same as WebKit1, except that they lack resource URL. That
>+        is expected with WebKit2 API.
>+
> 2014-04-07  Martin Robinson  <mrobinson@igalia.com>
> 
>         Skipped some HighDPI tests for GTK+
>Index: LayoutTests/platform/mac-wk2/TestExpectations
>===================================================================
>--- LayoutTests/platform/mac-wk2/TestExpectations	(revision 166854)
>+++ LayoutTests/platform/mac-wk2/TestExpectations	(working copy)
>@@ -169,13 +169,6 @@ fast/events/pageshow-pagehide-on-back-ca
> fast/events/pageshow-pagehide-on-back-cached.html
> fast/events/pageshow-pagehide.html
> 
>-# [WK2] Four http/tests/xmlhttprequest tests fail on mac-wk2
>-# https://bugs.webkit.org/show_bug.cgi?id=81627
>-http/tests/xmlhttprequest/basic-auth-default.html
>-http/tests/xmlhttprequest/basic-auth.html
>-http/tests/xmlhttprequest/re-login-async.html
>-http/tests/xmlhttprequest/workers/abort-exception-assert.html
>-
> # fast/events/drag-link.html is failing in Mac WebKit2
> # https://bugs.webkit.org/show_bug.cgi?id=81833
> fast/events/drag-link.html
>@@ -234,19 +227,6 @@ webkit.org/b/105998 [ Lion Release ] fas
> webkit.org/b/105998 [ MountainLion Debug ] fast/css/sticky/inline-sticky.html [ ImageOnlyFailure Pass ]
> webkit.org/b/105998 [ MountainLion Debug ] fast/css/sticky/sticky-both-sides.html [ ImageOnlyFailure Pass ]
> 
>-webkit.org/b/106405 http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html [ Failure ]
>-webkit.org/b/106405 http/tests/loading/basic-auth-resend-wrong-credentials.html [ Failure ]
>-webkit.org/b/106405 http/tests/loading/basic-credentials-sent-automatically.html [ Failure ]
>-webkit.org/b/106405 http/tests/misc/401-alternative-content.php [ Failure ]
>-webkit.org/b/106405 http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html [ Failure ]
>-webkit.org/b/106405 http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html [ Failure ]
>-webkit.org/b/106405 http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html [ Failure ]
>-webkit.org/b/106405 http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url.html [ Failure ]
>-webkit.org/b/106405 http/tests/security/401-logout/401-logout.php [ Failure ]
>-webkit.org/b/106405 http/tests/xmlhttprequest/basic-auth-nouser.html [ Failure ]
>-webkit.org/b/106405 http/tests/xmlhttprequest/failed-auth.html [ Failure ]
>-webkit.org/b/106405 http/tests/xmlhttprequest/remember-bad-password.html [ Failure ]
>-
> webkit.org/b/108507 printing/quirks-percentage-height-body.html [ Skip ]
> webkit.org/b/108507 printing/quirks-percentage-height.html [ Skip ]
> webkit.org/b/108507 printing/standards-percentage-heights.html [ Skip ]
>@@ -363,6 +343,10 @@ webkit.org/b/125996 platform/mac/accessi
> 
> webkit.org/b/127960 [ MountainLion ] http/tests/security/cross-origin-plugin-private-browsing-toggled.html [ Pass Failure ]
> 
>+webkit.org/b/131349 http/tests/xmlhttprequest/access-control-preflight-credential-async.html [ Failure ]
>+webkit.org/b/131349 http/tests/xmlhttprequest/cross-origin-no-authorization.html [ Failure ]
>+webkit.org/b/131349 http/tests/xmlhttprequest/cross-origin-no-credential-prompt.html [ Failure ]
>+
> ### END OF (1) Classified failures with bug reports
> ########################################
> 
>@@ -393,7 +377,6 @@ editing/spelling/spelling-marker-descrip
> 
> # All tests that failed on the Lion WebKit2 Release bot in r111739
> fast/forms/range/slider-delete-while-dragging-thumb.html
>-http/tests/security/credentials-in-referer.html
> svg/W3C-SVG-1.1/fonts-elem-04-b.svg
> 
> # A test that failed more than once on the Lion WebKit2 Debug bot between r111808 and r111849
>Index: LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt	(revision 166854)	(from LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:166854)
>+++ LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt	(working copy)
>@@ -0,0 +1,29 @@
>+main frame - didStartProvisionalLoadForFrame
>+main frame - didCommitLoadForFrame
>+frame "-->" - didStartProvisionalLoadForFrame
>+main frame - didFinishDocumentLoadForFrame
>+http://127.0.0.1:8000/loading/resources/test2/protected-resource.php - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
>+frame "-->" - didCommitLoadForFrame
>+frame "-->" - didFinishDocumentLoadForFrame
>+main frame - didHandleOnloadEventsForFrame
>+frame "-->" - didStartProvisionalLoadForFrame
>+frame "-->" - didHandleOnloadEventsForFrame
>+frame "-->" - didFinishLoadForFrame
>+http://127.0.0.1:8000/loading/resources/test2/basic-auth-testing.php?username=correctusername&password=correctpassword - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
>+frame "-->" - didCommitLoadForFrame
>+frame "-->" - didFinishDocumentLoadForFrame
>+frame "-->" - didHandleOnloadEventsForFrame
>+frame "-->" - didFinishLoadForFrame
>+main frame - didFinishLoadForFrame
>+This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
>+  
>+
>+--------
>+Frame: '-->'
>+--------
>+Authenticated as user: wrongusername password: wrongpassword
>+
>+--------
>+Frame: '-->'
>+--------
>+Authenticated as user: correctusername password: correctpassword
>Index: LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt	(working copy)
>+++ LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt	(working copy)
>@@ -2,14 +2,14 @@ main frame - didStartProvisionalLoadForF
> main frame - didCommitLoadForFrame
> frame "-->" - didStartProvisionalLoadForFrame
> main frame - didFinishDocumentLoadForFrame
>-http://127.0.0.1:8000/loading/resources/test2/protected-resource.php - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
>+didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
> frame "-->" - didCommitLoadForFrame
> frame "-->" - didFinishDocumentLoadForFrame
> main frame - didHandleOnloadEventsForFrame
> frame "-->" - didStartProvisionalLoadForFrame
> frame "-->" - didHandleOnloadEventsForFrame
> frame "-->" - didFinishLoadForFrame
>-http://127.0.0.1:8000/loading/resources/test2/basic-auth-testing.php?username=correctusername&password=correctpassword - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
>+didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
> frame "-->" - didCommitLoadForFrame
> frame "-->" - didFinishDocumentLoadForFrame
> frame "-->" - didHandleOnloadEventsForFrame
>Index: LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt	(revision 166854)	(from LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt:166854)
>+++ LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt	(working copy)
>@@ -0,0 +1,57 @@
>+main frame - didStartProvisionalLoadForFrame
>+main frame - didCommitLoadForFrame
>+frame "-->" - didStartProvisionalLoadForFrame
>+main frame - didFinishDocumentLoadForFrame
>+http://127.0.0.1:8000/loading/resources/subresources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with first:first-pw
>+frame "-->" - didCommitLoadForFrame
>+frame "-->" - didFinishDocumentLoadForFrame
>+main frame - didHandleOnloadEventsForFrame
>+frame "-->" - didStartProvisionalLoadForFrame
>+frame "-->" - didHandleOnloadEventsForFrame
>+frame "-->" - didFinishLoadForFrame
>+http://127.0.0.1:8000/loading/resources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with second:second-pw
>+frame "-->" - didCommitLoadForFrame
>+frame "-->" - didFinishDocumentLoadForFrame
>+frame "-->" - didStartProvisionalLoadForFrame
>+frame "-->" - didHandleOnloadEventsForFrame
>+frame "-->" - didFinishLoadForFrame
>+frame "-->" - didCommitLoadForFrame
>+frame "-->" - didFinishDocumentLoadForFrame
>+frame "-->" - didStartProvisionalLoadForFrame
>+frame "-->" - didHandleOnloadEventsForFrame
>+frame "-->" - didFinishLoadForFrame
>+frame "-->" - didCommitLoadForFrame
>+frame "-->" - didFinishDocumentLoadForFrame
>+frame "-->" - didHandleOnloadEventsForFrame
>+frame "-->" - didFinishLoadForFrame
>+main frame - didFinishLoadForFrame
>+This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.
>+The first frame's path is /loading/resources/subresources/protected-resource.php, and we should get a challenge for it.
>+It will be authorized with first/first-pw.
>+The second frame's path is /loading/resources/protected-resource.php, and we should get a challenge for it, because it does not share a common subpath of the previously authorized resource.
>+It will be authorized with second/second-pw.
>+The third frame's path is also /loading/resources/protected-resource.php, and we should *not* get a challenge for it because we authorized to this path for the second frame.
>+It will be authorized with second/second-pw.
>+The fourth frame's path is /loading/resources/othersubresources/protected-resource.php, and we should *not* get a challenge for it, because it has a common subpath with the previously authorized second and third frames.
>+It will be authorized with second/second-pw.
>+  
>+
>+--------
>+Frame: '-->'
>+--------
>+Authenticated as user: first password: first-pw
>+
>+--------
>+Frame: '-->'
>+--------
>+Authenticated as user: second password: second-pw
>+
>+--------
>+Frame: '-->'
>+--------
>+Authenticated as user: second password: second-pw
>+
>+--------
>+Frame: '-->'
>+--------
>+Authenticated as user: second password: second-pw
>Index: LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt	(working copy)
>+++ LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt	(working copy)
>@@ -2,14 +2,14 @@ main frame - didStartProvisionalLoadForF
> main frame - didCommitLoadForFrame
> frame "-->" - didStartProvisionalLoadForFrame
> main frame - didFinishDocumentLoadForFrame
>-http://127.0.0.1:8000/loading/resources/subresources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with first:first-pw
>+didReceiveAuthenticationChallenge - Responding with first:first-pw
> frame "-->" - didCommitLoadForFrame
> frame "-->" - didFinishDocumentLoadForFrame
> main frame - didHandleOnloadEventsForFrame
> frame "-->" - didStartProvisionalLoadForFrame
> frame "-->" - didHandleOnloadEventsForFrame
> frame "-->" - didFinishLoadForFrame
>-http://127.0.0.1:8000/loading/resources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with second:second-pw
>+didReceiveAuthenticationChallenge - Responding with second:second-pw
> frame "-->" - didCommitLoadForFrame
> frame "-->" - didFinishDocumentLoadForFrame
> frame "-->" - didStartProvisionalLoadForFrame
>Index: LayoutTests/platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt	(revision 166854)	(from LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt:166854)
>+++ LayoutTests/platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt	(working copy)
>@@ -0,0 +1,30 @@
>+main frame - didStartProvisionalLoadForFrame
>+main frame - didCommitLoadForFrame
>+frame "-->" - didStartProvisionalLoadForFrame
>+main frame - didFinishDocumentLoadForFrame
>+frame "-->" - didReceiveServerRedirectForProvisionalLoadForFrame
>+http://localhost:8000/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php - didReceiveAuthenticationChallenge - Responding with httpUsername:httpPassword
>+frame "-->" - didCommitLoadForFrame
>+frame "-->" - didFinishDocumentLoadForFrame
>+frame "-->" - didHandleOnloadEventsForFrame
>+main frame - didHandleOnloadEventsForFrame
>+frame "-->" - didFinishLoadForFrame
>+main frame - didFinishLoadForFrame
>+frame "-->" - willPerformClientRedirectToURL: http://localhost:8000/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php 
>+frame "-->" - didStartProvisionalLoadForFrame
>+frame "-->" - didCancelClientRedirectForFrame
>+frame "-->" - didCommitLoadForFrame
>+frame "-->" - didFinishDocumentLoadForFrame
>+frame "-->" - didHandleOnloadEventsForFrame
>+frame "-->" - didFinishLoadForFrame
>+This test causes an HTTP authentication challenge in the middle of a redirect chain.
>+It then loads a new page after that challenge, and the new page should *not* get any credentials passed to it.
>+See bug 78003 for more details.
>+
>+
>+
>+--------
>+Frame: '-->'
>+--------
>+No HTTP authentication credentials
>+
>Index: LayoutTests/platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt	(working copy)
>+++ LayoutTests/platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt	(working copy)
>@@ -3,7 +3,7 @@ main frame - didCommitLoadForFrame
> frame "-->" - didStartProvisionalLoadForFrame
> main frame - didFinishDocumentLoadForFrame
> frame "-->" - didReceiveServerRedirectForProvisionalLoadForFrame
>-http://localhost:8000/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php - didReceiveAuthenticationChallenge - Responding with httpUsername:httpPassword
>+didReceiveAuthenticationChallenge - Responding with httpUsername:httpPassword
> frame "-->" - didCommitLoadForFrame
> frame "-->" - didFinishDocumentLoadForFrame
> frame "-->" - didHandleOnloadEventsForFrame
>Index: LayoutTests/platform/wk2/http/tests/misc/401-alternative-content-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/misc/401-alternative-content-expected.txt	(revision 166854)	(from LayoutTests/http/tests/misc/401-alternative-content-expected.txt:166854)
>+++ LayoutTests/platform/wk2/http/tests/misc/401-alternative-content-expected.txt	(working copy)
>@@ -0,0 +1,2 @@
>+http://127.0.0.1:8000/misc/401-alternative-content.php - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+PASS
>Index: LayoutTests/platform/wk2/http/tests/misc/401-alternative-content-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/misc/401-alternative-content-expected.txt	(working copy)
>+++ LayoutTests/platform/wk2/http/tests/misc/401-alternative-content-expected.txt	(working copy)
>@@ -1,2 +1,2 @@
>-http://127.0.0.1:8000/misc/401-alternative-content.php - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
> PASS
>Index: LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt	(revision 166854)	(from LayoutTests/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt:166854)
>+++ LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt	(working copy)
>@@ -0,0 +1,27 @@
>+http://localhost:8000/misc/authentication-redirect-1/resources/auth-then-redirect.php?redirect=301 - didReceiveAuthenticationChallenge - Responding with testUser:testPassword
>+https://bugs.webkit.org/show_bug.cgi?id=40138
>+You should load this page at 127.0.0.1:8000 so localhost:8000 is considered a different security origin.
>+This test loads a php script which demands http authentication, then uses it to redirect to another script in a different origin that shows what authentication headers were sent with the final request.
>+It does this once each for HTTP 301, 302, 303, and 307 redirects.
>+If not running under DRT, enter any credentials when asked.
>+
>+
>+--------
>+Frame: '-->'
>+--------
>+Resource loaded with HTTP authentication username '' and password ''
>+
>+--------
>+Frame: '-->'
>+--------
>+Resource loaded with HTTP authentication username '' and password ''
>+
>+--------
>+Frame: '-->'
>+--------
>+Resource loaded with HTTP authentication username '' and password ''
>+
>+--------
>+Frame: '-->'
>+--------
>+Resource loaded with HTTP authentication username '' and password ''
>Index: LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt	(working copy)
>+++ LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt	(working copy)
>@@ -1,4 +1,4 @@
>-http://localhost:8000/misc/authentication-redirect-1/resources/auth-then-redirect.php?redirect=301 - didReceiveAuthenticationChallenge - Responding with testUser:testPassword
>+didReceiveAuthenticationChallenge - Responding with testUser:testPassword
> https://bugs.webkit.org/show_bug.cgi?id=40138
> You should load this page at 127.0.0.1:8000 so localhost:8000 is considered a different security origin.
> This test loads a php script which demands http authentication, then uses it to redirect to another script in a different origin that shows what authentication headers were sent with the final request.
>Index: LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt	(revision 166854)	(from LayoutTests/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt:166854)
>+++ LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt	(working copy)
>@@ -0,0 +1,27 @@
>+http://127.0.0.1:8000/misc/authentication-redirect-2/resources/auth-then-redirect.php?redirect=301 - didReceiveAuthenticationChallenge - Responding with testUser:testPassword
>+https://bugs.webkit.org/show_bug.cgi?id=66354
>+You should load this page at 127.0.0.1:8000 because the test relies on redirects within the 127.0.0.1:8000 security origin.
>+This test loads a php script which demands http authentication, then uses it to redirect to another script in the same origin that shows what authentication headers were sent with the final request.
>+It does this once each for HTTP 301, 302, 303, and 307 redirects.
>+If not running under DRT, enter any credentials when asked.
>+
>+
>+--------
>+Frame: '-->'
>+--------
>+Resource loaded with HTTP authentication username 'testUser' and password 'testPassword'
>+
>+--------
>+Frame: '-->'
>+--------
>+Resource loaded with HTTP authentication username 'testUser' and password 'testPassword'
>+
>+--------
>+Frame: '-->'
>+--------
>+Resource loaded with HTTP authentication username 'testUser' and password 'testPassword'
>+
>+--------
>+Frame: '-->'
>+--------
>+Resource loaded with HTTP authentication username 'testUser' and password 'testPassword'
>Index: LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt	(working copy)
>+++ LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt	(working copy)
>@@ -1,4 +1,4 @@
>-http://127.0.0.1:8000/misc/authentication-redirect-2/resources/auth-then-redirect.php?redirect=301 - didReceiveAuthenticationChallenge - Responding with testUser:testPassword
>+didReceiveAuthenticationChallenge - Responding with testUser:testPassword
> https://bugs.webkit.org/show_bug.cgi?id=66354
> You should load this page at 127.0.0.1:8000 because the test relies on redirects within the 127.0.0.1:8000 security origin.
> This test loads a php script which demands http authentication, then uses it to redirect to another script in the same origin that shows what authentication headers were sent with the final request.
>Index: LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt	(revision 166854)	(from LayoutTests/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt:166854)
>+++ LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt	(working copy)
>@@ -0,0 +1,11 @@
>+http://127.0.0.1:8000/misc/authentication-redirect-4/resources/auth-then-redirect.php?redirect - didReceiveAuthenticationChallenge - Responding with testUser:testPassword
>+https://bugs.webkit.org/show_bug.cgi?id=105190
>+You should load this page at 127.0.0.1:8000 because the test relies on redirects within the 127.0.0.1:8000 security origin.
>+This test loads a php script which demands http authentication, then uses it to redirect via 301 to another script in the same origin that shows what authentication headers were sent with the final request. It verifies that the credentials are not placed in the final URL.
>+If not running under DRT, enter any credentials when asked.
>+
>+
>+--------
>+Frame: '-->'
>+--------
>+http://127.0.0.1:8000/misc/authentication-redirect-4/resources/auth-echo.php loaded with HTTP authentication username 'testUser' and password 'testPassword'
>Index: LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt	(working copy)
>+++ LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt	(working copy)
>@@ -1,4 +1,4 @@
>-http://127.0.0.1:8000/misc/authentication-redirect-4/resources/auth-then-redirect.php?redirect - didReceiveAuthenticationChallenge - Responding with testUser:testPassword
>+didReceiveAuthenticationChallenge - Responding with testUser:testPassword
> https://bugs.webkit.org/show_bug.cgi?id=105190
> You should load this page at 127.0.0.1:8000 because the test relies on redirects within the 127.0.0.1:8000 security origin.
> This test loads a php script which demands http authentication, then uses it to redirect via 301 to another script in the same origin that shows what authentication headers were sent with the final request. It verifies that the credentials are not placed in the final URL.
>Index: LayoutTests/platform/wk2/http/tests/security/401-logout/401-logout-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/security/401-logout/401-logout-expected.txt	(revision 166854)	(from LayoutTests/http/tests/security/401-logout/401-logout-expected.txt:166854)
>+++ LayoutTests/platform/wk2/http/tests/security/401-logout/401-logout-expected.txt	(working copy)
>@@ -0,0 +1,3 @@
>+http://127.0.0.1:8000/security/401-logout/401-logout.php?uid=username - didReceiveAuthenticationChallenge - Responding with username:password
>+http://127.0.0.1:8000/security/401-logout/401-logout.php?uid=username&logout=1 - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+PASS
>Index: LayoutTests/platform/wk2/http/tests/security/401-logout/401-logout-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/security/401-logout/401-logout-expected.txt	(working copy)
>+++ LayoutTests/platform/wk2/http/tests/security/401-logout/401-logout-expected.txt	(working copy)
>@@ -1,3 +1,3 @@
>-http://127.0.0.1:8000/security/401-logout/401-logout.php?uid=username - didReceiveAuthenticationChallenge - Responding with username:password
>-http://127.0.0.1:8000/security/401-logout/401-logout.php?uid=username&logout=1 - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+didReceiveAuthenticationChallenge - Responding with username:password
>+didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
> PASS
>Index: LayoutTests/platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt	(revision 166854)	(from LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt:166854)
>+++ LayoutTests/platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt	(working copy)
>@@ -0,0 +1,8 @@
>+http://127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=login3 - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+http://badname:passpw@127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=login4 - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+Test for bug 13075: XMLHttpRequest with failed authentication should set status to 401.
>+
>+Sync, no credentials: OK
>+Sync, incorrect credentials: OK
>+Async, no credentials: OK
>+Async, incorrect credentials: OK
>Index: LayoutTests/platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt	(working copy)
>+++ LayoutTests/platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt	(working copy)
>@@ -1,5 +1,5 @@
>-http://127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=login3 - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>-http://badname:passpw@127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=login4 - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
> Test for bug 13075: XMLHttpRequest with failed authentication should set status to 401.
> 
> Sync, no credentials: OK
>Index: LayoutTests/platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt	(revision 166854)	(from LayoutTests/http/tests/xmlhttprequest/remember-bad-password-expected.txt:166854)
>+++ LayoutTests/platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt	(working copy)
>@@ -0,0 +1,13 @@
>+http://foo:bar@127.0.0.1:8000/xmlhttprequest/resources/remember-bad-password/count-failures.php - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+http://127.0.0.1:8000/xmlhttprequest/resources/remember-bad-password/count-failures.php - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+rdar://problem/7062824 A wrong password entered for site or proxy auth remains in WebCore credential storage, and is sent with subsequent requests.
>+
>+This test counts the number of failed requests server side.
>+
>+PASS
>+
>+Sync
>+With credentials Without credentials
>+Async
>+With credentials Without credentials 
>+Status
>Index: LayoutTests/platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt
>===================================================================
>--- LayoutTests/platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt	(working copy)
>+++ LayoutTests/platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt	(working copy)
>@@ -1,5 +1,5 @@
>-http://foo:bar@127.0.0.1:8000/xmlhttprequest/resources/remember-bad-password/count-failures.php - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>-http://127.0.0.1:8000/xmlhttprequest/resources/remember-bad-password/count-failures.php - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
>+didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
> rdar://problem/7062824 A wrong password entered for site or proxy auth remains in WebCore credential storage, and is sent with subsequent requests.
> 
> This test counts the number of failed requests server side.

Flags:

andersca: review+
buildbot: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 81627: 228815 | 228826 | 228827 | 228942