Attachment 225959 Details for Bug 129785 – the patch

[patch] the patch

blah.patch (text/plain), 2.84 KB, created by Filip Pizlo on 2014-03-05 23:52:14 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2014-03-05 23:52:14 PST

Size: 2.84 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 165174)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2014-03-05  Filip Pizlo  <fpizlo@apple.com>
>+
>+        Use the LLVM disassembler on ARM64 if we are enabling the FTL
>+        https://bugs.webkit.org/show_bug.cgi?id=129785
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        Our disassembler can't handle some of the code sequences that LLVM emits. LLVM's disassembler
>+        is strictly more capable at this point. Use it if it's available.
>+
>+        * disassembler/ARM64Disassembler.cpp:
>+        (JSC::tryToDisassemble):
>+
> 2014-03-05  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Reduce RWI message frequency
>Index: Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp
>===================================================================
>--- Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp	(revision 165128)
>+++ Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp	(working copy)
>@@ -1,5 +1,5 @@
> /*
>- * Copyright (C) 2012 Apple Inc. All rights reserved.
>+ * Copyright (C) 2012, 2014 Apple Inc. All rights reserved.
>  *
>  * Redistribution and use in source and binary forms, with or without
>  * modification, are permitted provided that the following conditions
>@@ -55,3 +55,17 @@ bool tryToDisassemble(const MacroAssembl
> 
> #endif // USE(ARM64_DISASSEMBLER)
> 
>+#if USE(LLVM_DISASSEMBLER)
>+
>+#include "LLVMDisassembler.h"
>+
>+namespace JSC {
>+
>+bool tryToDisassemble(const MacroAssemblerCodePtr& codePtr, size_t size, const char* prefix, PrintStream& out, InstructionSubsetHint hint)
>+{
>+    return tryToDisassembleWithLLVM(codePtr, size, prefix, out, hint);
>+}
>+
>+} // namespace JSC
>+
>+#endif // USE(LLVM_DISASSEMBLER)
>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 165174)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2014-03-05  Filip Pizlo  <fpizlo@apple.com>
>+
>+        Use the LLVM disassembler on ARM64 if we are enabling the FTL
>+        https://bugs.webkit.org/show_bug.cgi?id=129785
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/Platform.h:
>+
> 2014-03-05  peavo@outlook.com  <peavo@outlook.com>
> 
>         [Win32][LLINT] Crash when running JSC stress tests.
>Index: Source/WTF/wtf/Platform.h
>===================================================================
>--- Source/WTF/wtf/Platform.h	(revision 165128)
>+++ Source/WTF/wtf/Platform.h	(working copy)
>@@ -677,7 +677,7 @@
> #define ENABLE_DISASSEMBLER 1
> #endif
> 
>-#if !defined(WTF_USE_ARM64_DISASSEMBLER) && ENABLE(JIT) && PLATFORM(IOS) && CPU(ARM64)
>+#if !defined(WTF_USE_ARM64_DISASSEMBLER) && ENABLE(JIT) && PLATFORM(IOS) && CPU(ARM64) && !USE(LLVM_DISASSEMBLER)
> #define WTF_USE_ARM64_DISASSEMBLER 1
> #endif
>

Actions: View | Formatted Diff | Diff

Attachments on bug 129785: 225959