Attachment 224594 Details for Bug 129026 – Fixes the bug

[patch] Fixes the bug

bug-129026-20140218222020.patch (text/plain), 1.49 KB, created by Ryosuke Niwa on 2014-02-18 22:19:58 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2014-02-18 22:19:58 PST

Size: 1.49 KB

patch

obsolete

>Subversion Revision: 164331
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 76460550c29ffef8fc9ff2c2b3895ccc3b0738d3..5e1dee9365b3f255abb4205f530a45b190e320e9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2014-02-19  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        isEditablePosition shouldn't trigger synchronous layout
>+        https://bugs.webkit.org/show_bug.cgi?id=129026
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Just trigger style recalc instead.
>+
>+        * editing/htmlediting.cpp:
>+        (WebCore::isEditablePosition):
>+
> 2014-02-18  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Changing selection shouldn't synchronously update editor UI components
>diff --git a/Source/WebCore/editing/htmlediting.cpp b/Source/WebCore/editing/htmlediting.cpp
>index d7a9293e254f5d74b7f7a1b630a63040589aa287..3b7276572d43743cd75bbd9c76f968000512c204 100644
>--- a/Source/WebCore/editing/htmlediting.cpp
>+++ b/Source/WebCore/editing/htmlediting.cpp
>@@ -146,13 +146,13 @@ bool isEditablePosition(const Position& p, EditableType editableType, EUpdateSty
>     if (!node)
>         return false;
>     if (updateStyle == UpdateStyle)
>-        node->document().updateLayoutIgnorePendingStylesheets();
>+        node->document().updateStyleIfNeeded();
>     else
>         ASSERT(updateStyle == DoNotUpdateStyle);
> 
>     if (node->renderer() && node->renderer()->isTable())
>         node = node->parentNode();
>-    
>+
>     return node->hasEditableStyle(editableType);
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 129026: 224594