Attachment 224465 Details for Bug 128949 – Removed ML specific expected results

[patch] Removed ML specific expected results

bug-128949-20140217210000.patch (text/plain), 28.46 KB, created by Ryosuke Niwa on 2014-02-17 20:59:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2014-02-17 20:59:43 PST

Size: 28.46 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 164266)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,43 @@
>+2014-02-17  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        setSelectionRange should set selection without validation
>+        https://bugs.webkit.org/show_bug.cgi?id=128949
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Since positionForIndex in HTMLTextFormControlElement always returns a candidate Position, we don't have to
>+        validate selection in setSelectionRange.
>+
>+        Also fixed various bugs uncovered by this change.
>+
>+        This patch also fixes fast/forms/input-select-webkit-user-select-none.html, which used to assert wrong outcome
>+        so that WebKit's behavior matches that of Chrome and Firefox.
>+
>+        Test: fast/forms/input-select-webkit-user-select-none.html
>+
>+        * dom/Position.h:
>+        (WebCore::positionInParentBeforeNode): This function had a bug that when node is a child of the shadow root
>+        it would return a null Position. Allow a position anchored inside a shadow root.
>+        (WebCore::positionInParentAfterNode): Ditto.
>+
>+        * editing/FrameSelection.cpp:
>+        (WebCore::FrameSelection::moveWithoutValidationTo): Renamed from moveTo and avoided selection validation.
>+        * editing/FrameSelection.h:
>+
>+        * editing/htmlediting.cpp:
>+        (WebCore::updatePositionForNodeRemoval): Fixed the bug that this function doesn't update positions before
>+        or after children even if the shadow host of the anchor node is getting removed. Move the position before
>+        the shadow host to be removed in both situations.
>+
>+        * html/HTMLTextFormControlElement.cpp:
>+        (WebCore::HTMLTextFormControlElement::setSelectionRange): moveTo is renamed to moveWithoutValidationTo.
>+        (WebCore::HTMLTextFormControlElement::selectionChanged): Check if the cached selection offsets are different
>+        in lieu of FrameSelection::isRange() since they're equivalent here.
>+        (WebCore::positionForIndex): Return the position inside or after the last br when there is one to match
>+        the canonicalization algorithm we have. It's probably harmless to return the last position in the inner text
>+        element anyways since most of our codebase supports that but this would avoid having to rebaseline dozens
>+        of tests and reduces the risk of this patch.
>+
> 2014-02-17  Dean Jackson  <dino@apple.com>
> 
>         Constrain replaced element layout to from-intrinsic aspect ratio if specified
>Index: Source/WebCore/dom/Position.h
>===================================================================
>--- Source/WebCore/dom/Position.h	(revision 164250)
>+++ Source/WebCore/dom/Position.h	(working copy)
>@@ -276,13 +276,13 @@ inline Position positionInParentBeforeNo
>     // At least one caller currently hits this ASSERT though, which indicates
>     // that the caller is trying to make a position relative to a disconnected node (which is likely an error)
>     // Specifically, editing/deleting/delete-ligature-001.html crashes with ASSERT(node->parentNode())
>-    return Position(Position::findParent(node), node->nodeIndex(), Position::PositionIsOffsetInAnchor);
>+    return Position(node->parentNode(), node->nodeIndex(), Position::PositionIsOffsetInAnchor);
> }
> 
> inline Position positionInParentAfterNode(const Node* node)
> {
>-    ASSERT(Position::findParent(node));
>-    return Position(Position::findParent(node), node->nodeIndex() + 1, Position::PositionIsOffsetInAnchor);
>+    ASSERT(node->parentNode());
>+    return Position(node->parentNode(), node->nodeIndex() + 1, Position::PositionIsOffsetInAnchor);
> }
> 
> // positionBeforeNode and positionAfterNode return neighbor-anchored positions, construction is O(1)
>Index: Source/WebCore/editing/FrameSelection.cpp
>===================================================================
>--- Source/WebCore/editing/FrameSelection.cpp	(revision 164250)
>+++ Source/WebCore/editing/FrameSelection.cpp	(working copy)
>@@ -164,10 +164,12 @@ void FrameSelection::moveTo(const Positi
>     setSelection(VisibleSelection(base, extent, affinity, selectionHasDirection), defaultSetSelectionOptions(userTriggered));
> }
> 
>-void FrameSelection::moveTo(const Position& base, const Position& extent, bool selectionHasDirection, bool shouldSetFocus)
>+void FrameSelection::moveWithoutValidationTo(const Position& base, const Position& extent, bool selectionHasDirection, bool shouldSetFocus)
> {
>-    setSelection(VisibleSelection(base, extent, DOWNSTREAM, selectionHasDirection),
>-        defaultSetSelectionOptions() | (shouldSetFocus ? 0 : DoNotSetFocus));
>+    VisibleSelection newSelection;
>+    newSelection.setWithoutValidation(base, extent);
>+    newSelection.setIsDirectional(selectionHasDirection);
>+    setSelection(newSelection, defaultSetSelectionOptions() | (shouldSetFocus ? 0 : DoNotSetFocus));
> }
> 
> void DragCaretController::setCaretPosition(const VisiblePosition& position)
>Index: Source/WebCore/editing/FrameSelection.h
>===================================================================
>--- Source/WebCore/editing/FrameSelection.h	(revision 164250)
>+++ Source/WebCore/editing/FrameSelection.h	(working copy)
>@@ -140,7 +140,7 @@ public:
>     void moveTo(const VisiblePosition&, const VisiblePosition&, EUserTriggered = NotUserTriggered);
>     void moveTo(const Position&, EAffinity, EUserTriggered = NotUserTriggered);
>     void moveTo(const Position&, const Position&, EAffinity, EUserTriggered = NotUserTriggered);
>-    void moveTo(const Position&, const Position&, bool selectionHasDirection, bool shouldSetFocus);
>+    void moveWithoutValidationTo(const Position&, const Position&, bool selectionHasDirection, bool shouldSetFocus);
> 
>     const VisibleSelection& selection() const { return m_selection; }
>     void setSelection(const VisibleSelection&, SetSelectionOptions = defaultSetSelectionOptions(), CursorAlignOnScroll = AlignCursorOnScrollIfNeeded, TextGranularity = CharacterGranularity);
>Index: Source/WebCore/editing/htmlediting.cpp
>===================================================================
>--- Source/WebCore/editing/htmlediting.cpp	(revision 164250)
>+++ Source/WebCore/editing/htmlediting.cpp	(working copy)
>@@ -988,12 +988,12 @@ void updatePositionForNodeRemoval(Positi
>         return;
>     switch (position.anchorType()) {
>     case Position::PositionIsBeforeChildren:
>-        if (position.containerNode() == node)
>+        if (node->containsIncludingShadowDOM(position.containerNode()))
>             position = positionInParentBeforeNode(node);
>         break;
>     case Position::PositionIsAfterChildren:
>-        if (position.containerNode() == node)
>-            position = positionInParentAfterNode(node);
>+        if (node->containsIncludingShadowDOM(position.containerNode()))
>+            position = positionInParentBeforeNode(node);
>         break;
>     case Position::PositionIsOffsetInAnchor:
>         if (position.containerNode() == node->parentNode() && static_cast<unsigned>(position.offsetInContainerNode()) > node->nodeIndex())
>Index: Source/WebCore/html/HTMLTextFormControlElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLTextFormControlElement.cpp	(revision 164250)
>+++ Source/WebCore/html/HTMLTextFormControlElement.cpp	(working copy)
>@@ -315,7 +315,7 @@ void HTMLTextFormControlElement::setSele
>     }
> 
>     if (Frame* frame = document().frame())
>-        frame->selection().moveTo(startPosition, endPosition, direction != SelectionHasNoDirection, !hasFocus);
>+        frame->selection().moveWithoutValidationTo(startPosition, endPosition, direction != SelectionHasNoDirection, !hasFocus);
> }
> 
> int HTMLTextFormControlElement::indexForVisiblePosition(const VisiblePosition& position) const
>@@ -480,13 +480,8 @@ void HTMLTextFormControlElement::selecti
>     // selectionStart() or selectionEnd() will return cached selection when this node doesn't have focus
>     cacheSelection(computeSelectionStart(), computeSelectionEnd(), computeSelectionDirection());
>     
>-    if (!shouldFireSelectEvent)
>-        return;
>-
>-    if (Frame* frame = document().frame()) {
>-        if (frame->selection().isRange())
>-            dispatchEvent(Event::create(eventNames().selectEvent, true, false));
>-    }
>+    if (shouldFireSelectEvent && m_cachedSelectionStart != m_cachedSelectionEnd)
>+        dispatchEvent(Event::create(eventNames().selectEvent, true, false));
> }
> 
> void HTMLTextFormControlElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
>@@ -556,19 +551,22 @@ String HTMLTextFormControlElement::inner
> static Position positionForIndex(TextControlInnerTextElement* innerText, unsigned index)
> {
>     unsigned remainingCharactersToMoveForward = index;
>+    Node* lastBrOrText = innerText;
>     for (Node* node = innerText; node; node = NodeTraversal::next(node, innerText)) {
>         if (node->hasTagName(brTag)) {
>             if (!remainingCharactersToMoveForward)
>                 return positionBeforeNode(node);
>             remainingCharactersToMoveForward--;
>+            lastBrOrText = node;
>         } else if (node->isTextNode()) {
>             Text& text = toText(*node);
>             if (remainingCharactersToMoveForward < text.length())
>                 return Position(&text, remainingCharactersToMoveForward);
>             remainingCharactersToMoveForward -= text.length();
>+            lastBrOrText = node;
>         }
>     }
>-    return lastPositionInNode(innerText);
>+    return lastPositionInOrAfterNode(lastBrOrText);
> }
> 
> unsigned HTMLTextFormControlElement::indexForPosition(const Position& passedPosition) const
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 164266)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,34 @@
>+2014-02-17  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        setSelectionRange should set selection without validation
>+        https://bugs.webkit.org/show_bug.cgi?id=128949
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fixed input-select-webkit-user-select-none.html which was erroneously asserting selectionStart and selectionEnd
>+        of a text field to be zero when it has -webkit-user-select: none. This doesn't not match behaviors of Chrome
>+        and Firefox. They both retain the programatically set selection offsets since such style should not bleed into
>+        the shadow DOM of the text field in the first place.
>+
>+        New behavior matches the latest Firefox and Chrome although we still have the bug that user cannot select text
>+        inside such a text field.
>+
>+        Also modernized LayoutTests/editing/selection/5497643.html to make the expected results more readable and made
>+        the test more robust against changes in the node index of textarea element.
>+
>+        * editing/selection/5497643-expected.txt: See above.
>+        * editing/selection/5497643.html:
>+        * fast/forms/input-select-webkit-user-select-none-expected.txt: See above.
>+        * fast/forms/input-select-webkit-user-select-none.html:
>+        * editing/deleting/delete-ligature-001-expected.txt: Progression in the editing delegate callbacks dumps.
>+        Now we set selection directly into the text node inside the inner text element.
>+        * platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Ditto.
>+        * platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Ditto.
>+        * platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
>+        Removed.
>+        * platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
>+        Removed.
>+
> 2014-02-17  Dean Jackson  <dino@apple.com>
> 
>         Constrain replaced element layout to from-intrinsic aspect ratio if specified
>Index: LayoutTests/editing/deleting/delete-ligature-001-expected.txt
>===================================================================
>--- LayoutTests/editing/deleting/delete-ligature-001-expected.txt	(revision 164250)
>+++ LayoutTests/editing/deleting/delete-ligature-001-expected.txt	(working copy)
>@@ -1,6 +1,6 @@
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > #document-fragment to 0 of DIV > #document-fragment toDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
>+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment toDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
> EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment toDOMRange:range from 2 of #text > DIV > #document-fragment to 2 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
>Index: LayoutTests/editing/selection/5497643-expected.txt
>===================================================================
>--- LayoutTests/editing/selection/5497643-expected.txt	(revision 164250)
>+++ LayoutTests/editing/selection/5497643-expected.txt	(working copy)
>@@ -1,4 +1,10 @@
>-ALERT: SUCCESS: Selection is set to position 2 of BODY.
>+textareaOffset = nodeIndex(textarea); textarea.setSelectionRange(0, 0); textarea.parentNode.removeChild(textarea);
>+PASS getSelection().type is 'Caret'
>+PASS getSelection().getRangeAt(0).startContainer is document.body
>+PASS getSelection().getRangeAt(0).startOffset is textareaOffset
>+PASS successfullyParsed is true
>+
>+TEST COMPLETE
> This tests to make sure that a selection inside a textarea is updated when the textarea is removed from the document.
> 
> 
>Index: LayoutTests/editing/selection/5497643.html
>===================================================================
>--- LayoutTests/editing/selection/5497643.html	(revision 164250)
>+++ LayoutTests/editing/selection/5497643.html	(working copy)
>@@ -1,15 +1,22 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
> <p>This tests to make sure that a selection inside a textarea is updated when the textarea is removed from the document.</p>
> <textarea id="textarea"></textarea>
>+<script src="../../resources/js-test-pre.js"></script>
> <script>
> if (window.testRunner)
>     window.testRunner.dumpAsText();
>+function nodeIndex(node) {
>+    return Array.prototype.slice.call(node.parentNode.childNodes).indexOf(node);
>+}
> textarea = document.getElementById("textarea");
>-textarea.setSelectionRange(0, 0);
>-textarea.parentNode.removeChild(textarea);
>-if (window.getSelection().type == 'Caret' &&
>-    window.getSelection().getRangeAt(0).startContainer == document.body && 
>-    window.getSelection().getRangeAt(0).startOffset == 2)
>-    alert("SUCCESS: Selection is set to position 2 of BODY.")
>-else
>-    alert("FAILURE: The selection is not set correctly after textarea was deleted.")
>+evalAndLog("textareaOffset = nodeIndex(textarea); textarea.setSelectionRange(0, 0); textarea.parentNode.removeChild(textarea);");
>+shouldBe("getSelection().type", "'Caret'");
>+shouldBe("getSelection().getRangeAt(0).startContainer", "document.body");
>+shouldBe("getSelection().getRangeAt(0).startOffset", "textareaOffset");
>+var successfullyParsed = true;
> </script>
>+<script src="../../resources/js-test-post.js"></script>
>+</body>
>+</html>
>Index: LayoutTests/fast/forms/input-select-webkit-user-select-none-expected.txt
>===================================================================
>--- LayoutTests/fast/forms/input-select-webkit-user-select-none-expected.txt	(revision 164250)
>+++ LayoutTests/fast/forms/input-select-webkit-user-select-none-expected.txt	(working copy)
>@@ -1,5 +1,12 @@
> Tests behavior of select() in case "-webkit-user-select: none" attribute is specified to the input element. The field should not be selected.
> 
>+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> 
> 
>-PASS
>+PASS input.select(); input.selectionStart is 0
>+PASS input.selectionEnd is input.value.length
>+PASS input.value.length is not 0
>+PASS successfullyParsed is true
>+
>+TEST COMPLETE
>+
>Index: LayoutTests/fast/forms/input-select-webkit-user-select-none.html
>===================================================================
>--- LayoutTests/fast/forms/input-select-webkit-user-select-none.html	(revision 164250)
>+++ LayoutTests/fast/forms/input-select-webkit-user-select-none.html	(working copy)
>@@ -1,26 +1,25 @@
>+<!DOCTYPE html>
> <html>
>-<head>
>+<body onload="test()">
>+<script src="../../resources/js-test-pre.js"></script>
> <script>
>+description("Tests behavior of select() in case &quot;-webkit-user-select: none&quot;"
>+    + " attribute is specified to the input element. The field should not be selected.");
>+
> function test() {
>     if (window.testRunner)
>         testRunner.dumpAsText();
>-    var tf = document.getElementById('tf');
>-    tf.select();
>-    if (tf.selectionStart == 0 && tf.selectionEnd == 0) { // ;
>-        document.getElementById("result").innerHTML = "PASS";
>-    } else {
>-        document.getElementById("result").innerHTML = "FAIL: selection start is "
>-            + tf.selectionStart + " and end is " + tf.selectionEnd + ".";
>-    }
>+    window.input = document.querySelector('input');
>+    shouldBe("input.select(); input.selectionStart", "0");
>+    shouldBe("input.selectionEnd", "input.value.length");
>+    shouldNotBe("input.value.length", "0");
>+    finishJSTest();
> }
>+
>+var successfullyParsed = true;
>+var jsTestIsAsync = true;
> </script>
>-</head>
>-<body onload="test()">
>-<p>
>-Tests behavior of select() in case &quot;-webkit-user-select: none&quot;
>-attribute is specified to the input element. The field should not be selected.
>-</p>
>-<p><input type="text" id="tf" value="input text" style="-webkit-user-select: none"></input></p>
>-<p id="result">TEST NOT RUN YET</p>
>+<script src="../../resources/js-test-post.js"></script>
>+<p><input type="text" value="input text" style="-webkit-user-select: none; -moz-user-select: none;"></input></p>
> </body>
> </html>
>Index: LayoutTests/platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt
>===================================================================
>--- LayoutTests/platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt	(revision 164250)
>+++ LayoutTests/platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt	(working copy)
>@@ -1,36 +0,0 @@
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > #document-fragment to 0 of DIV > #document-fragment toDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > #document-fragment to 0 of DIV > #document-fragment toDOMRange:range from 6 of #text > DIV > #document-fragment to 6 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > DIV > #document-fragment to 7 of #text > DIV > #document-fragment toDOMRange:range from 8 of #text > DIV > #document-fragment to 8 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
>-layer at (0,0) size 800x600
>-  RenderView at (0,0) size 800x600
>-layer at (0,0) size 800x600
>-  RenderBlock {HTML} at (0,0) size 800x600
>-    RenderBody {BODY} at (8,8) size 784x584
>-      RenderBlock {DIV} at (0,0) size 784x36
>-        RenderText {#text} at (0,0) size 771x36
>-          text run at (0,0) width 771: "The test verified that autocorrection does not occur when user starts typing a word. You should see the phrase \"mesage m\""
>-          text run at (0,18) width 200: "with red underline on \"mesage\""
>-      RenderBlock {P} at (0,52) size 784x54 [color=#008000]
>-        RenderText {#text} at (0,0) size 783x54
>-          text run at (0,0) width 766: "Note, this test can fail due to user specific spell checking data. If the user has previously dismissed 'message' as the correct"
>-          text run at (0,18) width 783: "spelling of 'mesage' several times, the spell checker will not provide 'notational' as a suggestion anymore. To fix this, remove"
>-          text run at (0,36) width 185: "all files in ~/Library/Spelling."
>-      RenderBlock (anonymous) at (0,122) size 784x140
>-        RenderText {#text} at (0,0) size 0x0
>-        RenderText {#text} at (0,0) size 0x0
>-layer at (10,132) size 581x136 clip at (11,133) size 579x134
>-  RenderTextControl {TEXTAREA} at (2,2) size 581x136 [bgcolor=#FFFFFF] [border: (1px solid #000000)]
>-    RenderBlock {DIV} at (3,3) size 575x13
>-      RenderText {#text} at (0,0) size 55x13
>-        text run at (0,0) width 55: "mesage m"
>-caret: position 8 of child 0 {#text} of child 0 {DIV} of {#document-fragment} of child 5 {TEXTAREA} of body
>Index: LayoutTests/platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt
>===================================================================
>--- LayoutTests/platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt	(revision 164250)
>+++ LayoutTests/platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt	(working copy)
>@@ -1,40 +0,0 @@
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > #document-fragment to 0 of DIV > #document-fragment toDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > #document-fragment to 0 of DIV > #document-fragment toDOMRange:range from 6 of #text > DIV > #document-fragment to 6 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > DIV > #document-fragment to 7 of #text > DIV > #document-fragment toDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
>-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
>-layer at (0,0) size 800x600
>-  RenderView at (0,0) size 800x600
>-layer at (0,0) size 800x600
>-  RenderBlock {HTML} at (0,0) size 800x600
>-    RenderBody {BODY} at (8,8) size 784x584
>-      RenderBlock {DIV} at (0,0) size 784x36
>-        RenderText {#text} at (0,0) size 771x36
>-          text run at (0,0) width 771: "The test verified that autocorrection does not occur when user starts typing a word. You should see the phrase \"mesage \\n\""
>-          text run at (0,18) width 200: "with red underline on \"mesage\""
>-      RenderBlock {P} at (0,52) size 784x54 [color=#008000]
>-        RenderText {#text} at (0,0) size 783x54
>-          text run at (0,0) width 766: "Note, this test can fail due to user specific spell checking data. If the user has previously dismissed 'message' as the correct"
>-          text run at (0,18) width 783: "spelling of 'mesage' several times, the spell checker will not provide 'notational' as a suggestion anymore. To fix this, remove"
>-          text run at (0,36) width 185: "all files in ~/Library/Spelling."
>-      RenderBlock (anonymous) at (0,122) size 784x140
>-        RenderText {#text} at (0,0) size 0x0
>-        RenderText {#text} at (0,0) size 0x0
>-layer at (10,132) size 581x136 clip at (11,133) size 579x134
>-  RenderTextControl {TEXTAREA} at (2,2) size 581x136 [bgcolor=#FFFFFF] [border: (1px solid #000000)]
>-    RenderBlock {DIV} at (3,3) size 575x26
>-      RenderText {#text} at (0,0) size 45x13
>-        text run at (0,0) width 45: "mesage "
>-      RenderText {#text} at (44,0) size 1x13
>-        text run at (44,0) width 1: " "
>-      RenderText {#text} at (0,13) size 0x13
>-        text run at (0,13) width 0: " "
>-caret: position 0 of child 2 {#text} of child 0 {DIV} of {#document-fragment} of child 5 {TEXTAREA} of body
>Index: LayoutTests/platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt
>===================================================================
>--- LayoutTests/platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt	(revision 164250)
>+++ LayoutTests/platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt	(working copy)
>@@ -1,6 +1,6 @@
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > #document-fragment to 0 of DIV > #document-fragment toDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
>+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment toDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>Index: LayoutTests/platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt
>===================================================================
>--- LayoutTests/platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt	(revision 164250)
>+++ LayoutTests/platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt	(working copy)
>@@ -1,6 +1,6 @@
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > #document-fragment to 0 of DIV > #document-fragment toDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
>+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment toDOMRange:range from 1 of #text > DIV > #document-fragment to 1 of #text > DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
> EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification

Actions: View | Formatted Diff | Diff

Attachments on bug 128949: 224460 | 224464 | 224465 | 224469 | 224473 | 224474 | 224528