Attachment 220072 Details for Bug 126130 – Updated patch

[patch] Updated patch

wk2-network-process-languages.diff (text/plain), 10.13 KB, created by Carlos Garcia Campos on 2013-12-28 02:26:24 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2013-12-28 02:26:24 PST

Size: 10.13 KB

patch

obsolete

>diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
>index f804229..9b2b498 100644
>--- a/Source/WebKit2/ChangeLog
>+++ b/Source/WebKit2/ChangeLog
>@@ -1,5 +1,45 @@
> 2013-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>+        [GTK] Test /webkit2/WebKitWebContext/languages crashes with network process enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=126130
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We need to notify the network process when the user preferred
>+        languages have changed to update the SoupSession accordingly.
>+
>+        * NetworkProcess/NetworkProcess.h: Add
>+        userPreferredLanguagesChanged when using soup network backend.
>+        * NetworkProcess/NetworkProcess.messages.in: Add
>+        UserPreferredLanguagesChanged message when using soup network
>+        backend.
>+        * NetworkProcess/soup/NetworkProcessSoup.cpp:
>+        (WebKit::buildAcceptLanguages): Helper function to build the
>+        languages string.
>+        (WebKit::NetworkProcess::userPreferredLanguagesChanged): Update
>+        the SoupSession to use the given languages.
>+        (WebKit::NetworkProcess::platformInitializeNetworkProcess): Call
>+        userPreferredLanguagesChanged() when initialization parameters
>+        contain languages.
>+        (WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
>+        Remove unnedded WebCore prefix.
>+        (WebKit::NetworkProcess::clearCacheForAllOrigins): Simplify using
>+        a single line.
>+        * Shared/Network/NetworkProcessCreationParameters.cpp:
>+        (WebKit::NetworkProcessCreationParameters::encode): Encode the
>+        languages vector.
>+        (WebKit::NetworkProcessCreationParameters::decode): Decode the
>+        languages vector.
>+        * Shared/Network/NetworkProcessCreationParameters.h:
>+        * UIProcess/WebContext.cpp:
>+        (WebKit::WebContext::languageChanged): Send a message also to the
>+        network process.
>+        * UIProcess/soup/WebContextSoup.cpp:
>+        (WebKit::WebContext::platformInitializeNetworkProcess): Set
>+        languages initial parameter.
>+
>+2013-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>         Define WebProcess::usesNetworkProcess unconditionally
>         https://bugs.webkit.org/show_bug.cgi?id=126208
> 
>diff --git a/Source/WebKit2/NetworkProcess/NetworkProcess.h b/Source/WebKit2/NetworkProcess/NetworkProcess.h
>index 5b224fd..4a0b354 100644
>--- a/Source/WebKit2/NetworkProcess/NetworkProcess.h
>+++ b/Source/WebKit2/NetworkProcess/NetworkProcess.h
>@@ -115,6 +115,7 @@ private:
> 
> #if USE(SOUP)
>     void setIgnoreTLSErrors(bool);
>+    void userPreferredLanguagesChanged(Vector<String>);
> #endif
> 
>     // Platform Helpers
>diff --git a/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in b/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in
>index 3525d6c..6ad6c25 100644
>--- a/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in
>+++ b/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in
>@@ -31,6 +31,7 @@ messages -> NetworkProcess LegacyReceiver {
> 
> #if USE(SOUP)
>     SetIgnoreTLSErrors(bool ignoreTLSErrors)
>+    UserPreferredLanguagesChanged(Vector<String> languages)
> #endif
> 
>     EnsurePrivateBrowsingSession()
>diff --git a/Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp b/Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp
>index 6d7cf97..b6fdf1e 100644
>--- a/Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp
>+++ b/Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp
>@@ -28,16 +28,18 @@
> #if ENABLE(NETWORK_PROCESS)
> #include "NetworkProcess.h"
> 
>-#include "CertificateInfo.h"
> #include "NetworkProcessCreationParameters.h"
> #include "ResourceCachesToClear.h"
> #include "WebCookieManager.h"
>+#include <WebCore/CertificateInfo.h>
> #include <WebCore/FileSystem.h>
> #include <WebCore/NotImplemented.h>
> #include <WebCore/ResourceHandle.h>
> #include <libsoup/soup.h>
> #include <wtf/gobject/GOwnPtr.h>
> #include <wtf/gobject/GRefPtr.h>
>+#include <wtf/text/CString.h>
>+#include <wtf/text/StringBuilder.h>
> 
> using namespace WebCore;
> 
>@@ -74,11 +76,56 @@ static uint64_t getMemorySize()
> #endif
> }
> 
>+// This function is based on Epiphany code in ephy-embed-prefs.c.
>+static CString buildAcceptLanguages(Vector<String> languages)
>+{
>+    // Ignore "C" locale.
>+    size_t position = languages.find("c");
>+    if (position != notFound)
>+        languages.remove(position);
>+
>+    // Fallback to "en" if the list is empty.
>+    if (languages.isEmpty())
>+        return "en";
>+
>+    // Calculate deltas for the quality values.
>+    int delta;
>+    if (languages.size() < 10)
>+        delta = 10;
>+    else if (languages.size() < 20)
>+        delta = 5;
>+    else
>+        delta = 1;
>+
>+    // Set quality values for each language.
>+    StringBuilder builder;
>+    for (size_t i = 0; i < languages.size(); ++i) {
>+        if (i)
>+            builder.append(", ");
>+
>+        builder.append(languages[i]);
>+
>+        int quality = 100 - i * delta;
>+        if (quality > 0 && quality < 100) {
>+            char buffer[8];
>+            g_ascii_formatd(buffer, 8, "%.2f", quality / 100.0);
>+            builder.append(String::format(";q=%s", buffer));
>+        }
>+    }
>+
>+    return builder.toString().utf8();
>+}
>+
>+void NetworkProcess::userPreferredLanguagesChanged(Vector<String> languages)
>+{
>+    g_object_set(ResourceHandle::defaultSession(), "accept-language", buildAcceptLanguages(languages).data(), nullptr);
>+}
>+
> void NetworkProcess::platformInitializeNetworkProcess(const NetworkProcessCreationParameters& parameters)
> {
>     ASSERT(!parameters.diskCacheDirectory.isEmpty());
>     GRefPtr<SoupCache> soupCache = adoptGRef(soup_cache_new(parameters.diskCacheDirectory.utf8().data(), SOUP_CACHE_SINGLE_USER));
>-    soup_session_add_feature(WebCore::ResourceHandle::defaultSession(), SOUP_SESSION_FEATURE(soupCache.get()));
>+    soup_session_add_feature(ResourceHandle::defaultSession(), SOUP_SESSION_FEATURE(soupCache.get()));
>     soup_cache_load(soupCache.get());
> 
>     if (!parameters.cookiePersistentStoragePath.isEmpty()) {
>@@ -87,6 +134,9 @@ void NetworkProcess::platformInitializeNetworkProcess(const NetworkProcessCreati
>     }
>     supplement<WebCookieManager>()->setHTTPCookieAcceptPolicy(parameters.cookieAcceptPolicy);
> 
>+    if (!parameters.languages.isEmpty())
>+        userPreferredLanguagesChanged(parameters.languages);
>+
>     setIgnoreTLSErrors(parameters.ignoreTLSErrors);
> }
> 
>@@ -121,7 +171,7 @@ void NetworkProcess::setIgnoreTLSErrors(bool ignoreTLSErrors)
> 
> void NetworkProcess::allowSpecificHTTPSCertificateForHost(const CertificateInfo& certificateInfo, const String& host)
> {
>-    WebCore::ResourceHandle::setClientCertificate(host, certificateInfo.certificate());
>+    ResourceHandle::setClientCertificate(host, certificateInfo.certificate());
> }
> 
> void NetworkProcess::clearCacheForAllOrigins(uint32_t cachesToClear)
>@@ -129,8 +179,7 @@ void NetworkProcess::clearCacheForAllOrigins(uint32_t cachesToClear)
>     if (cachesToClear == InMemoryResourceCachesOnly)
>         return;
> 
>-    SoupSession* session = ResourceHandle::defaultSession();
>-    soup_cache_clear(SOUP_CACHE(soup_session_get_feature(session, SOUP_TYPE_CACHE)));
>+    soup_cache_clear(SOUP_CACHE(soup_session_get_feature(ResourceHandle::defaultSession(), SOUP_TYPE_CACHE)));
> }
> 
> void NetworkProcess::platformTerminate()
>diff --git a/Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.cpp b/Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.cpp
>index d1ebfc7..780fc1e 100644
>--- a/Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.cpp
>+++ b/Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.cpp
>@@ -59,6 +59,7 @@ void NetworkProcessCreationParameters::encode(CoreIPC::ArgumentEncoder& encoder)
>     encoder << cookiePersistentStorageType;
>     encoder.encodeEnum(cookieAcceptPolicy);
>     encoder << ignoreTLSErrors;
>+    encoder << languages;
> #endif
> }
> 
>@@ -102,6 +103,8 @@ bool NetworkProcessCreationParameters::decode(CoreIPC::ArgumentDecoder& decoder,
>         return false;
>     if (!decoder.decode(result.ignoreTLSErrors))
>         return false;
>+    if (!decoder.decode(result.languages))
>+        return false;
> #endif
> 
>     return true;
>diff --git a/Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.h b/Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.h
>index 6429052..edad4b4 100644
>--- a/Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.h
>+++ b/Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.h
>@@ -77,6 +77,7 @@ struct NetworkProcessCreationParameters {
>     uint32_t cookiePersistentStorageType;
>     HTTPCookieAcceptPolicy cookieAcceptPolicy;
>     bool ignoreTLSErrors;
>+    Vector<String> languages;
> #endif
> };
> 
>diff --git a/Source/WebKit2/UIProcess/WebContext.cpp b/Source/WebKit2/UIProcess/WebContext.cpp
>index 13cfab1..8eecf1a 100644
>--- a/Source/WebKit2/UIProcess/WebContext.cpp
>+++ b/Source/WebKit2/UIProcess/WebContext.cpp
>@@ -326,6 +326,10 @@ void WebContext::languageChanged(void* context)
> void WebContext::languageChanged()
> {
>     sendToAllProcesses(Messages::WebProcess::UserPreferredLanguagesChanged(userPreferredLanguages()));
>+#if USE(SOUP) && ENABLE(NETWORK_PROCESS)
>+    if (m_usesNetworkProcess && m_networkProcess)
>+        m_networkProcess->send(Messages::NetworkProcess::UserPreferredLanguagesChanged(userPreferredLanguages()), 0);
>+#endif
> }
> 
> void WebContext::fullKeyboardAccessModeChanged(bool fullKeyboardAccessEnabled)
>diff --git a/Source/WebKit2/UIProcess/soup/WebContextSoup.cpp b/Source/WebKit2/UIProcess/soup/WebContextSoup.cpp
>index 881c034..2c4855b 100644
>--- a/Source/WebKit2/UIProcess/soup/WebContextSoup.cpp
>+++ b/Source/WebKit2/UIProcess/soup/WebContextSoup.cpp
>@@ -29,6 +29,7 @@
> 
> #include "NetworkProcessCreationParameters.h"
> #include "WebCookieManagerProxy.h"
>+#include <WebCore/Language.h>
> 
> namespace WebKit {
> 
>@@ -37,6 +38,7 @@ void WebContext::platformInitializeNetworkProcess(NetworkProcessCreationParamete
>     supplement<WebCookieManagerProxy>()->getCookiePersistentStorage(parameters.cookiePersistentStoragePath, parameters.cookiePersistentStorageType);
>     parameters.cookieAcceptPolicy = m_initialHTTPCookieAcceptPolicy;
>     parameters.ignoreTLSErrors = m_ignoreTLSErrors;
>+    parameters.languages = WebCore::userPreferredLanguages();
> }
> 
> }

Flags:

andersca: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 126130: 219969 | 220072 | 220824 | 221061