Attachment 217206 Details for Bug 124481 – Patch

[patch] Patch

124481.patch (text/plain), 1.37 KB, created by Michael Saboff on 2013-11-18 10:04:34 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Saboff

Created: 2013-11-18 10:04:34 PST

Size: 1.37 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 159427)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2013-11-18  Michael Saboff  <msaboff@apple.com>
>+
>+        ARM64 CRASH: Improper offset in getHostCallReturnValue() to access callerFrame in CallFrame
>+        https://bugs.webkit.org/show_bug.cgi?id=124481
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fixed the offset to access CallerFrame in the ARM64 version of getHostCallReturnValue() to be 0
>+        to correspond with the change in CallFrame layout done in r158315.
>+
>+        * jit/JITOperations.cpp:
>+
> 2013-11-18  Michael Saboff  <msaboff@apple.com>
> 
>         Crash in virtualForThunkGenerator generated code on ARM64
>Index: Source/JavaScriptCore/jit/JITOperations.cpp
>===================================================================
>--- Source/JavaScriptCore/jit/JITOperations.cpp	(revision 159422)
>+++ Source/JavaScriptCore/jit/JITOperations.cpp	(working copy)
>@@ -1766,7 +1766,7 @@ asm (
> ".globl " SYMBOL_STRING(getHostCallReturnValue) "\n"
> HIDE_SYMBOL(getHostCallReturnValue) "\n"
> SYMBOL_STRING(getHostCallReturnValue) ":" "\n"
>-    "ldur x25, [x25, #-32]" "\n"
>+    "ldur x25, [x25, #0]" "\n"
>      "mov x0, x25" "\n"
>      "b " LOCAL_REFERENCE(getHostCallReturnValueWithExecState) "\n"
> );

Flags:

mark.lam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 124481: 217206