Attachment 215483 Details for Bug 101185 – Proposed patch

[patch] Proposed patch

101185.patch (text/plain), 6.76 KB, created by Rob Płóciennik on 2013-10-30 01:32:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Płóciennik

Created: 2013-10-30 01:32:11 PDT

Size: 6.76 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index dc953ffe..8df5fd2 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2013-10-23  Robert Plociennik  <r.plociennik@samsung.com>
>+
>+        [GTK] accessibility/svg-remote-element.html is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=101185
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Provided new test expectations since resulting discrepancies are believed to be
>+        platform related.
>+
>+        * platform/gtk-wk2/TestExpectations: The test is no longer failing.
>+        * platform/gtk/accessibility/svg-remote-element-expected.txt: Added.
>+        * platform/gtk/TestExpectations: The test is no longer failing.
>+
> 2013-10-30  Sergio Villar Senin  <svillar@igalia.com>
> 
>         Unreviewed. Removed some grid layout tests that are passing now.
>diff --git a/LayoutTests/platform/gtk-wk2/TestExpectations b/LayoutTests/platform/gtk-wk2/TestExpectations
>index 62613e5..73a0b40 100644
>--- a/LayoutTests/platform/gtk-wk2/TestExpectations
>+++ b/LayoutTests/platform/gtk-wk2/TestExpectations
>@@ -342,7 +342,6 @@ webkit.org/b/106338 accessibility/aria-hidden-updates-alldescendants.html [ Fail
> webkit.org/b/106340 accessibility/img-fallsback-to-title.html [ Failure ]
> webkit.org/b/116970 accessibility/multiselect-list-reports-active-option.html [ Failure ]
> webkit.org/b/116971 accessibility/poorly-formed-aria-table.html [ Failure ]
>-webkit.org/b/106346 accessibility/svg-remote-element.html [ Failure ]
> 
> # svg/ failures
> webkit.org/b/42457 svg/custom/embedded-svg-allowed-in-dashboard.xml [ Failure ]
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index f843670..ee35f30 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -882,7 +882,6 @@ webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ]
> webkit.org/b/98371 accessibility/loading-iframe-updates-axtree.html [ Failure ]
> webkit.org/b/98372 accessibility/onclick-handlers.html [ Failure ]
> webkit.org/b/98375 accessibility/secure-textfield-title-ui.html [ Failure ]
>-webkit.org/b/101185 accessibility/svg-remote-element.html [ Failure ]
> webkit.org/b/98377 accessibility/textarea-insertion-point-line-number.html [ Failure ]
> webkit.org/b/98378 accessibility/textarea-line-for-index.html [ Failure ]
> webkit.org/b/98379 accessibility/textarea-selected-text-range.html [ Failure ]
>diff --git a/LayoutTests/platform/gtk/accessibility/svg-remote-element-expected.txt b/LayoutTests/platform/gtk/accessibility/svg-remote-element-expected.txt
>new file mode 100644
>index 0000000..5a11f60
>--- /dev/null
>+++ b/LayoutTests/platform/gtk/accessibility/svg-remote-element-expected.txt
>@@ -0,0 +1,35 @@
>+
>+This test ensures that accessibility elements can be created out of what a remote SVG image defines.
>+
>+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>+
>+
>+container location: (7, 7)
>+Face role: AXRole: AXButton
>+Face label: AXDescription: face
>+FaceX: 0
>+FaceY: 0
>+
>+
>+Eye role: AXRole: AXButton
>+Eye label: AXDescription: left-eye
>+EyeX: 103
>+EyeY: 148
>+
>+
>+Nose role: AXRole: AXButton
>+Nose label: AXDescription: nose
>+NoseX: 193
>+NoseY: 206
>+
>+
>+Mouth role: AXRole: AXButton
>+Mouth label: AXDescription: smile
>+MouthX: 116
>+MouthY: 276
>+
>+
>+PASS successfullyParsed is true
>+
>+TEST COMPLETE
>+
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 606a254..298f29f 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,20 @@
>+2013-10-23  Robert Plociennik  <r.plociennik@samsung.com>
>+
>+        [GTK] accessibility/svg-remote-element.html is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=101185
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Implemented missing methods by mimicing existing functionality in
>+        AccessibilityObject::clickPoint() using available ATK API.
>+
>+        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
>+        (AccessibilityUIElement::clickPointX): Implemented.
>+        (AccessibilityUIElement::clickPointY): Implemented.
>+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
>+        (WTR::AccessibilityUIElement::clickPointX): Implemented.
>+        (WTR::AccessibilityUIElement::clickPointY): Implemented.
>+
> 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
> 
>         Result of focus-option-control-on-page.html depends on system preferences
>diff --git a/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp b/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
>index 6080a4c..c8767b1 100644
>--- a/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
>+++ b/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
>@@ -743,14 +743,30 @@ double AccessibilityUIElement::height()
> 
> double AccessibilityUIElement::clickPointX()
> {
>-    // Note: This is not something we have in ATK.
>-    return 0;
>+    if (!ATK_IS_COMPONENT(m_element))
>+        return 0;
>+
>+    int x, y;
>+    atk_component_get_position(ATK_COMPONENT(m_element), &x, &y, ATK_XY_WINDOW);
>+
>+    int width, height;
>+    atk_component_get_size(ATK_COMPONENT(m_element), &width, &height);
>+
>+    return x + width / 2.0;
> }
> 
> double AccessibilityUIElement::clickPointY()
> {
>-    // Note: This is not something we have in ATK.
>-    return 0;
>+    if (!ATK_IS_COMPONENT(m_element))
>+        return 0;
>+
>+    int x, y;
>+    atk_component_get_position(ATK_COMPONENT(m_element), &x, &y, ATK_XY_WINDOW);
>+
>+    int width, height;
>+    atk_component_get_size(ATK_COMPONENT(m_element), &width, &height);
>+
>+    return y + height / 2.0;
> }
> 
> JSStringRef AccessibilityUIElement::orientation() const
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp b/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
>index 2605f02..66ff505 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
>+++ b/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
>@@ -868,14 +868,30 @@ double AccessibilityUIElement::height()
> 
> double AccessibilityUIElement::clickPointX()
> {
>-    // FIXME: implement
>-    return 0;
>+    if (!ATK_IS_COMPONENT(m_element.get()))
>+        return 0;
>+
>+    int x, y;
>+    atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, &y, ATK_XY_WINDOW);
>+
>+    int width, height;
>+    atk_component_get_size(ATK_COMPONENT(m_element.get()), &width, &height);
>+
>+    return x + width / 2.0;
> }
> 
> double AccessibilityUIElement::clickPointY()
> {
>-    // FIXME: implement
>-    return 0;
>+    if (!ATK_IS_COMPONENT(m_element.get()))
>+        return 0;
>+
>+    int x, y;
>+    atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, &y, ATK_XY_WINDOW);
>+
>+    int width, height;
>+    atk_component_get_size(ATK_COMPONENT(m_element.get()), &width, &height);
>+
>+    return y + height / 2.0;
> }
> 
> double AccessibilityUIElement::intValue() const

Actions: View | Formatted Diff | Diff

Attachments on bug 101185: 215039 | 215055 | 215483