Attachment 215479 Details for Bug 112016 – Proposed patch

[patch] Proposed patch

112016.patch (text/plain), 5.78 KB, created by Rob Płóciennik on 2013-10-30 01:23:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Płóciennik

Created: 2013-10-30 01:23:08 PDT

Size: 5.78 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 7e0c37e..f05d9eb 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2013-10-28  Robert Plociennik  <r.plociennik@samsung.com>
>+
>+        [EFL] accessibility/textarea-selected-text-range.html is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=112016
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/efl-wk1/TestExpectations: The test is no longer failing.
>+        * platform/efl-wk2/TestExpectations: The test is no longer failing.
>+
> 2013-10-29  Santosh Mahto  <santosh.ma@samsung.com>
> 
>         Text selected with double-click gets unselected after DOM modification
>diff --git a/LayoutTests/platform/efl-wk1/TestExpectations b/LayoutTests/platform/efl-wk1/TestExpectations
>index ee48dd1..a153ea0 100644
>--- a/LayoutTests/platform/efl-wk1/TestExpectations
>+++ b/LayoutTests/platform/efl-wk1/TestExpectations
>@@ -165,7 +165,6 @@ webkit.org/b/112012 accessibility/svg-bounds.html [ Failure ]
> webkit.org/b/112013 accessibility/svg-remote-element.html [ Failure ]
> webkit.org/b/112014 accessibility/textarea-insertion-point-line-number.html [ Failure ]
> webkit.org/b/112015 accessibility/textarea-line-for-index.html [ Failure ]
>-webkit.org/b/112016 accessibility/textarea-selected-text-range.html [ Failure ]
> webkit.org/b/112017 accessibility/textbox-role-reports-selection.html [ Failure ]
> webkit.org/b/112018 accessibility/th-as-title-ui.html [ Failure ]
> webkit.org/b/112019 accessibility/title-ui-element-correctness.html [ Failure ]
>diff --git a/LayoutTests/platform/efl-wk2/TestExpectations b/LayoutTests/platform/efl-wk2/TestExpectations
>index 1505ddc..7d3c663 100644
>--- a/LayoutTests/platform/efl-wk2/TestExpectations
>+++ b/LayoutTests/platform/efl-wk2/TestExpectations
>@@ -165,7 +165,6 @@ webkit.org/b/112012 accessibility/svg-bounds.html [ Failure ]
> webkit.org/b/112013 accessibility/svg-remote-element.html [ Failure ]
> webkit.org/b/112014 accessibility/textarea-insertion-point-line-number.html [ Failure ]
> webkit.org/b/112015 accessibility/textarea-line-for-index.html [ Failure ]
>-webkit.org/b/112016 accessibility/textarea-selected-text-range.html [ Failure ]
> webkit.org/b/112017 accessibility/textbox-role-reports-selection.html [ Failure ]
> webkit.org/b/112018 accessibility/th-as-title-ui.html [ Failure ]
> webkit.org/b/112019 accessibility/title-ui-element-correctness.html [ Failure ]
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 10cb9d2..2a359ef 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,20 @@
>+2013-10-28  Robert Plociennik  <r.plociennik@samsung.com>
>+
>+        [EFL] accessibility/textarea-selected-text-range.html is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=112016
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Provided implementation for AccessibilityUIElement::selectedTextRange() and
>+        AccessibilityUIElement::setSelectedTextRange().
>+
>+        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
>+        (AccessibilityUIElement::selectedTextRange): Implemented.
>+        (AccessibilityUIElement::setSelectedTextRange): Implemented
>+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
>+        (WTR::AccessibilityUIElement::selectedTextRange): Implemented.
>+        (WTR::AccessibilityUIElement::setSelectedTextRange): Implemented.
>+
> 2013-10-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
> 
>         EFL 32 bit buildbot doesn't work on dashboard
>diff --git a/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp b/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
>index 6080a4c..a36ab1b 100644
>--- a/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
>+++ b/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
>@@ -1019,13 +1019,23 @@ AccessibilityUIElement AccessibilityUIElement::cellForColumnAndRow(unsigned colu
> 
> JSStringRef AccessibilityUIElement::selectedTextRange()
> {
>-    // FIXME: implement
>-    return JSStringCreateWithCharacters(0, 0);
>+    if (!ATK_IS_TEXT(m_element))
>+        return JSStringCreateWithCharacters(0, 0);
>+
>+    gint start, end;
>+    g_free(atk_text_get_selection(ATK_TEXT(m_element), 0, &start, &end));
>+
>+    GOwnPtr<gchar> selection(g_strdup_printf("{%d, %d}", start, end - start));
>+
>+    return JSStringCreateWithUTF8CString(selection.get());
> }
> 
> void AccessibilityUIElement::setSelectedTextRange(unsigned location, unsigned length)
> {
>-    // FIXME: implement
>+    if (!ATK_IS_TEXT(m_element))
>+        return;
>+
>+    atk_text_set_selection(ATK_TEXT(m_element), 0, location, location + length);
> }
> 
> JSStringRef AccessibilityUIElement::stringAttributeValue(JSStringRef attribute)
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp b/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
>index 2605f02..55147bd 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
>+++ b/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
>@@ -1159,13 +1159,23 @@ PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::verticalScrollbar() c
> 
> JSRetainPtr<JSStringRef> AccessibilityUIElement::selectedTextRange()
> {
>-    // FIXME: implement
>-    return JSStringCreateWithCharacters(0, 0);
>+    if (!ATK_IS_TEXT(m_element.get()))
>+        return JSStringCreateWithCharacters(0, 0);
>+
>+    gint start, end;
>+    g_free(atk_text_get_selection(ATK_TEXT(m_element.get()), 0, &start, &end));
>+
>+    GOwnPtr<gchar> selection(g_strdup_printf("{%d, %d}", start, end - start));
>+
>+    return JSStringCreateWithUTF8CString(selection.get());
> }
> 
> void AccessibilityUIElement::setSelectedTextRange(unsigned location, unsigned length)
> {
>-    // FIXME: implement
>+    if (!ATK_IS_TEXT(m_element.get()))
>+        return;
>+
>+    atk_text_set_selection(ATK_TEXT(m_element.get()), 0, location, location + length);
> }
> 
> void AccessibilityUIElement::increment()

Actions: View | Formatted Diff | Diff

Attachments on bug 112016: 215479 | 215481 | 215503