Attachment 213348 Details for Bug 122269 – A better patch for landing.

[patch] A better patch for landing.

bug-122269-20131004030441.patch (text/plain), 7.82 KB, created by Zan Dobersek on 2013-10-04 03:04:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2013-10-04 03:04:42 PDT

Size: 7.82 KB

patch

obsolete

>Subversion Revision: 156880
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1cfdf875b0fe647f29c52daf570806b92fa47e9a..c2733c57131547413170d176ad673092eea8121f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,31 @@
>+2013-10-04  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
>+        https://bugs.webkit.org/show_bug.cgi?id=122269
>+
>+        Reviewed by Darin Adler.
>+
>+        Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
>+        interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
>+        doesn't have any effect, but will keep the operations not configurable after the generator is modified
>+        to preserve the original behavior. The attribute will be removed from each interface after checking
>+        conformity with other browsers (in terms of configurability of operations of that interface) and the
>+        WebKit's existing test suites.
>+
>+        This patch covers IDL interfaces under Source/WebCore/xml/.
>+
>+        * xml/DOMParser.idl:
>+        * xml/XMLHttpRequest.idl:
>+        * xml/XMLHttpRequestException.idl:
>+        * xml/XMLHttpRequestUpload.idl:
>+        * xml/XMLSerializer.idl:
>+        * xml/XPathEvaluator.idl:
>+        * xml/XPathException.idl:
>+        * xml/XPathExpression.idl:
>+        * xml/XPathNSResolver.idl:
>+        * xml/XPathResult.idl:
>+        * xml/XSLTProcessor.idl:
>+
> 2013-10-03  Anders Carlsson  <andersca@apple.com>
> 
>         Assert that we don't try to index past the end of the m_coreTextIndices array
>diff --git a/Source/WebCore/xml/DOMParser.idl b/Source/WebCore/xml/DOMParser.idl
>index 4e8ed09d6be6c940de31e8d0cd0a744257276f53..4f6a644d54c7a175b8c80c3a99f9945b3d5f1fd9 100644
>--- a/Source/WebCore/xml/DOMParser.idl
>+++ b/Source/WebCore/xml/DOMParser.idl
>@@ -19,7 +19,8 @@
> 
> [
>     Constructor,
>-    ImplementationLacksVTable
>+    ImplementationLacksVTable,
>+    OperationsNotDeletable
> ] interface DOMParser {
>     [RaisesException] Document parseFromString([Default=Undefined] optional DOMString str,
>                              [Default=Undefined] optional DOMString contentType);
>diff --git a/Source/WebCore/xml/XMLHttpRequest.idl b/Source/WebCore/xml/XMLHttpRequest.idl
>index f0704feb78f402d9cee61d96fe4655599cfdec7c..205dbb650214d7c94d48242ed8ada1da3dce3ae4 100644
>--- a/Source/WebCore/xml/XMLHttpRequest.idl
>+++ b/Source/WebCore/xml/XMLHttpRequest.idl
>@@ -42,7 +42,8 @@ enum XMLHttpRequestResponseType {
>     ConstructorCallWith=ScriptExecutionContext,
>     JSCustomMarkFunction,
>     EventTarget,
>-    JSNoStaticTables
>+    JSNoStaticTables,
>+    OperationsNotDeletable
> ] interface XMLHttpRequest {
>     // From XMLHttpRequestEventTarget
>     // event handler attributes
>diff --git a/Source/WebCore/xml/XMLHttpRequestException.idl b/Source/WebCore/xml/XMLHttpRequestException.idl
>index 540f2825b8da541740d56341fd9d31c3f2284eb0..3993b46532d849351cbdff002832864b26b0c36e 100644
>--- a/Source/WebCore/xml/XMLHttpRequestException.idl
>+++ b/Source/WebCore/xml/XMLHttpRequestException.idl
>@@ -29,7 +29,8 @@
> [
>     JSNoStaticTables,
>     DoNotCheckConstants,
>-    ImplementationLacksVTable
>+    ImplementationLacksVTable,
>+    OperationsNotDeletable
> ] exception XMLHttpRequestException {
> 
>     readonly attribute unsigned short   code;
>diff --git a/Source/WebCore/xml/XMLHttpRequestUpload.idl b/Source/WebCore/xml/XMLHttpRequestUpload.idl
>index 844992724d3369616b19babc22edeb3051b65228..5a8ae3fad7f9b0d9c8c046a49c8324d0d9d4355d 100644
>--- a/Source/WebCore/xml/XMLHttpRequestUpload.idl
>+++ b/Source/WebCore/xml/XMLHttpRequestUpload.idl
>@@ -29,7 +29,8 @@
> [
>     GenerateIsReachable=Impl,
>     EventTarget,
>-    JSNoStaticTables
>+    JSNoStaticTables,
>+    OperationsNotDeletable
> ] interface XMLHttpRequestUpload {
>     // From XMLHttpRequestEventTarget
>     // event handler attributes
>diff --git a/Source/WebCore/xml/XMLSerializer.idl b/Source/WebCore/xml/XMLSerializer.idl
>index 5e174e17226a240d189067fc016b46846df8b007..d1705ac56222f0d72574fa8ed91d008f808f2d3a 100644
>--- a/Source/WebCore/xml/XMLSerializer.idl
>+++ b/Source/WebCore/xml/XMLSerializer.idl
>@@ -20,7 +20,8 @@
> 
> [
>     Constructor,
>-    ImplementationLacksVTable
>+    ImplementationLacksVTable,
>+    OperationsNotDeletable
> ] interface XMLSerializer {
>     [RaisesException] DOMString serializeToString([Default=Undefined] optional Node node);
> };
>diff --git a/Source/WebCore/xml/XPathEvaluator.idl b/Source/WebCore/xml/XPathEvaluator.idl
>index 457663f739fbecffe17cd549443c00a1ce14933a..5a0e7e5c92b0ef14f517c53630632ca9a9760b83 100644
>--- a/Source/WebCore/xml/XPathEvaluator.idl
>+++ b/Source/WebCore/xml/XPathEvaluator.idl
>@@ -19,7 +19,8 @@
> 
> [
>     Constructor,
>-    ImplementationLacksVTable
>+    ImplementationLacksVTable,
>+    OperationsNotDeletable
> ] interface XPathEvaluator {
>     [RaisesException] XPathExpression createExpression([Default=Undefined] optional DOMString expression,
>                                      [Default=Undefined] optional XPathNSResolver resolver);
>diff --git a/Source/WebCore/xml/XPathException.idl b/Source/WebCore/xml/XPathException.idl
>index 55879f63efff220dda604c8cc547936ccffd70bf..6839871d9e5f34a929f43c8112d57b948d7f0cb3 100644
>--- a/Source/WebCore/xml/XPathException.idl
>+++ b/Source/WebCore/xml/XPathException.idl
>@@ -28,7 +28,8 @@
> 
> [
>     DoNotCheckConstants,
>-    ImplementationLacksVTable
>+    ImplementationLacksVTable,
>+    OperationsNotDeletable
> ] exception XPathException {
> 
>     readonly attribute unsigned short   code;
>diff --git a/Source/WebCore/xml/XPathExpression.idl b/Source/WebCore/xml/XPathExpression.idl
>index 659b9fa4f689841ff024a1b5a1c22ee2b24f4f78..e4b202891af6cb84766b0022154885a41fde13b3 100644
>--- a/Source/WebCore/xml/XPathExpression.idl
>+++ b/Source/WebCore/xml/XPathExpression.idl
>@@ -18,7 +18,8 @@
>  * Boston, MA 02110-1301, USA.
>  */
> [
>-    ImplementationLacksVTable
>+    ImplementationLacksVTable,
>+    OperationsNotDeletable
> ] interface XPathExpression {
>     [ObjCLegacyUnnamedParameters, RaisesException] XPathResult evaluate([Default=Undefined] optional Node contextNode, 
>                                         [Default=Undefined] optional unsigned short type, 
>diff --git a/Source/WebCore/xml/XPathNSResolver.idl b/Source/WebCore/xml/XPathNSResolver.idl
>index 20da40d2a2d87e9d4179bb9d06641faa1bbe923e..806d0430d6c448792bc3bca20a3243aa884edb59 100644
>--- a/Source/WebCore/xml/XPathNSResolver.idl
>+++ b/Source/WebCore/xml/XPathNSResolver.idl
>@@ -21,7 +21,8 @@
> [
>     NoInterfaceObject,
>     ObjCProtocol,
>-    SkipVTableValidation
>+    SkipVTableValidation,
>+    OperationsNotDeletable
> ] interface XPathNSResolver {
>     [TreatReturnedNullStringAs=Null] DOMString lookupNamespaceURI([Default=Undefined] optional DOMString prefix);
> };
>diff --git a/Source/WebCore/xml/XPathResult.idl b/Source/WebCore/xml/XPathResult.idl
>index 9a047ad1fd19cab252b6e07e2405ff2c7901674b..c1f39f83e574019a44aeb057922e60b645ea79c6 100644
>--- a/Source/WebCore/xml/XPathResult.idl
>+++ b/Source/WebCore/xml/XPathResult.idl
>@@ -19,7 +19,8 @@
> 
> [
>     JSCustomMarkFunction,
>-    ImplementationLacksVTable
>+    ImplementationLacksVTable,
>+    OperationsNotDeletable
> ] interface XPathResult {
>     const unsigned short ANY_TYPE                       = 0;
>     const unsigned short NUMBER_TYPE                    = 1;
>diff --git a/Source/WebCore/xml/XSLTProcessor.idl b/Source/WebCore/xml/XSLTProcessor.idl
>index 57580348e55642223afdcd59cb5cf2505a832ef0..e74452a7a62a773fc446503534887ace37dd7024 100644
>--- a/Source/WebCore/xml/XSLTProcessor.idl
>+++ b/Source/WebCore/xml/XSLTProcessor.idl
>@@ -33,7 +33,8 @@
> [
>     Conditional=XSLT,
>     Constructor,
>-    ImplementationLacksVTable
>+    ImplementationLacksVTable,
>+    OperationsNotDeletable
> ] interface XSLTProcessor {
>     
>     void importStylesheet([Default=Undefined] optional Node stylesheet);

Actions: View | Formatted Diff | Diff

Attachments on bug 122269: 213252 | 213347 | 213348