Attachment 213258 Details for Bug 122275 – Patch

[patch] Patch

bug-122275-20131003085757.patch (text/plain), 4.97 KB, created by Zan Dobersek on 2013-10-03 08:57:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2013-10-03 08:57:58 PDT

Size: 4.97 KB

patch

obsolete

>Subversion Revision: 156835
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 74e1ca1ba257f2fea78377ea9e558f8328c61661..9dbc401a606bac0bb1886841c918d9be70052f00 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,24 @@
>+2013-10-03  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
>+        https://bugs.webkit.org/show_bug.cgi?id=122275
>+
>+        Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
>+        interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
>+        doesn't have any effect, but will keep the operations not configurable after the generator is modified
>+        to preserve the original behavior. The attribute will be removed from each interface after checking
>+        conformity with other browsers (in terms of configurability of operations of that interface) and the
>+        WebKit's existing test suites.
>+
>+        This patch covers IDL interfaces under Source/WebCore/fileapi/.
>+
>+        * fileapi/Blob.idl:
>+        * fileapi/File.idl:
>+        * fileapi/FileError.idl:
>+        * fileapi/FileList.idl:
>+        * fileapi/FileReader.idl:
>+        * fileapi/FileReaderSync.idl:
>+
> 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
> 
>         [ATK] Expose aria-invalid as a text attribute (not object attribute)
>diff --git a/Source/WebCore/fileapi/Blob.idl b/Source/WebCore/fileapi/Blob.idl
>index 17cd5e2ba7dbcc5fd9cc977fc557df1113740f77..6a4ea89b6388fb55261a429358a4c18294fa08e8 100644
>--- a/Source/WebCore/fileapi/Blob.idl
>+++ b/Source/WebCore/fileapi/Blob.idl
>@@ -34,7 +34,8 @@
>     CustomToJSObject,
>     JSNoStaticTables,
>     CustomConstructor,
>-    CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options)
>+    CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options),
>+    OperationsNotDeletable
> ] interface Blob {
>     readonly attribute unsigned long long size;
>     readonly attribute DOMString type;
>diff --git a/Source/WebCore/fileapi/File.idl b/Source/WebCore/fileapi/File.idl
>index 1d9dc51fc6be6694bed0b71b2163a3306f4fb25b..a2b536fd02bfbcbda1aefdcb7cb6e25f965380ef 100644
>--- a/Source/WebCore/fileapi/File.idl
>+++ b/Source/WebCore/fileapi/File.idl
>@@ -26,7 +26,8 @@
> [
>     JSGenerateToNativeObject,
>     JSGenerateToJSObject,
>-    JSNoStaticTables
>+    JSNoStaticTables,
>+    OperationsNotDeletable
> ] interface File : Blob {
>     readonly attribute DOMString name;
> #if !defined(LANGUAGE_GOBJECT) || !LANGUAGE_GOBJECT
>diff --git a/Source/WebCore/fileapi/FileError.idl b/Source/WebCore/fileapi/FileError.idl
>index 866ce92745a9b7ff5f68765e2bf23e96611c7336..69a4f2bc0ea273a530dbf69c3666b38a9c97e8d5 100644
>--- a/Source/WebCore/fileapi/FileError.idl
>+++ b/Source/WebCore/fileapi/FileError.idl
>@@ -31,7 +31,8 @@
> [
>     Conditional=BLOB,
>     JSNoStaticTables,
>-    ImplementationLacksVTable
>+    ImplementationLacksVTable,
>+    OperationsNotDeletable
> ] interface FileError {
> #if !defined(LANGUAGE_OBJECTIVE_C)
>     // FIXME: Some of constant names are already defined in DOMException.h for Objective-C binding and we cannot have the same names here (they are translated into a enum in the same namespace).
>diff --git a/Source/WebCore/fileapi/FileList.idl b/Source/WebCore/fileapi/FileList.idl
>index f0d4ce482a31521c5663e20ae83ad4d8680908ec..413a7a88df746409b8f293c1dd879ff7b0ac96ff 100644
>--- a/Source/WebCore/fileapi/FileList.idl
>+++ b/Source/WebCore/fileapi/FileList.idl
>@@ -25,7 +25,8 @@
> 
> [
>     JSNoStaticTables,
>-    ImplementationLacksVTable
>+    ImplementationLacksVTable,
>+    OperationsNotDeletable
> ] interface FileList {
>     readonly attribute unsigned long length;
>     getter File item(unsigned long index);
>diff --git a/Source/WebCore/fileapi/FileReader.idl b/Source/WebCore/fileapi/FileReader.idl
>index 0d5af4f27bffedcf431234eaf587be0f08b7de67..8e48e22ac3f630a116db12b1809c7b464499b9da 100644
>--- a/Source/WebCore/fileapi/FileReader.idl
>+++ b/Source/WebCore/fileapi/FileReader.idl
>@@ -36,7 +36,8 @@
>     Constructor,
>     ConstructorCallWith=ScriptExecutionContext,
>     EventTarget,
>-    JSNoStaticTables
>+    JSNoStaticTables,
>+    OperationsNotDeletable
> ] interface FileReader {
>     // ready states
>     const unsigned short EMPTY = 0;
>diff --git a/Source/WebCore/fileapi/FileReaderSync.idl b/Source/WebCore/fileapi/FileReaderSync.idl
>index 8ef0f6a56d3c311f607b2ecfe6b2c184725e9e17..5be22e13b1113c82f64d9f03e5966c54e2bcb581 100644
>--- a/Source/WebCore/fileapi/FileReaderSync.idl
>+++ b/Source/WebCore/fileapi/FileReaderSync.idl
>@@ -32,7 +32,8 @@
>     GlobalContext=WorkerGlobalScope,
>     Conditional=BLOB,
>     Constructor,
>-    JSNoStaticTables
>+    JSNoStaticTables,
>+    OperationsNotDeletable
> ] interface FileReaderSync {
>     [CallWith=ScriptExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);
>     [CallWith=ScriptExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);

Actions: View | Formatted Diff | Diff

Attachments on bug 122275: 213258 | 213350