Attachment 210988 Details for Bug 121011 – the patch

[patch] the patch

blah.patch (text/plain), 1.67 KB, created by Filip Pizlo on 2013-09-08 13:17:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2013-09-08 13:17:17 PDT

Size: 1.67 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 155310)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2013-09-08  Filip Pizlo  <fpizlo@apple.com>
>+
>+        run-jsc-stress-tests should be more paranoid about calling make
>+        https://bugs.webkit.org/show_bug.cgi?id=121011
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        If it returns with any kind of error then bail out.  Also print the command being used
>+        in case we have to debug this, for example on the bots.  The extra verbosity isn't a
>+        big deal.
>+
>+        * Scripts/run-jsc-stress-tests:
>+
> 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
> 
>         Unreviewed, never pass Pathname to shellescape() as old versions of Ruby don't
>Index: Tools/Scripts/run-jsc-stress-tests
>===================================================================
>--- Tools/Scripts/run-jsc-stress-tests	(revision 155310)
>+++ Tools/Scripts/run-jsc-stress-tests	(working copy)
>@@ -36,6 +36,16 @@ rescue => e
>     $stderr.puts "Error: #{e.inspect}"
> end
> 
>+def mysys(*cmd)
>+    begin
>+        commandArray = cmd.each{|value| Shellwords.shellescape(value.to_s)}.join(' ')
>+    rescue
>+        commandArray = cmd.join(' ')
>+    end
>+    $stderr.puts ">> #{commandArray}"
>+    raise "Command failed: #{$?.inspect}" unless system(*cmd)
>+end
>+
> numProcessors = `sysctl -n hw.availcpu`.to_i
> 
> $jscPath = nil
>@@ -319,7 +329,7 @@ if $parallel
>     }
>     
>     Dir.chdir(parallelDir) {
>-        system("make", "-j", numProcessors.to_s, "-s", "-f", "Makefile")
>+        mysys("make", "-j", numProcessors.to_s, "-s", "-f", "Makefile")
>     }
>     
>     Dir.foreach(parallelDir) {

Flags:

oliver: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 121011: 210987 | 210988