Attachment 207414 Details for Bug 119066 – Patch

[patch] Patch

bug-119066-20130724145700.patch (text/plain), 1.88 KB, created by Daniel Bates on 2013-07-24 14:57:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2013-07-24 14:57:00 PDT

Size: 1.88 KB

patch

obsolete

>Subversion Revision: 153102
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 20f7e160a7e836336ef27047a47a690ebed83c40..563d6ebcd4dc5b922e4c7c65dcd2aea68ef4baa0 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2013-07-24  Simon Fraser  <simon.fraser@apple.com>
>+
>+        REGRESSION (r152335): Mac Pro title occluded in MobileSafari; can't scroll page
>+        https://bugs.webkit.org/show_bug.cgi?id=119066
>+        <rdar://problem/14499184>
>+
>+        Reviewed by Daniel Bates.
>+
>+        Following <http://trac.webkit.org/changeset/152335> (bug #118337) we set
>+        the z-index to 0 on every element with CSS "overflow: scroll" and
>+        "-webkit-overflow-scrolling: touch" regardless of whether the element has
>+        non-auto z-index. Instead we should only set the z-index to 0 for such elements
>+        that have an auto z-index.
>+
>+        * css/StyleResolver.cpp:
>+        (WebCore::StyleResolver::adjustRenderStyle):
>+
> 2013-07-24  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Use-after-free in ApplyStyleCommand::removeInlineStyle
>diff --git a/Source/WebCore/css/StyleResolver.cpp b/Source/WebCore/css/StyleResolver.cpp
>index 26352e6a7ed89c7a2124470f0cb70e96c07aa162..2a09d30baddbc0d83aca102d29b6277088e54324 100644
>--- a/Source/WebCore/css/StyleResolver.cpp
>+++ b/Source/WebCore/css/StyleResolver.cpp
>@@ -1492,7 +1492,7 @@ void StyleResolver::adjustRenderStyle(RenderStyle* style, RenderStyle* parentSty
> 
> #if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
>     // Touch overflow scrolling creates a stacking context.
>-    if (style->useTouchOverflowScrolling() && (isScrollableOverflow(style->overflowX()) || isScrollableOverflow(style->overflowY())))
>+    if (style->hasAutoZIndex() && style->useTouchOverflowScrolling() && (isScrollableOverflow(style->overflowX()) || isScrollableOverflow(style->overflowY())))
>         style->setZIndex(0);
> #endif
>

Actions: View | Formatted Diff | Diff

Attachments on bug 119066: 207414