Attachment 207217 Details for Bug 118957 – the patch

[patch] the patch

blah.patch (text/plain), 2.40 KB, created by Filip Pizlo on 2013-07-21 16:10:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2013-07-21 16:10:37 PDT

Size: 2.40 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 152953)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2013-07-21  Filip Pizlo  <fpizlo@apple.com>
>+
>+        fourthTier: It should be easy to figure out which blocks nodes belong to
>+        https://bugs.webkit.org/show_bug.cgi?id=118957
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * dfg/DFGGraph.cpp:
>+        (DFG):
>+        (JSC::DFG::Graph::initializeNodeOwners):
>+        * dfg/DFGGraph.h:
>+        (Graph):
>+        * dfg/DFGNode.h:
>+
> 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
> 
>         fourthTier: each DFG node that relies on other nodes to do their type checks should be able to tell you if those type checks happened
>Index: Source/JavaScriptCore/dfg/DFGGraph.cpp
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGGraph.cpp	(revision 152953)
>+++ Source/JavaScriptCore/dfg/DFGGraph.cpp	(working copy)
>@@ -546,6 +546,19 @@ void Graph::clearReplacements()
>             block->at(nodeIndex)->misc.replacement = 0;
>     }
> }
>+
>+void Graph::initializeNodeOwners()
>+{
>+    for (BlockIndex blockIndex = numBlocks(); blockIndex--;) {
>+        BasicBlock* block = m_blocks[blockIndex].get();
>+        if (!block)
>+            continue;
>+        for (unsigned phiIndex = block->phis.size(); phiIndex--;)
>+            block->phis[phiIndex]->misc.owner = block;
>+        for (unsigned nodeIndex = block->size(); nodeIndex--;)
>+            block->at(nodeIndex)->misc.owner = block;
>+    }
>+}
>     
> } } // namespace JSC::DFG
> 
>Index: Source/JavaScriptCore/dfg/DFGGraph.h
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGGraph.h	(revision 152953)
>+++ Source/JavaScriptCore/dfg/DFGGraph.h	(working copy)
>@@ -647,6 +647,7 @@ public:
>     void invalidateCFG();
>     
>     void clearReplacements();
>+    void initializeNodeOwners();
>     
>     void getBlocksInDepthFirstOrder(Vector<BasicBlock*>& result);
>     
>Index: Source/JavaScriptCore/dfg/DFGNode.h
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGNode.h	(revision 152953)
>+++ Source/JavaScriptCore/dfg/DFGNode.h	(working copy)
>@@ -1400,6 +1400,7 @@ public:
>     AbstractValue value;
>     union {
>         Node* replacement;
>+        BasicBlock* owner;
>     } misc;
> };
>

Actions: View | Formatted Diff | Diff

Attachments on bug 118957: 207217 | 207222