Attachment 206954 Details for Bug 118588 – Patch

[patch] Patch

bug-118588-20130718153433.patch (text/plain), 1.80 KB, created by Eunmi Lee on 2013-07-17 23:34:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eunmi Lee

Created: 2013-07-17 23:34:33 PDT

Size: 1.80 KB

patch

obsolete

>Subversion Revision: 152706
>diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
>index 7a025c8bc00959f0fd6d126d979132d4059b7b95..408f0d8b95c30515553f165f7da8a0655698919b 100644
>--- a/Source/WebKit2/ChangeLog
>+++ b/Source/WebKit2/ChangeLog
>@@ -1,3 +1,17 @@
>+2013-07-17  Eunmi Lee  <eunmi15.lee@samsung.com>
>+
>+        [WK2] Replace getRect() to pixelSnappedBoundingBox().
>+        https://bugs.webkit.org/show_bug.cgi?id=118588
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The Node's getRect() function was removed in the
>+        http://trac.webkit.org/changeset/128006, so use
>+        pixelSnappedBoundingBox() instead.
>+
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::findZoomableAreaForPoint):
>+
> 2013-07-15  Kangil Han  <kangil.han@samsung.com>
> 
>         Introduce toHTMLIFrameElement
>diff --git a/Source/WebKit2/WebProcess/WebPage/WebPage.cpp b/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
>index ae2d25dfc02a7a84a869bd76de9eef90a36d24bf..0fa103951b5d81bf872a8de7187003ede3b9141b 100644
>--- a/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
>+++ b/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
>@@ -3226,7 +3226,7 @@ void WebPage::findZoomableAreaForPoint(const WebCore::IntPoint& point, const Web
>     if (!node)
>         return;
> 
>-    IntRect zoomableArea = node->getRect();
>+    IntRect zoomableArea = node->pixelSnappedBoundingBox();
> 
>     while (true) {
>         bool found = !node->isTextNode() && !node->isShadowRoot();
>@@ -3242,7 +3242,7 @@ void WebPage::findZoomableAreaForPoint(const WebCore::IntPoint& point, const Web
>             break;
> 
>         node = node->parentNode();
>-        zoomableArea.unite(node->getRect());
>+        zoomableArea.unite(node->pixelSnappedBoundingBox());
>     }
> 
>     if (node->document() && node->document()->frame() && node->document()->frame()->view()) {

Actions: View | Formatted Diff | Diff

Attachments on bug 118588: 206512 | 206726 | 206954 | 206955