Attachment 205968 Details for Bug 118340 – the patch

[patch] the patch

blah.patch (text/plain), 2.70 KB, created by Filip Pizlo on 2013-07-02 22:00:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2013-07-02 22:00:29 PDT

Size: 2.70 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 152336)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2013-07-02  Filip Pizlo  <fpizlo@apple.com>
>+
>+        fourthTier: DFG::Node::m_opInfo2 should also be a uintptr_t
>+        https://bugs.webkit.org/show_bug.cgi?id=118340
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * dfg/DFGNode.h:
>+        (JSC::DFG::Node::Node):
>+
> 2013-07-02  Filip Pizlo  <fpizlo@apple.com>
> 
>         fourthTier: Have fewer Arrayify's
>Index: Source/JavaScriptCore/dfg/DFGNode.h
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGNode.h	(revision 152336)
>+++ Source/JavaScriptCore/dfg/DFGNode.h	(working copy)
>@@ -168,8 +168,8 @@ struct Node {
>         , children(AdjacencyList::Fixed, child1, child2, child3)
>         , m_virtualRegister(InvalidVirtualRegister)
>         , m_refCount(1)
>-        , m_opInfo(imm.m_value)
>         , m_prediction(SpecNone)
>+        , m_opInfo(imm.m_value)
>     {
>         setOpAndDefaultFlags(op);
>         ASSERT(!(m_flags & NodeHasVarArgs));
>@@ -181,9 +181,9 @@ struct Node {
>         , children(AdjacencyList::Fixed, child1, child2, child3)
>         , m_virtualRegister(InvalidVirtualRegister)
>         , m_refCount(1)
>-        , m_opInfo(imm1.m_value)
>-        , m_opInfo2(safeCast<unsigned>(imm2.m_value))
>         , m_prediction(SpecNone)
>+        , m_opInfo(imm1.m_value)
>+        , m_opInfo2(imm2.m_value)
>     {
>         setOpAndDefaultFlags(op);
>         ASSERT(!(m_flags & NodeHasVarArgs));
>@@ -195,9 +195,9 @@ struct Node {
>         , children(AdjacencyList::Variable, firstChild, numChildren)
>         , m_virtualRegister(InvalidVirtualRegister)
>         , m_refCount(1)
>-        , m_opInfo(imm1.m_value)
>-        , m_opInfo2(safeCast<unsigned>(imm2.m_value))
>         , m_prediction(SpecNone)
>+        , m_opInfo(imm1.m_value)
>+        , m_opInfo2(imm2.m_value)
>     {
>         setOpAndDefaultFlags(op);
>         ASSERT(m_flags & NodeHasVarArgs);
>@@ -1370,12 +1370,12 @@ private:
>     VirtualRegister m_virtualRegister;
>     // The number of uses of the result of this operation (+1 for 'must generate' nodes, which have side-effects).
>     unsigned m_refCount;
>+    // The prediction ascribed to this node after propagation.
>+    SpeculatedType m_prediction;
>     // Immediate values, accesses type-checked via accessors above. The first one is
>     // big enough to store a pointer.
>     uintptr_t m_opInfo;
>-    unsigned m_opInfo2;
>-    // The prediction ascribed to this node after propagation.
>-    SpeculatedType m_prediction;
>+    uintptr_t m_opInfo2;
> 
> public:
>     // Fields used by various analyses.

Flags:

sam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 118340: 205968