Attachment 205860 Details for Bug 118276 – the patch

[patch] the patch

blah.patch (text/plain), 1.55 KB, created by Filip Pizlo on 2013-07-01 21:01:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2013-07-01 21:01:30 PDT

Size: 1.55 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 152277)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2013-07-01  Filip Pizlo  <fpizlo@apple.com>
>+
>+        fourthTier: FTL should run AA passes before GVN
>+        https://bugs.webkit.org/show_bug.cgi?id=118276
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        These enable load elimination in GVN.
>+
>+        * ftl/FTLCompile.cpp:
>+        (JSC::FTL::compile):
>+
> 2013-06-27  Filip Pizlo  <fpizlo@apple.com>
> 
>         Make Graph::substituteGetLocal() out-of-line
>Index: Source/JavaScriptCore/ftl/FTLCompile.cpp
>===================================================================
>--- Source/JavaScriptCore/ftl/FTLCompile.cpp	(revision 152277)
>+++ Source/JavaScriptCore/ftl/FTLCompile.cpp	(working copy)
>@@ -99,7 +99,7 @@ void compile(State& state)
>         dataLog("FATAL: Could not create LLVM execution engine: ", error, "\n");
>         CRASH();
>     }
>-    
>+
>     LLVMPassManagerRef pass = LLVMCreatePassManager();
>     LLVMAddTargetData(LLVMGetExecutionEngineTargetData(engine), pass);
>     LLVMAddConstantPropagationPass(pass);
>@@ -107,6 +107,8 @@ void compile(State& state)
>     LLVMAddPromoteMemoryToRegisterPass(pass);
>     if (Options::enableLLVMLICM())
>         LLVMAddLICMPass(pass);
>+    LLVMAddBasicAliasAnalysisPass(pass);
>+    LLVMAddTypeBasedAliasAnalysisPass(pass);
>     LLVMAddGVNPass(pass);
>     LLVMAddCFGSimplificationPass(pass);
>     LLVMRunPassManager(pass, state.module);

Flags:

fpizlo: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 118276: 205860