Attachment 203788 Details for Bug 112488 – Patch

[patch] Patch

bug-112488-20130605193526.patch (text/plain), 4.71 KB, created by SiqinBilige on 2013-06-05 03:36:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: SiqinBilige

Created: 2013-06-05 03:36:57 PDT

Size: 4.71 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 151206)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2013-06-05  SiqinBilige  <siqinbilige@gmail.com>
>+
>+        REGRESSION (r145854): Mongolian characters are not upright in vertical writing mode
>+        https://bugs.webkit.org/show_bug.cgi?id=112488
>+
>+        All Traditional Mongolian and Phags-Pa OpenType/TrueType/AAT fonts have counter-clockwise rotated glyphs.
>+        Traditional Mongolian and Phags-Pa should be rotated in vertical layout.
>+        Traditional Mongolian : 0x01800 - 0x018AF
>+        Phags-Pa : 0x0A840 - 0x0A87F 
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/graphics/FontGlyphs.cpp:
>+        (WebCore::shouldIgnoreRotation): Modified to Traditional Mongolian and Phags-Pa should be rotated in vertical layout.
>+
> 2013-06-05  Allan Sandfeld Jensen  <allan.jensen@digia.com>
> 
>         [Qt] Font::shouldUseSmoothing() has fake dependency on Qt 5.1
>Index: Source/WebCore/platform/graphics/FontGlyphs.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/FontGlyphs.cpp	(revision 151206)
>+++ Source/WebCore/platform/graphics/FontGlyphs.cpp	(working copy)
>@@ -132,7 +132,7 @@ static bool shouldIgnoreRotation(UChar32
>     if (isInRange(character, 0x002E5, 0x002EB))
>         return true;
>     
>-    if (isInRange(character, 0x01100, 0x011FF) || isInRange(character, 0x01401, 0x0167F) || isInRange(character, 0x01800, 0x018FF))
>+    if (isInRange(character, 0x01100, 0x011FF) || isInRange(character, 0x01401, 0x0167F) || isInRange(character, 0x018B0, 0x018FF))
>         return true;
> 
>     if (character == 0x02016 || character == 0x02018 || character == 0x02019 || character == 0x02020 || character == 0x02021
>@@ -168,7 +168,7 @@ static bool shouldIgnoreRotation(UChar32
>         || isInRange(character, 0x030FD, 0x0A4CF))
>         return true;
> 
>-    if (isInRange(character, 0x0A840, 0x0A87F) || isInRange(character, 0x0A960, 0x0A97F)
>+    if (isInRange(character, 0x0A960, 0x0A97F)
>         || isInRange(character, 0x0AC00, 0x0D7FF) || isInRange(character, 0x0E000, 0x0FAFF))
>         return true;
> 
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 151206)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2013-06-05  SiqinBilige  <siqinbilige@gmail.com>
>+
>+        REGRESSION (r145854): Mongolian characters are not upright in vertical writing mode
>+        https://bugs.webkit.org/show_bug.cgi?id=112488
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.png: Modified property svn:mime-type.
>+        * platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt: Removed 0x01800 and 0x01801.
>+
> 2013-06-05  Mihnea Ovidenie  <mihnea@adobe.com>
> 
>         [CSSRegions] Respect renderer creation constraints when element is part of named flow
>Index: LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt
>===================================================================
>--- LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt	(revision 151206)
>+++ LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt	(working copy)
>@@ -10,8 +10,8 @@ layer at (0,0) size 785x953
>         RenderText {#text} at (1,29) size 170x28
>           text run at (1,29) width 170: "\x{2E5}\x{2E6}\x{2E7}\x{2E8}\x{2E9}\x{2EA}\x{2EB}"
>         RenderBR {BR} at (170,52) size 1x0
>-        RenderText {#text} at (1,60) size 187x28
>-          text run at (1,60) width 187: "\x{1100}\x{1101}\x{1401}\x{1402}\x{1800}\x{1801}"
>+        RenderText {#text} at (1,60) size 131x28
>+          text run at (1,60) width 131: "\x{1100}\x{1101}\x{1401}\x{1402}"
>         RenderBR {BR} at (188,83) size 0x0
>         RenderText {#text} at (1,90) size 222x28
>           text run at (1,90) width 222: "\x{2016}\x{2018}\x{2019}\x{2020}\x{2021}\x{2030}\x{2031}"
>@@ -51,8 +51,8 @@ layer at (0,0) size 785x953
>         RenderText {#text} at (29,1) size 28x219
>           text run at (29,1) width 219: "\x{2E5}\x{2E6}\x{2E7}\x{2E8}\x{2E9}\x{2EA}\x{2EB}"
>         RenderBR {BR} at (34,219) size 0x1
>-        RenderText {#text} at (59,1) size 28x197
>-          text run at (59,1) width 197: "\x{1100}\x{1101}\x{1401}\x{1402}\x{1800}\x{1801}"
>+        RenderText {#text} at (59,1) size 28x141
>+          text run at (59,1) width 141: "\x{1100}\x{1101}\x{1401}\x{1402}"
>         RenderBR {BR} at (73,198) size 0x0
>         RenderText {#text} at (89,1) size 28x223
>           text run at (89,1) width 223: "\x{2016}\x{2018}\x{2019}\x{2020}\x{2021}\x{2030}\x{2031}"

Actions: View | Formatted Diff | Diff

Attachments on bug 112488: 193415 | 193416 | 193417 | 193418 | 202904 | 202907 | 203666 | 203668 | 203714 | 203770 | 203775 | 203788 | 203858 | 203898 | 203899 | 203902 | 203998 | 203999 | 204000 | 204001 | 204002 | 204294 | 204687 | 204971 | 205240 | 205241 | 205242 | 241535 | 241536