Attachment 202456 Details for Bug 115998 – the patch

[patch] the patch

blah.patch (text/plain), 2.28 KB, created by Filip Pizlo on 2013-05-21 12:07:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2013-05-21 12:07:46 PDT

Size: 2.28 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 150456)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2013-05-12  Filip Pizlo  <fpizlo@apple.com>
>+
>+        fourthTier: FTL shouldn't use FastISel and Small code model should be turned off for now
>+        https://bugs.webkit.org/show_bug.cgi?id=115998
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        This switches off FastISel and makes it possible to turn off Small code model.
>+
>+        * ftl/FTLCompile.cpp:
>+        (JSC::FTL::compile):
>+        * runtime/Options.h:
>+        (JSC):
>+
> 2013-05-17  Mark Hahnenberg  <mhahnenberg@apple.com>
> 
>         CheckArrays should be hoisted
>@@ -618,7 +632,6 @@
>         * runtime/Options.h:
>         (JSC):
> 
>->>>>>>> .r149942
> 2013-05-10  Filip Pizlo  <fpizlo@apple.com>
> 
>         fourthTier: FTL should support CompareStrictEqConstant
>Index: Source/JavaScriptCore/ftl/FTLCompile.cpp
>===================================================================
>--- Source/JavaScriptCore/ftl/FTLCompile.cpp	(revision 150456)
>+++ Source/JavaScriptCore/ftl/FTLCompile.cpp	(working copy)
>@@ -47,7 +47,8 @@ void compile(State& state)
>     LLVMInitializeMCJITCompilerOptions(&options, sizeof(options));
>     options.OptLevel = Options::llvmOptimizationLevel();
>     options.NoFramePointerElim = true;
>-    options.CodeModel = LLVMCodeModelSmall;
>+    if (Options::useLLVMSmallCodeModel())
>+        options.CodeModel = LLVMCodeModelSmall;
>     options.EnableFastISel = Options::enableLLVMFastISel();
>     
>     if (LLVMCreateMCJITCompilerForModule(&state.engine, state.module, &options, sizeof(options), &error)) {
>Index: Source/JavaScriptCore/runtime/Options.h
>===================================================================
>--- Source/JavaScriptCore/runtime/Options.h	(revision 150456)
>+++ Source/JavaScriptCore/runtime/Options.h	(working copy)
>@@ -85,7 +85,8 @@ namespace JSC {
>     v(bool, useExperimentalFTL, false) \
>     v(bool, useFTLTBAA, true) \
>     v(bool, enableLLVMLICM, true) \
>-    v(bool, enableLLVMFastISel, true) \
>+    v(bool, enableLLVMFastISel, false) \
>+    v(bool, useLLVMSmallCodeModel, false) \
>     v(unsigned, llvmOptimizationLevel, 2) \
>     \
>     v(bool, enableProfiler, false) \

Flags:

oliver: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 115998: 201514 | 201515 | 202456