Attachment 202423 Details for Bug 116534 – Adjust internal size when receiving data if needed

[patch] Adjust internal size when receiving data if needed

patch_115354_3.diff (text/plain), 2.44 KB, created by Andre Moreira Magalhaes on 2013-05-21 06:15:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andre Moreira Magalhaes

Created: 2013-05-21 06:15:44 PDT

Size: 2.44 KB

patch

obsolete

>From b08d96ca336b5d393751d88611355f689fcb6da3 Mon Sep 17 00:00:00 2001
>From: "Andre Moreira Magalhaes (andrunko)" <andre.magalhaes@collabora.co.uk>
>Date: Fri, 3 May 2013 12:27:30 +0100
>Subject: [PATCH] Adjust internal size on gstreamer source element when
> receiving data if necessary.
>
>If the size received in didReceiveResponse is smaller than the actual size of the received data
>update the internal size and the appsrc size to the proper value.
>---
> Source/WebCore/ChangeLog                                | 17 +++++++++++++++++
> .../graphics/gstreamer/WebKitWebSourceGStreamer.cpp     |  6 ++++++
> 2 files changed, 23 insertions(+)
>
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ce50987..7cb7f6e 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2013-05-03  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
>+
>+        Adjust internal size on gstreamer source element when receiving data if necessary
>+        https://bugs.webkit.org/show_bug.cgi?id=115354
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        If the size received in didReceiveResponse is smaller than the actual size of the received data
>+        update the internal size and the appsrc size to the proper value.
>+
>+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
>+        (StreamingClient::didReceiveData):
>+
> 2013-04-18  Seokju Kwon  <seokju.kwon@gmail.com>
> 
>         Web Inspector: Toolbar icons are displayed incorrectly
>diff --git a/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
>index 89f03c9..e991e31 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
>@@ -1016,6 +1016,12 @@ void StreamingClient::didReceiveData(ResourceHandle* handle, const char* data, i
>     if (priv->requestedOffset == priv->offset)
>         priv->requestedOffset += length;
>     priv->offset += length;
>+    // priv->size == 0 if received length on didReceiveResponse < 0
>+    if (priv->size != 0 && priv->offset > priv->size) {
>+        GST_DEBUG_OBJECT(m_src, "Updating internal size from %ld to %ld", priv->size, priv->offset);
>+        gst_app_src_set_size(priv->appsrc, priv->offset);
>+        priv->size = priv->offset;
>+    }
>     GST_BUFFER_OFFSET_END(priv->buffer.get()) = priv->offset;
> 
>     GST_OBJECT_UNLOCK(m_src);
>-- 
>1.8.1.2
>

Actions: View | Formatted Diff | Diff

Attachments on bug 116534: 202423 | 202424 | 203946 | 203947