Attachment 202416 Details for Bug 114978 – Patch

[patch] Patch

bug-114978.patch (text/plain), 2.50 KB, created by Patrick R. Gansterer on 2013-05-21 05:17:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick R. Gansterer

Created: 2013-05-21 05:17:50 PDT

Size: 2.50 KB

patch

obsolete

>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index a7579df..cb19c95 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,19 @@
>+2013-05-21  Patrick Gansterer  <paroga@webkit.org>
>+
>+        Use correct stack size on Solaris and OpenBSD
>+        https://bugs.webkit.org/show_bug.cgi?id=114978
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Original patch by David Hill <david@wmol.com>.
>+
>+        Use stack_t.ss_size for getting the size of the stack.
>+
>+        * wtf/Platform.h:
>+        * wtf/StackBounds.cpp:
>+        (WTF):
>+        (WTF::StackBounds::initialize):
>+
> 2013-05-14  Patrick Gansterer  <paroga@webkit.org>
> 
>         Introduce USE(WINGDI) for the Windows port
>diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h
>index b68a1a0..8c79454 100644
>--- a/Source/WTF/wtf/Platform.h
>+++ b/Source/WTF/wtf/Platform.h
>@@ -65,6 +65,11 @@
> #define WTF_CPU_ALPHA 1
> #endif
> 
>+/* CPU(HPPA) - HP PA-RISC */
>+#if defined(__hppa__) || defined(__hppa64__)
>+#define WTF_CPU_HPPA 1
>+#endif
>+
> /* CPU(IA64) - Itanium / IA-64 */
> #if defined(__ia64__)
> #define WTF_CPU_IA64 1
>diff --git a/Source/WTF/wtf/StackBounds.cpp b/Source/WTF/wtf/StackBounds.cpp
>index fa25689..6af18f9 100644
>--- a/Source/WTF/wtf/StackBounds.cpp
>+++ b/Source/WTF/wtf/StackBounds.cpp
>@@ -58,12 +58,12 @@ namespace WTF {
> // Bug 26276 - Need a mechanism to determine stack extent
> //
> // These platforms should now be working correctly:
>-//     DARWIN, QNX, UNIX
>+//     DARWIN, OPENBSD, QNX, SOLARIS, UNIX
> // These platforms are not:
>-//     WINDOWS, SOLARIS, OPENBSD, WINCE
>+//     WINDOWS, WINCE
> //
> // FIXME: remove this! - this code unsafely guesses at stack sizes!
>-#if OS(WINDOWS) || OS(SOLARIS) || OS(OPENBSD)
>+#if OS(WINDOWS)
> // Based on the current limit used by the JSC parser, guess the stack size.
> static const ptrdiff_t estimatedStackSize = 128 * sizeof(void*) * 1024;
> // This method assumes the stack is growing downwards.
>@@ -124,7 +124,7 @@ void StackBounds::initialize()
>     stack_t s;
>     thr_stksegment(&s);
>     m_origin = s.ss_sp;
>-    m_bound = estimateStackBound(m_origin);
>+    m_bound = static_cast<char*>(m_origin) - s.ss_size;
> }
> 
> #elif OS(OPENBSD)
>@@ -135,7 +135,11 @@ void StackBounds::initialize()
>     stack_t stack;
>     pthread_stackseg_np(thread, &stack);
>     m_origin = stack.ss_sp;
>-    m_bound = estimateStackBound(m_origin);
>+#if CPU(HPPA)
>+    m_bound = static_cast<char*>(m_origin) + stack.ss_size;
>+#else
>+    m_bound = static_cast<char*>(m_origin) - stack.ss_size;
>+#endif
> }
> 
> #elif OS(UNIX)

Actions: View | Formatted Diff | Diff

Attachments on bug 114978: 199057 | 202416