Attachment 201925 Details for Bug 116205 – Patch

[patch] Patch

bug-116205.patch (text/plain), 1.59 KB, created by Patrick R. Gansterer on 2013-05-15 23:36:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick R. Gansterer

Created: 2013-05-15 23:36:04 PDT

Size: 1.59 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 331a52f..c7c03e8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2013-05-15  Patrick Gansterer  <paroga@webkit.org>
>+
>+        Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
>+        https://bugs.webkit.org/show_bug.cgi?id=116205
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        SetFilePointerEx is not available on Windows CE, so use SetFilePointer.
>+        Also add a extra return for the case of an failure.
>+
>+        * platform/win/FileSystemWin.cpp:
>+        (WebCore::seekFile):
>+
> 2013-05-14  Patrick Gansterer  <paroga@webkit.org>
> 
>         [WINCE] Fix calls to GlyphPage::setGlyphDataForIndex()
>diff --git a/Source/WebCore/platform/win/FileSystemWin.cpp b/Source/WebCore/platform/win/FileSystemWin.cpp
>index 4818f84..cb814e5 100644
>--- a/Source/WebCore/platform/win/FileSystemWin.cpp
>+++ b/Source/WebCore/platform/win/FileSystemWin.cpp
>@@ -331,12 +331,12 @@ long long seekFile(PlatformFileHandle handle, long long offset, FileSeekOrigin o
>     LARGE_INTEGER largeOffset;
>     largeOffset.QuadPart = offset;
> 
>-    LARGE_INTEGER newOffset;
>-    newOffset.QuadPart = 0;
>+    largeOffset.LowPart = SetFilePointer(handle, largeOffset.LowPart, &largeOffset.HighPart, moveMethod);
> 
>-    SetFilePointerEx(handle, largeOffset, &newOffset, moveMethod);
>+    if (largeOffset.LowPart == 0xFFFFFFFF && GetLastError() != NO_ERROR)
>+        return -1;
> 
>-    return newOffset.QuadPart;
>+    return largeOffset.QuadPart;
> }
> 
> int writeToFile(PlatformFileHandle handle, const char* data, int length)

Flags:

rniwa: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 116205: 201920 | 201925 | 205290