Attachment 196703 Details for Bug 114073 – the patch

[patch] the patch

blah.patch (text/plain), 2.67 KB, created by Filip Pizlo on 2013-04-05 17:07:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Filip Pizlo

Created: 2013-04-05 17:07:16 PDT

Size: 2.67 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 147819)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2013-04-05  Filip Pizlo  <fpizlo@apple.com>
>+
>+        
>+        https://bugs.webkit.org/show_bug.cgi?id=114073
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * dfg/DFGGPRInfo.h:
>+        (GPRInfo):
>+        (JSC::DFG::GPRInfo::toArgumentRegister):
>+
> 2013-04-03  Filip Pizlo  <fpizlo@apple.com>
> 
>         fourthTier: put DFG data into a DFG::JITCode, and put common DFG and FTL data into something accessible from both DFG::JITCode and FTL::JITCode
>Index: Source/JavaScriptCore/dfg/DFGGPRInfo.h
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGGPRInfo.h	(revision 147607)
>+++ Source/JavaScriptCore/dfg/DFGGPRInfo.h	(working copy)
>@@ -259,6 +259,7 @@ class GPRInfo {
> public:
>     typedef GPRReg RegisterType;
>     static const unsigned numberOfRegisters = 5;
>+    static const unsigned numberOfArgumentRegisters = NUMBER_OF_ARGUMENT_REGISTERS;
> 
>     // Temporary registers.
>     static const GPRReg regT0 = X86Registers::eax;
>@@ -321,6 +322,7 @@ class GPRInfo {
> public:
>     typedef GPRReg RegisterType;
>     static const unsigned numberOfRegisters = 9;
>+    static const unsigned numberOfArgumentRegisters = NUMBER_OF_ARGUMENT_REGISTERS;
> 
>     // These registers match the baseline JIT.
>     static const GPRReg cachedResultRegister = X86Registers::eax;
>@@ -358,6 +360,13 @@ public:
>         static const GPRReg registerForIndex[numberOfRegisters] = { regT0, regT1, regT2, regT3, regT4, regT5, regT6, regT7, regT8 };
>         return registerForIndex[index];
>     }
>+    
>+    static GPRReg toArgumentRegister(unsigned index)
>+    {
>+        ASSERT(index < numberOfArgumentRegisters);
>+        static const GPRReg registerForIndex[numberOfArgumentRegisters] = { argumentGPR0, argumentGPR1, argumentGPR2, argumentGPR3, argumentGPR4, argumentGPR5 };
>+        return registerForIndex[index];
>+    }
> 
>     static unsigned toIndex(GPRReg reg)
>     {
>@@ -395,6 +404,7 @@ class GPRInfo {
> public:
>     typedef GPRReg RegisterType;
>     static const unsigned numberOfRegisters = 8;
>+    static const unsigned numberOfArgumentRegisters = NUMBER_OF_ARGUMENT_REGISTERS;
> 
>     // Temporary registers.
>     static const GPRReg regT0 = ARMRegisters::r0;
>@@ -468,6 +478,7 @@ class GPRInfo {
> public:
>     typedef GPRReg RegisterType;
>     static const unsigned numberOfRegisters = 6;
>+    static const unsigned numberOfArgumentRegisters = NUMBER_OF_ARGUMENT_REGISTERS;
> 
>     // Temporary registers.
>     static const GPRReg regT0 = MIPSRegisters::v0;

Flags:

mhahnenberg: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 114073: 196703