Attachment 192693 Details for Bug 111179 – patch

[patch] patch

draft.patch (text/plain), 2.14 KB, created by Zoltan Herczeg on 2013-03-12 03:19:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zoltan Herczeg

Created: 2013-03-12 03:19:35 PDT

Size: 2.14 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1a4fe68..ff4850b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2013-03-12  Zoltan Herczeg  <zherczeg@webkit.org>
>+
>+        [Cairo] Surface pointer passed to asNewNativeImage() might be freed.
>+        https://bugs.webkit.org/show_bug.cgi?id=111179
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When the m_frameBufferCache member of ImageDecoder is resized, we need
>+        to keep the original data pointed by m_backingStore on Cairo, because
>+        this area is also referenced by cairo surfaces returned by asNewNativeImage.
>+        These surfaces currently owned by other, unknown objects, so we cannot update
>+        them. Otherwise ImageFrame behaves like a normal class.
>+
>+        * platform/image-decoders/ImageDecoder.h:
>+        (WTF):
>+        (WebCore):
>+
> 2013-02-07  Vsevolod Vlasov  <vsevik@chromium.org>
> 
>         Web Inspector: linkifyResourceAsNode produced anchor should not prefer resources to scripts panel.
>diff --git a/Source/WebCore/platform/image-decoders/ImageDecoder.h b/Source/WebCore/platform/image-decoders/ImageDecoder.h
>index 2e0b57f..98c9581 100644
>--- a/Source/WebCore/platform/image-decoders/ImageDecoder.h
>+++ b/Source/WebCore/platform/image-decoders/ImageDecoder.h
>@@ -238,6 +238,27 @@ namespace WebCore {
>         bool m_premultiplyAlpha;
>     };
> 
>+} // namespace WebCore
>+
>+namespace WTF {
>+
>+#if USE(CAIRO)
>+
>+// When the m_frameBufferCache member of ImageDecoder is resized, we need
>+// to keep the original data pointed by m_backingStore on Cairo, because
>+// this area is also referenced by cairo surfaces returned by asNewNativeImage.
>+// These surfaces currently owned by other, unknown objects, so we cannot update
>+// them. Otherwise ImageFrame behaves like a normal class.
>+
>+template<> struct VectorTraits<WebCore::ImageFrame> : VectorTraitsBase<false, void> {
>+    static const bool canMoveWithMemcpy = true;
>+};
>+#endif
>+
>+} // namespace WTF
>+
>+namespace WebCore {
>+
>     // ImageDecoder is a base for all format-specific decoders
>     // (e.g. JPEGImageDecoder).  This base manages the ImageFrame cache.
>     //

Actions: View | Formatted Diff | Diff

Attachments on bug 111179: 190964 | 192693 | 229057 | 229059 | 233153 | 233200 | 258593 | 273214 | 273528