WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch
bug-110521-20130223115142.patch (text/plain), 27.10 KB, created by
Jason Anderssen
on 2013-02-22 17:55:21 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Jason Anderssen
Created:
2013-02-22 17:55:21 PST
Size:
27.10 KB
patch
obsolete
>Subversion Revision: 143685 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 65ae5cc5e89868c7d8e2e4272fa1bc38417fac11..cd1e9ca2cac62595f739a5c045ebc4c2d088ab35 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,19 @@ >+2013-02-22 Jason Anderssen <janderssen@gmail.com> >+ >+ Move setAutofilled from TestRunner to WebCore >+ https://bugs.webkit.org/show_bug.cgi?id=110521 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ No new tests (OOPS!). >+ >+ * testing/Internals.cpp: >+ (WebCore): >+ (WebCore::Internals::setAutofilled): >+ * testing/Internals.h: >+ (Internals): >+ * testing/Internals.idl: >+ > 2013-02-21 Tony Gentilcore <tonyg@chromium.org> > > Invalidate outstanding checkpoints for the background input stream and preload scanner >diff --git a/Source/WebKit/efl/ChangeLog b/Source/WebKit/efl/ChangeLog >index 19d7df9f7425643685ae775e5a076de342dcd925..6110b6d96ed6d11da1c07a0d5c86236e07956f88 100644 >--- a/Source/WebKit/efl/ChangeLog >+++ b/Source/WebKit/efl/ChangeLog >@@ -1,3 +1,13 @@ >+2013-02-22 Jason Anderssen <janderssen@gmail.com> >+ >+ Move setAutofilled from TestRunner to WebCore >+ https://bugs.webkit.org/show_bug.cgi?id=110521 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * WebCoreSupport/DumpRenderTreeSupportEfl.cpp: >+ * WebCoreSupport/DumpRenderTreeSupportEfl.h: >+ > 2013-02-19 Tony Chang <tony@chromium.org> > > Convert 3 settings to use Settings.in >diff --git a/Source/WebKit/gtk/ChangeLog b/Source/WebKit/gtk/ChangeLog >index f7ea4e205899d95ecc98ba6c5d2a34ad888aeb9a..6adf65b122164308dcd96737a41a25a15dc30158 100644 >--- a/Source/WebKit/gtk/ChangeLog >+++ b/Source/WebKit/gtk/ChangeLog >@@ -1,3 +1,14 @@ >+2013-02-22 Jason Anderssen <janderssen@gmail.com> >+ >+ Move setAutofilled from TestRunner to WebCore >+ https://bugs.webkit.org/show_bug.cgi?id=110521 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: >+ * WebCoreSupport/DumpRenderTreeSupportGtk.h: >+ (DumpRenderTreeSupportGtk): >+ > 2013-02-21 George McCollister <george.mccollister@gmail.com> > > [GTK] Remove subresource leaks from WebKit1 and WebKit2 >diff --git a/Source/WebKit/qt/ChangeLog b/Source/WebKit/qt/ChangeLog >index a842a20fb28ad95b14e786b1b582fc567a92c9fa..d30be3fefe7c675d0b19043c4fb66119c337039d 100644 >--- a/Source/WebKit/qt/ChangeLog >+++ b/Source/WebKit/qt/ChangeLog >@@ -1,3 +1,13 @@ >+2013-02-22 Jason Anderssen <janderssen@gmail.com> >+ >+ Move setAutofilled from TestRunner to WebCore >+ https://bugs.webkit.org/show_bug.cgi?id=110521 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * WebCoreSupport/DumpRenderTreeSupportQt.cpp: >+ * WebCoreSupport/DumpRenderTreeSupportQt.h: >+ > 2013-02-21 Allan Sandfeld Jensen <allan.jensen@digia.com> > > [Qt] Replace QWebPageAdaptor::TouchAdjuster >diff --git a/Source/WebCore/testing/Internals.cpp b/Source/WebCore/testing/Internals.cpp >index 38344109163012937c9f555c0e57284938f3ffa7..8d3a64ea47016a49b5ff6ca79a5f681c82ee0a6f 100644 >--- a/Source/WebCore/testing/Internals.cpp >+++ b/Source/WebCore/testing/Internals.cpp >@@ -816,6 +816,20 @@ Vector<String> Internals::formControlStateOfPreviousHistoryItem(ExceptionCode& e > } > return mainItem->target() == uniqueName ? mainItem->documentState() : mainItem->childItemWithTarget(uniqueName)->documentState(); > } >+ >+void Internals::setAutofilled(Element* element, bool enabled, ExceptionCode& ec) >+{ >+ if (!element->hasTagName(inputTag)) { >+ ec = INVALID_ACCESS_ERR; >+ return; >+ } >+ HTMLInputElement* inputElement = element->toInputElement(); >+ if (!inputElement) { >+ ec = INVALID_ACCESS_ERR; >+ return; >+ } >+ inputElement->setAutofilled(enabled); >+} > > void Internals::setFormControlStateOfPreviousHistoryItem(const Vector<String>& state, ExceptionCode& ec) > { >diff --git a/Source/WebCore/testing/Internals.h b/Source/WebCore/testing/Internals.h >index 3cada19c33bc68a31898194d28fc8a9358998779..5e573a7ceab8776a858c7e9a7befddf8c00abaed 100644 >--- a/Source/WebCore/testing/Internals.h >+++ b/Source/WebCore/testing/Internals.h >@@ -208,6 +208,8 @@ public: > InternalSettings* settings() const; > unsigned workerThreadCount() const; > >+ void setAutofilled(Element*, bool enabled, ExceptionCode&); >+ > void setBatteryStatus(Document*, const String& eventType, bool charging, double chargingTime, double dischargingTime, double level, ExceptionCode&); > > void setNetworkInformation(Document*, const String& eventType, double bandwidth, bool metered, ExceptionCode&); >diff --git a/Source/WebCore/testing/Internals.idl b/Source/WebCore/testing/Internals.idl >index 85efd945bd957779aecf42d13990c04842183974..05f6ab06c0f44fe56bc38d609ee7cafa3064bf9b 100644 >--- a/Source/WebCore/testing/Internals.idl >+++ b/Source/WebCore/testing/Internals.idl >@@ -253,4 +253,6 @@ > [Conditional=ENCRYPTED_MEDIA_V2] void initializeMockCDM(); > > [Conditional=SPEECH_SYNTHESIS] void enableMockSpeechSynthesizer(); >+ >+ void setAutofilled(in Element scope, in boolean enabled) raises(DOMException); > }; >diff --git a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp >index 8bb486dad9c378fd63ceba55e402fa60302362d1..b9d17e8c1842f3031ce97c0dac7fd825c1721784 100644 >--- a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp >+++ b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp >@@ -247,19 +247,6 @@ void DumpRenderTreeSupportEfl::setValueForUser(JSContextRef context, JSValueRef > inputElement->setValueForUser(value); > } > >-void DumpRenderTreeSupportEfl::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled) >-{ >- JSC::ExecState* exec = toJS(context); >- WebCore::Element* element = WebCore::toElement(toJS(exec, nodeObject)); >- if (!element) >- return; >- WebCore::HTMLInputElement* inputElement = element->toInputElement(); >- if (!inputElement) >- return; >- >- inputElement->setAutofilled(autofilled); >-} >- > void DumpRenderTreeSupportEfl::setDefersLoading(Evas_Object* ewkView, bool defers) > { > DRT_SUPPRT_PAGE_GET_OR_RETURN(ewkView, page); >diff --git a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h >index e92505792bfa5cee470479b8f3c0d23f724ac486..aed3c75d02f9ff3931e377d594a3829112ebaba7 100644 >--- a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h >+++ b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h >@@ -68,7 +68,6 @@ public: > static String suitableDRTFrameName(const Evas_Object* ewkFrame); > static String layerTreeAsText(const Evas_Object* ewkFrame); > static void setValueForUser(JSContextRef, JSValueRef nodeObject, const String& value); >- static void setAutofilled(JSContextRef, JSValueRef nodeObject, bool autofilled); > static void setDefersLoading(Evas_Object* ewkView, bool defers); > static void setLoadsSiteIconsIgnoringImageLoadingSetting(Evas_Object* ewkView, bool loadsSiteIconsIgnoringImageLoadingPreferences); > static void setMinimumLogicalFontSize(Evas_Object* ewkView, int size); >diff --git a/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp b/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp >index 735a0e74fa1bd297cfb3b868822dc550b9184db3..eeccd6726a0f66fac24e39c5ee0ede8a060d8699 100644 >--- a/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp >+++ b/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp >@@ -548,19 +548,6 @@ CString DumpRenderTreeSupportGtk::accessibilityHelpText(AtkObject* axObject) > return coreObject->helpText().utf8(); > } > >-void DumpRenderTreeSupportGtk::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled) >-{ >- JSC::ExecState* exec = toJS(context); >- Element* element = toElement(toJS(exec, nodeObject)); >- if (!element) >- return; >- HTMLInputElement* inputElement = element->toInputElement(); >- if (!inputElement) >- return; >- >- inputElement->setAutofilled(autofilled); >-} >- > void DumpRenderTreeSupportGtk::setValueForUser(JSContextRef context, JSValueRef nodeObject, JSStringRef value) > { > JSC::ExecState* exec = toJS(context); >diff --git a/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h b/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h >index a349fa8cceeda752d8620e7e6fb0aef1e3dc17ae..42b85cd5fd9fcbc58224f2199d68a614149b3220 100644 >--- a/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h >+++ b/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h >@@ -68,7 +68,6 @@ public: > static AtkObject* getFocusedAccessibleElement(WebKitWebFrame*); > static AtkObject* getRootAccessibleElement(WebKitWebFrame*); > static void layoutFrame(WebKitWebFrame*); >- static void setAutofilled(JSContextRef, JSValueRef, bool); > static void setValueForUser(JSContextRef, JSValueRef, JSStringRef); > static bool shouldClose(WebKitWebFrame*); > static bool elementDoesAutoCompleteForElementWithId(WebKitWebFrame*, JSStringRef); >diff --git a/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp b/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp >index 07528b01f96378c0450c8e9b1f94576a0ff68352..4ec5d2e9eb4af77d71427e2fa0b4571dc579c9ec 100644 >--- a/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp >+++ b/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp >@@ -264,18 +264,6 @@ bool DumpRenderTreeSupportQt::hasDocumentElement(QWebFrameAdapter *adapter) > return adapter->frame->document()->documentElement(); > } > >-void DumpRenderTreeSupportQt::setAutofilled(const QWebElement& element, bool isAutofilled) >-{ >- WebCore::Element* webElement = element.m_element; >- if (!webElement) >- return; >- HTMLInputElement* inputElement = webElement->toInputElement(); >- if (!inputElement) >- return; >- >- inputElement->setAutofilled(isAutofilled); >-} >- > void DumpRenderTreeSupportQt::setValueForUser(const QWebElement& element, const QString& value) > { > WebCore::Element* webElement = element.m_element; >diff --git a/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h b/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h >index 401d9b629f103ae05262b4d7fe50c5996ad39617..03b488b9ccaf253c991d8d02e0f64248eb434b23 100644 >--- a/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h >+++ b/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h >@@ -108,7 +108,6 @@ public: > > static void garbageCollectorCollect(); > static void garbageCollectorCollectOnAlternateThread(bool waitUntilDone); >- static void setAutofilled(const QWebElement&, bool enabled); > static void setValueForUser(const QWebElement&, const QString& value); > static int javaScriptObjectsCount(); > static void clearScriptWorlds(); >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 96a1ac43c34d439310fcacb6228bca2aa1a9affd..56913f61936d7872315d4a605362a9e830d4e608 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,28 @@ >+2013-02-22 Jason Anderssen <janderssen@gmail.com> >+ >+ Move setAutofilled from TestRunner to WebCore >+ https://bugs.webkit.org/show_bug.cgi?id=110521 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * DumpRenderTree/TestRunner.cpp: >+ (TestRunner::staticFunctions): >+ * DumpRenderTree/TestRunner.h: >+ (TestRunner): >+ * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: >+ * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: >+ (WebTestRunner::TestRunner::TestRunner): >+ * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: >+ (TestRunner): >+ * DumpRenderTree/efl/TestRunnerEfl.cpp: >+ * DumpRenderTree/gtk/TestRunnerGtk.cpp: >+ * DumpRenderTree/mac/TestRunnerMac.mm: >+ * DumpRenderTree/qt/TestRunnerQt.cpp: >+ * DumpRenderTree/qt/TestRunnerQt.h: >+ (TestRunnerQt): >+ * DumpRenderTree/win/TestRunnerWin.cpp: >+ * DumpRenderTree/wx/TestRunnerWx.cpp: >+ > 2013-02-21 Dirk Pranke <dpranke@chromium.org> > > [chromium] support the lucid version of freetype on precise in DRT >diff --git a/Tools/DumpRenderTree/TestRunner.cpp b/Tools/DumpRenderTree/TestRunner.cpp >index 6c8f8fb9d168847137a4d0d5ffbf77b4c7f73609..72e6ff15d303e4adaa9ab0810652fa89c330f0a1 100644 >--- a/Tools/DumpRenderTree/TestRunner.cpp >+++ b/Tools/DumpRenderTree/TestRunner.cpp >@@ -939,17 +939,6 @@ static JSValueRef setAuthorAndUserStylesEnabledCallback(JSContextRef context, JS > return JSValueMakeUndefined(context); > } > >-static JSValueRef setAutofilledCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception) >-{ >- if (argumentCount != 2 || !arguments[0]) >- return JSValueMakeUndefined(context); >- >- TestRunner* controller = static_cast<TestRunner*>(JSObjectGetPrivate(thisObject)); >- controller->setAutofilled(context, arguments[0], JSValueToBoolean(context, arguments[1])); >- >- return JSValueMakeUndefined(context); >-} >- > static JSValueRef setCacheModelCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception) > { > // Has Mac implementation. >@@ -2153,7 +2142,6 @@ JSStaticFunction* TestRunner::staticFunctions() > { "setAuthenticationPassword", setAuthenticationPasswordCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, > { "setAuthenticationUsername", setAuthenticationUsernameCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, > { "setAuthorAndUserStylesEnabled", setAuthorAndUserStylesEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, >- { "setAutofilled", setAutofilledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, > { "setCacheModel", setCacheModelCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, > { "setCallCloseOnWebViews", setCallCloseOnWebViewsCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, > { "setCanOpenWindows", setCanOpenWindowsCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, >diff --git a/Tools/DumpRenderTree/TestRunner.h b/Tools/DumpRenderTree/TestRunner.h >index 7920ec64436793acd622a2af5943e5d4e3d9eae8..df840e1c283d637c626250cd85012e18a6860c88 100644 >--- a/Tools/DumpRenderTree/TestRunner.h >+++ b/Tools/DumpRenderTree/TestRunner.h >@@ -86,7 +86,6 @@ public: > void setAppCacheMaximumSize(unsigned long long quota); > void setApplicationCacheOriginQuota(unsigned long long); > void setAuthorAndUserStylesEnabled(bool); >- void setAutofilled(JSContextRef, JSValueRef nodeObject, bool autofilled); > void setCacheModel(int); > void setCustomPolicyDelegate(bool setDelegate, bool permissive); > void setDatabaseQuota(unsigned long long quota); >diff --git a/Tools/DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp b/Tools/DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp >index 4ad36e6627d731c1b8ee12752c42a23f49028f12..7c08aae74134d7f92e0706e2ebc7c16d86c4e6db 100644 >--- a/Tools/DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp >+++ b/Tools/DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp >@@ -616,19 +616,6 @@ void TestRunner::setAsynchronousSpellCheckingEnabled(bool) > notImplemented(); > } > >-void TestRunner::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled) >-{ >- JSC::ExecState* exec = toJS(context); >- WebCore::Element* element = toElement(toJS(exec, nodeObject)); >- if (!element) >- return; >- WebCore::HTMLInputElement* inputElement = element->toInputElement(); >- if (!inputElement) >- return; >- >- inputElement->setAutofilled(autofilled); >-} >- > int TestRunner::numberOfPendingGeolocationPermissionRequests() > { > return DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests(BlackBerry::WebKit::DumpRenderTree::currentInstance()->page()); >diff --git a/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp b/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp >index 2ab9a3089c3b10ab910281d19c63d421cc069ca8..172a7aeb6b7803ea4f41e30aba7f97e8656ad782 100644 >--- a/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp >+++ b/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp >@@ -198,7 +198,6 @@ TestRunner::TestRunner(TestInterfaces* interfaces) > bindMethod("startSpeechInput", &TestRunner::startSpeechInput); > bindMethod("markerTextForListItem", &TestRunner::markerTextForListItem); > bindMethod("findString", &TestRunner::findString); >- bindMethod("setAutofilled", &TestRunner::setAutofilled); > bindMethod("setValueForUser", &TestRunner::setValueForUser); > bindMethod("enableFixedLayoutMode", &TestRunner::enableFixedLayoutMode); > bindMethod("setFixedLayoutSize", &TestRunner::setFixedLayoutSize); >@@ -1377,23 +1376,6 @@ void TestRunner::findString(const CppArgumentList& arguments, CppVariant* result > result->set(findResult); > } > >-void TestRunner::setAutofilled(const CppArgumentList& arguments, CppVariant* result) >-{ >- result->setNull(); >- if (arguments.size() != 2 || !arguments[1].isBool()) >- return; >- >- WebElement element; >- if (!WebBindings::getElement(arguments[0].value.objectValue, &element)) >- return; >- >- WebInputElement* input = toWebInputElement(&element); >- if (!input) >- return; >- >- input->setAutofilled(arguments[1].value.boolValue); >-} >- > void TestRunner::setValueForUser(const CppArgumentList& arguments, CppVariant* result) > { > result->setNull(); >diff --git a/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h b/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h >index c2dc8669224dbdf1ba9245d4b2a7899ebdf7c2df..74cc81eade993f6f548122b0d6c47cc81773b331 100644 >--- a/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h >+++ b/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h >@@ -241,10 +241,6 @@ private: > void markerTextForListItem(const CppArgumentList&, CppVariant*); > void findString(const CppArgumentList&, CppVariant*); > >- // Expects the first argument to be an input element and the second argument to be a boolean. >- // Forwards the setAutofilled() call to the element. >- void setAutofilled(const CppArgumentList&, CppVariant*); >- > // Expects the first argument to be an input element and the second argument to be a string value. > // Forwards the setValueForUser() call to the element. > void setValueForUser(const CppArgumentList&, CppVariant*); >diff --git a/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp b/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp >index 45646109ccfe6d8b8a770beac16461705f3b680b..f3943dc5de8885d92cfd4aaa2610ab81a17d1a5d 100644 >--- a/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp >+++ b/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp >@@ -338,11 +338,6 @@ void TestRunner::setAuthorAndUserStylesEnabled(bool flag) > DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled(browser->mainView(), flag); > } > >-void TestRunner::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled) >-{ >- DumpRenderTreeSupportEfl::setAutofilled(context, nodeObject, autofilled); >-} >- > void TestRunner::setMockDeviceOrientation(bool, double, bool, double, bool, double) > { > // FIXME: Implement for DeviceOrientation layout tests. >diff --git a/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp b/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp >index 4c8e7b409d086e41da6d87f9301614712939abe9..996fb582cc079cf6da092ff271d0e3af7190bf0c 100644 >--- a/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp >+++ b/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp >@@ -414,11 +414,6 @@ void TestRunner::setAuthorAndUserStylesEnabled(bool flag) > // FIXME: implement > } > >-void TestRunner::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool isAutofilled) >-{ >- DumpRenderTreeSupportGtk::setAutofilled(context, nodeObject, isAutofilled); >-} >- > void TestRunner::setMockDeviceOrientation(bool canProvideAlpha, double alpha, bool canProvideBeta, double beta, bool canProvideGamma, double gamma) > { > // FIXME: Implement for DeviceOrientation layout tests. >diff --git a/Tools/DumpRenderTree/mac/TestRunnerMac.mm b/Tools/DumpRenderTree/mac/TestRunnerMac.mm >index fc3afa676520abd4af4bb5c5fc2c5d954354dfe0..36b3c929f14150e72acc56d41d42ddefff57964a 100644 >--- a/Tools/DumpRenderTree/mac/TestRunnerMac.mm >+++ b/Tools/DumpRenderTree/mac/TestRunnerMac.mm >@@ -419,15 +419,6 @@ void TestRunner::setAuthorAndUserStylesEnabled(bool flag) > [[[mainFrame webView] preferences] setAuthorAndUserStylesEnabled:flag]; > } > >-void TestRunner::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled) >-{ >- DOMElement *element = [DOMElement _DOMElementFromJSContext:context value:nodeObject]; >- if (!element || ![element isKindOfClass:[DOMHTMLInputElement class]]) >- return; >- >- [(DOMHTMLInputElement *)element _setAutofilled:autofilled]; >-} >- > void TestRunner::setCustomPolicyDelegate(bool setDelegate, bool permissive) > { > if (setDelegate) { >diff --git a/Tools/DumpRenderTree/qt/TestRunnerQt.cpp b/Tools/DumpRenderTree/qt/TestRunnerQt.cpp >index 2d7f3bf341d629b2a80b7d980060ccf0bdb74771..15ad127611dbcd9ef12464e5c20f2da8b7e21415 100644 >--- a/Tools/DumpRenderTree/qt/TestRunnerQt.cpp >+++ b/Tools/DumpRenderTree/qt/TestRunnerQt.cpp >@@ -475,11 +475,6 @@ void TestRunnerQt::setAppCacheMaximumSize(unsigned long long quota) > m_drt->webPage()->settings()->setOfflineWebApplicationCacheQuota(quota); > } > >-void TestRunnerQt::setAutofilled(const QWebElement& element, bool isAutofilled) >-{ >- return DumpRenderTreeSupportQt::setAutofilled(element, isAutofilled); >-} >- > void TestRunnerQt::setValueForUser(const QWebElement& element, const QString& value) > { > DumpRenderTreeSupportQt::setValueForUser(element, value); >diff --git a/Tools/DumpRenderTree/qt/TestRunnerQt.h b/Tools/DumpRenderTree/qt/TestRunnerQt.h >index bc2af9a143312ffb7260585c450327fcb5e129fd..652ad1c17b06457d105417fe2e4054e4b8fa417c 100644 >--- a/Tools/DumpRenderTree/qt/TestRunnerQt.h >+++ b/Tools/DumpRenderTree/qt/TestRunnerQt.h >@@ -162,7 +162,6 @@ public Q_SLOTS: > void setAllowUniversalAccessFromFileURLs(bool enable); > void setAllowFileAccessFromFileURLs(bool enable); > void setAppCacheMaximumSize(unsigned long long quota); >- void setAutofilled(const QWebElement&, bool enable); > void setValueForUser(const QWebElement&, const QString& value); > void setFixedContentsSize(int width, int height); > void setPrivateBrowsingEnabled(bool); >diff --git a/Tools/DumpRenderTree/win/TestRunnerWin.cpp b/Tools/DumpRenderTree/win/TestRunnerWin.cpp >index 8c27a52c7eb41875522b8bf331a2711031ae2941..4a0b787ab87590b5b80625aef9d23c96e0e98f73 100644 >--- a/Tools/DumpRenderTree/win/TestRunnerWin.cpp >+++ b/Tools/DumpRenderTree/win/TestRunnerWin.cpp >@@ -335,27 +335,6 @@ void TestRunner::setAuthorAndUserStylesEnabled(bool flag) > prefsPrivate->setAuthorAndUserStylesEnabled(flag); > } > >-void TestRunner::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled) >-{ >- COMPtr<IWebView> webView; >- if (FAILED(frame->webView(&webView))) >- return; >- >- COMPtr<IWebViewPrivate> webViewPrivate(Query, webView); >- if (!webViewPrivate) >- return; >- >- COMPtr<IDOMElement> element; >- if (FAILED(webViewPrivate->elementFromJS(context, nodeObject, &element))) >- return; >- >- COMPtr<IFormsAutoFillTransition> autofillElement(Query, element); >- if (!autofillElement) >- return; >- >- autofillElement->setAutofilled(autofilled); >-} >- > void TestRunner::setCustomPolicyDelegate(bool setDelegate, bool permissive) > { > COMPtr<IWebView> webView; >diff --git a/Tools/DumpRenderTree/wx/TestRunnerWx.cpp b/Tools/DumpRenderTree/wx/TestRunnerWx.cpp >index f8f985546e7ff393d3b424f695b845401c818e17..b1c45c430b6737ad700004411982395d16e1a309 100644 >--- a/Tools/DumpRenderTree/wx/TestRunnerWx.cpp >+++ b/Tools/DumpRenderTree/wx/TestRunnerWx.cpp >@@ -199,11 +199,6 @@ void TestRunner::setAuthorAndUserStylesEnabled(bool flag) > // FIXME: implement > } > >-void TestRunner::setAutofilled(JSContextRef, JSValueRef element, bool isAutofilled) >-{ >- // FIXME: implement >-} >- > void TestRunner::setPopupBlockingEnabled(bool popupBlockingEnabled) > { > // FIXME: implement >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index cd8e5d3541c487cdd56a52a050a8e96db737ea68..148ba9dbadcc85abb650214ef8c2b3b7961ab4f5 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,14 @@ >+2013-02-22 Jason Anderssen <janderssen@gmail.com> >+ >+ Moved setAutofilled from TestRunner to WebCore >+ https://bugs.webkit.org/show_bug.cgi?id=110521 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * fast/forms/input-autofilled.html: >+ * fast/forms/reset-autofilled.html: >+ * platform/wk2/TestExpectations: >+ > 2013-02-21 Benjamin Poulain <benjamin@webkit.org> > > Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html. >diff --git a/LayoutTests/fast/forms/input-autofilled.html b/LayoutTests/fast/forms/input-autofilled.html >index 38150acd5a3b068c7f1313f056419382c35887fa..fffd0881343246e12a77924020a910181f7901f0 100644 >--- a/LayoutTests/fast/forms/input-autofilled.html >+++ b/LayoutTests/fast/forms/input-autofilled.html >@@ -12,8 +12,8 @@ > var originalForeground = computedStyle.color; > var originalBackground = computedStyle.backgroundColor; > >- if (window.testRunner) { >- testRunner.setAutofilled(tf, true); >+ if (window.internals) { >+ window.internals.setAutofilled(tf, true); > } > > // Both the foreground and background colors should change. >@@ -29,8 +29,8 @@ > return; > } > >- if (window.testRunner) { >- testRunner.setAutofilled(tf, false); >+ if (window.internals) { >+ window.internals.setAutofilled(tf, false); > } > > // Colors should be restored. >diff --git a/LayoutTests/fast/forms/reset-autofilled.html b/LayoutTests/fast/forms/reset-autofilled.html >index 662f12e128d62800630c2a6083d1c1e0e03c6cac..c4a161a4f47d7af0232d555fca0c1f702cb4ac9b 100644 >--- a/LayoutTests/fast/forms/reset-autofilled.html >+++ b/LayoutTests/fast/forms/reset-autofilled.html >@@ -12,8 +12,8 @@ > } > > var field = document.getElementById('field'); >- if (window.testRunner) { >- testRunner.setAutofilled(field, true); >+ if (window.internals) { >+ window.internals.setAutofilled(field, true); > } else { > testFailed('This test requires a LayoutTestController.'); > return; >diff --git a/LayoutTests/platform/wk2/TestExpectations b/LayoutTests/platform/wk2/TestExpectations >index d38facf6b907c54df463140ab5fb866255328bbf..fe44121f3286519526c7c025275fc70852ce54e4 100644 >--- a/LayoutTests/platform/wk2/TestExpectations >+++ b/LayoutTests/platform/wk2/TestExpectations >@@ -503,10 +503,6 @@ storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html > storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html > storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html > >-# WebKitTestRunner needs layoutTestController.setAutofilled >-fast/forms/input-autofilled.html >-fast/forms/reset-autofilled.html >- > # WebKitTestRunner needs eventSender.contextClick() > # https://bugs.webkit.org/show_bug.cgi?id=86881 > editing/selection/context-menu-text-selection.html
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=189878">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 110521
:
189674
|
189878
|
189893
|
189895
|
189908