Attachment 186070 Details for Bug 108510 – Patch

[patch] Patch

bug-108510-20130201100651.patch (text/plain), 3.31 KB, created by Rouslan Solomakhin on 2013-02-01 10:10:08 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Rouslan Solomakhin

Created: 2013-02-01 10:10:08 PST

Size: 3.31 KB

patch

obsolete

>Subversion Revision: 141599
>diff --git a/Source/WebKit/chromium/ChangeLog b/Source/WebKit/chromium/ChangeLog
>index 0a4540c253371c1338ca6388fb55c803d3befa32..cd16ad6c3903f24af4d94444041a8cf67b21eae5 100644
>--- a/Source/WebKit/chromium/ChangeLog
>+++ b/Source/WebKit/chromium/ChangeLog
>@@ -1,3 +1,13 @@
>+2013-02-01  Rouslan Solomakhin  <rouslan@chromium.org>
>+
>+        [Chromium] Ignore whitespace in spellcheck
>+        https://bugs.webkit.org/show_bug.cgi?id=108510
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * src/ContextMenuClientImpl.cpp:
>+        (WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.
>+
> 2013-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
> 
>         Unreviewed.  Rolled Chromium DEPS to r180131.  Requested by
>diff --git a/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp b/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
>index f5ea06e2177412f5c1b73732033583f748067fce..6c0b5ce2ff8fa3858d28416264b25bea4b7224c1 100644
>--- a/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
>+++ b/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
>@@ -166,7 +166,7 @@ static String selectMisspellingAsync(Frame* selectedFrame, Vector<DocumentMarker
>         selectionRange = selection.toNormalizedRange();
>     }
> 
>-    if (!WebCore::areRangesEqual(markerRange.get(), selectionRange.get()))
>+    if (markerRange->text().stripWhiteSpace() != selectionRange->text().stripWhiteSpace())
>         return String();
> 
>     return markerRange->text();
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ec6978905eb17adc8f2017483888ae4ff34c726c..29a13f1608283a03e38ffd73ad62e09f100f90fa 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2013-02-01  Rouslan Solomakhin  <rouslan@chromium.org>
>+
>+        [Chromium] Expect spellcheck to ignore whitespace
>+        https://bugs.webkit.org/show_bug.cgi?id=108510
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/chromium/TestExpectations: Expect spellcheck to ignore whitespace.
>+
> 2013-02-01  Pavel Feldman  <pfeldman@chromium.org>
> 
>         Web Inspector: relax goto file matching again.
>diff --git a/LayoutTests/platform/chromium/TestExpectations b/LayoutTests/platform/chromium/TestExpectations
>index a26b22a0299d00197a4891e4b299ed3b41bb8ad8..5d01a70242be614580985eec6216c33dd5cb05ac 100644
>--- a/LayoutTests/platform/chromium/TestExpectations
>+++ b/LayoutTests/platform/chromium/TestExpectations
>@@ -4338,11 +4338,9 @@ webkit.org/b/108286 platform/chromium/virtual/softwarecompositing/geometry/fixed
> webkit.org/b/108286 platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down.html [ ImageOnlyFailure ]
> 
> # Spellchecker behavior tests.
>-webkit.org/b/108370 editing/spelling/spelling-double-clicked-word.html [ Failure ]
> webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Failure ]
> webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Failure ]
> webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Failure ]
>-webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Failure ]
> 
> webkit.org/b/108424 media/video-error-does-not-exist.html [ Failure Crash ]
> webkit.org/b/108566 platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html [ Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 108510: 186070