Attachment 185414 Details for Bug 108283 – Patch

[patch] Patch

bug-108283-20130130002139.patch (text/plain), 3.97 KB, created by Tien-Ren Chen on 2013-01-30 00:24:53 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Tien-Ren Chen

Created: 2013-01-30 00:24:53 PST

Size: 3.97 KB

patch

obsolete

>Subversion Revision: 141034
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 652129841fa73692246167a9ddc9e9795e7cd1cc..77f4e2d920b5c84dc16e3e4ae30c5da66480b4cc 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2013-01-30  Tien-Ren Chen  <trchen@chromium.org>
>+
>+        Over-paint carets for 1 pixel to workaround rounding issue
>+        https://bugs.webkit.org/show_bug.cgi?id=108283
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Occasionally carets won't be fully erased when blinking.
>+        There used to be 1-pixel padding but removed since r139282.
>+        This patch adds back the same workaround.
>+
>+        Need to rebaseline test expectations.
>+
>+        * editing/FrameSelection.cpp:
>+        (WebCore::repaintCaretForLocalRect):
>+
> 2013-01-28  Tom Sepez  <tsepez@chromium.org>
> 
>         [v8] Security feature: JavaScript Bindings hardening
>diff --git a/Source/WebCore/editing/FrameSelection.cpp b/Source/WebCore/editing/FrameSelection.cpp
>index 13df169ced759e8f5bf0c9e47446b8f942db1bf3..ddea390380b34221198375ac0b65a9d42eaf987c 100644
>--- a/Source/WebCore/editing/FrameSelection.cpp
>+++ b/Source/WebCore/editing/FrameSelection.cpp
>@@ -1327,7 +1327,13 @@ static void repaintCaretForLocalRect(Node* node, const LayoutRect& rect)
>     if (!caretPainter)
>         return;
> 
>-    caretPainter->repaintRectangle(rect);
>+    // FIXME: Need to over-paint 1 pixel to workaround some rounding problem.
>+    // https://bugs.webkit.org/show_bug.cgi?id=108283
>+    // Can't reproduce http://webkit.org/b/19086 but probably the same root cause.
>+    LayoutRect inflatedRect = rect;
>+    inflatedRect.inflate(1);
>+
>+    caretPainter->repaintRectangle(inflatedRect);
> }
> 
> bool FrameSelection::recomputeCaretRect()
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 077df88179dc2aeac04af9a266d324ec3f6d37f8..d198579e0b9b0d066bb9dc2450c04a3d3c9caa83 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2013-01-30  Tien-Ren Chen  <trchen@chromium.org>
>+
>+        Over-paint carets for 1 pixel to workaround rounding issue
>+        https://bugs.webkit.org/show_bug.cgi?id=108283
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Occasionally carets won't be fully erased when blinking.
>+        There used to be 1-pixel padding but removed since r139282.
>+        This patch adds back the same workaround.
>+
>+        * platform/chromium/TestExpectations:
>+
> 2013-01-28  Michael Saboff  <msaboff@apple.com>
> 
>         Make integer-modulo.js a try JS-Regress test
>diff --git a/LayoutTests/platform/chromium/TestExpectations b/LayoutTests/platform/chromium/TestExpectations
>index e11f02d648f20a19ea3371f8f8b35c0e5f027bda..0e6437b3c22eda4fc94342d9a3846e763ae59d04 100644
>--- a/LayoutTests/platform/chromium/TestExpectations
>+++ b/LayoutTests/platform/chromium/TestExpectations
>@@ -4264,12 +4264,10 @@ webkit.org/b/106746 css3/filters/filter-property-parsing.html [ Failure ]
> webkit.org/b/108065 [ Debug ] tables/mozilla_expected_failures/bugs/bug2479-5.html [ Crash ]
> 
> # Transient. Needs rebaseline.
>-webkit.org/b/103955 fast/repaint/caret-outside-block.html [ ImageOnlyFailure ]
>-webkit.org/b/103955 [ Linux ] fast/repaint/japanese-rl-selection-repaint-in-regions.html [ ImageOnlyFailure ]
>-webkit.org/b/103955 [ Linux Lion SnowLeopard ] fast/repaint/japanese-rl-selection-repaint.html [ ImageOnlyFailure ]
>-webkit.org/b/103955 fast/repaint/repaint-across-writing-mode-boundary.html [ ImageOnlyFailure ]
>-webkit.org/b/103955 fast/repaint/selection-rl.html [ ImageOnlyFailure ]
>-webkit.org/b/103955 fast/repaint/caret-with-transformation.html [ Missing ]
>+webkit.org/b/108283 fast/repaint/4774354.html [ ImageOnlyFailure ]
>+webkit.org/b/108283 fast/repaint/4776765.html [ ImageOnlyFailure ]
>+webkit.org/b/108283 fast/repaint/caret-with-transformation.html [ ImageOnlyFailure ]
>+
> webkit.org/b/106609 [ Win ] animations/fill-mode-iteration-count-non-integer.html [ Failure ]
> 
> webkit.org/b/106689 canvas/philip/tests/2d.gradient.interpolate.overlap2.html [ Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 108283: 185375 | 185376 | 185377 | 185414 | 185442 | 185445