Attachment 184382 Details for Bug 107132 – Patch

[patch] Patch

bug-107132-20130123221740.patch (text/plain), 1.74 KB, created by Mark Pilgrim (Google) on 2013-01-23 19:20:48 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Pilgrim (Google)

Created: 2013-01-23 19:20:48 PST

Size: 1.74 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 140634)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
>+
>+        [Chromium] Give webkit_support a chance to reset state between layout test runs
>+        https://bugs.webkit.org/show_bug.cgi?id=107132
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We currently only have need for this on OS(ANDROID), but now it
>+        would be useful to have a hook for resetting state on all
>+        platforms. Will soon be using this for IDBFactory initialization.
>+
>+        * DumpRenderTree/chromium/TestShell.cpp:
>+        (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
>+
> 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
> 
>         [Chromium] Remove unused header files in chromium/public/platform/
>Index: Tools/DumpRenderTree/chromium/TestShell.cpp
>===================================================================
>--- Tools/DumpRenderTree/chromium/TestShell.cpp	(revision 140634)
>+++ Tools/DumpRenderTree/chromium/TestShell.cpp	(working copy)
>@@ -334,9 +334,6 @@ void TestShell::resetTestController()
> #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
>     m_notificationPresenter->reset();
> #endif
>-#if OS(ANDROID)
>-    webkit_support::ReleaseMediaResources();
>-#endif
>     m_drtDevToolsAgent->reset();
>     if (m_drtDevToolsClient)
>         m_drtDevToolsClient->reset();
>@@ -346,6 +343,8 @@ void TestShell::resetTestController()
>     webView()->mainFrame()->clearOpener();
>     WebTestingSupport::resetInternalsObject(webView()->mainFrame());
>     WebCache::clear();
>+
>+    webkit_support::ResetTestEnvironment();
> }
> 
> void TestShell::loadURL(const WebURL& url)

Actions: View | Formatted Diff | Diff

Attachments on bug 107132: 183195 | 184382