Attachment 183626 Details for Bug 107363 – patch

[patch] patch

107363.patch (text/plain), 1.72 KB, created by Sudarsana Nagineni (babu) on 2013-01-19 08:07:45 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Sudarsana Nagineni (babu)

Created: 2013-01-19 08:07:45 PST

Size: 1.72 KB

patch

obsolete

>diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
>index 0a8f992..f25729f 100644
>--- a/Source/WebKit2/ChangeLog
>+++ b/Source/WebKit2/ChangeLog
>@@ -1,3 +1,19 @@
>+2013-01-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
>+
>+        [EFL][WK2] Implement WebInspector::localizedStringsURL() on EFL
>+        https://bugs.webkit.org/show_bug.cgi?id=107363
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Implement WebInspector::localizedStringsURL() method to return the
>+        file URL of the localizedStrings.js.
>+
>+        This prevents printing warnings about "Localized string not found" in
>+        the console and fixes Web inspector related failing tests on the bots.
>+
>+        * WebProcess/WebPage/efl/WebInspectorEfl.cpp:
>+        (WebKit::WebInspector::localizedStringsURL):
>+
> 2013-01-17  Sam Weinig  <sam@webkit.org>
> 
>         Don't initialize AppKit for processes that don't use it
>diff --git a/Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp b/Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp
>index 755b426..20e12f2 100644
>--- a/Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp
>+++ b/Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp
>@@ -28,15 +28,19 @@
> 
> #if ENABLE(INSPECTOR)
> 
>-#include <WebCore/NotImplemented.h>
>-#include <wtf/text/WTFString.h>
>+#include <WebCore/EflInspectorUtilities.h>
>+#include <wtf/text/StringBuilder.h>
> 
> namespace WebKit {
> 
> String WebInspector::localizedStringsURL() const
> {
>-    notImplemented();
>-    return String();
>+    StringBuilder builder;
>+    builder.appendLiteral("file://");
>+    builder.append(WebCore::inspectorResourcePath());
>+    builder.appendLiteral("/localizedStrings.js");
>+
>+    return builder.toString();
> }
> 
> } // namespace WebKit

Flags:

benjamin: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 107363: 183623 | 183626 | 183841