Attachment 182724 Details for Bug 106864 – Patch

[patch] Patch

bug-106864-20130115191620.patch (text/plain), 5.49 KB, created by Eunmi Lee on 2013-01-15 02:19:21 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Eunmi Lee

Created: 2013-01-15 02:19:21 PST

Size: 5.49 KB

patch

obsolete

>Subversion Revision: 139587
>diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
>index 74395d1ede33b76834876b887ce96f06e180a0df..8beb12c3957ebf1ca2987d7761f1ced527f2f7a4 100644
>--- a/Source/WebKit2/ChangeLog
>+++ b/Source/WebKit2/ChangeLog
>@@ -1,5 +1,25 @@
> 2013-01-14  Eunmi Lee  <eunmi15.lee@samsung.com>
> 
>+        [EFL][WK2] Process single tap using WebEvent::GestureSingleTap.
>+        https://bugs.webkit.org/show_bug.cgi?id=106864
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Send WebEvent::GestureSingleTap event to the web process to perform
>+        the click when single tap gesture is recognized.
>+
>+        * UIProcess/efl/PageClientBase.cpp:
>+        (WebKit):
>+        (WebKit::PageClientBase::doneWithGestureEvent):
>+        * UIProcess/efl/PageClientBase.h:
>+        (PageClientBase):
>+        * UIProcess/efl/TapGestureHandler.cpp:
>+        (WebKit::TapGestureHandler::processSingleTap):
>+        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
>+        (WebKit::NetscapePlugin::platformHandleMouseEvent):
>+
>+2013-01-14  Eunmi Lee  <eunmi15.lee@samsung.com>
>+
>         [EFL][WK2] Implement gesture recognizer.
>         https://bugs.webkit.org/show_bug.cgi?id=102643
> 
>diff --git a/Source/WebKit2/UIProcess/efl/PageClientBase.cpp b/Source/WebKit2/UIProcess/efl/PageClientBase.cpp
>index 1df03117fbf205b6d4e361506d3f99c470f8c309..2bf05d8722bf1b69ab5a3aa06790221205421993 100644
>--- a/Source/WebKit2/UIProcess/efl/PageClientBase.cpp
>+++ b/Source/WebKit2/UIProcess/efl/PageClientBase.cpp
>@@ -209,6 +209,13 @@ void PageClientBase::doneWithKeyEvent(const NativeWebKeyboardEvent&, bool)
>     notImplemented();
> }
> 
>+#if ENABLE(GESTURE_EVENTS)
>+void PageClientBase::doneWithGestureEvent(const WebGestureEvent&, bool)
>+{
>+    notImplemented();
>+}
>+#endif
>+
> #if ENABLE(TOUCH_EVENTS)
> void PageClientBase::doneWithTouchEvent(const NativeWebTouchEvent& event, bool wasEventHandled)
> {
>diff --git a/Source/WebKit2/UIProcess/efl/PageClientBase.h b/Source/WebKit2/UIProcess/efl/PageClientBase.h
>index 970d7afa9c1103074652fea3a1c42d5bf7f00dfb..b8773cc990774346a64e0e6d89e9c519320210b8 100644
>--- a/Source/WebKit2/UIProcess/efl/PageClientBase.h
>+++ b/Source/WebKit2/UIProcess/efl/PageClientBase.h
>@@ -82,6 +82,9 @@ protected:
>     virtual void handleDownloadRequest(DownloadProxy*);
> 
>     virtual void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool);
>+#if ENABLE(GESTURE_EVENTS)
>+    virtual void doneWithGestureEvent(const WebGestureEvent&, bool wasEventHandled);
>+#endif
> #if ENABLE(TOUCH_EVENTS)
>     virtual void doneWithTouchEvent(const NativeWebTouchEvent&, bool wasEventHandled);
> #endif
>diff --git a/Source/WebKit2/UIProcess/efl/TapGestureHandler.cpp b/Source/WebKit2/UIProcess/efl/TapGestureHandler.cpp
>index 35f2d7961b0393e55214415e06da3c6d776c5e38..e4cfb21500882ccb9f78e8212f51326a0d93ca82 100644
>--- a/Source/WebKit2/UIProcess/efl/TapGestureHandler.cpp
>+++ b/Source/WebKit2/UIProcess/efl/TapGestureHandler.cpp
>@@ -30,6 +30,13 @@
> 
> #include <WebCore/NotImplemented.h>
> 
>+#if ENABLE(GESTURE_EVENTS)
>+#include "EwkViewImpl.h"
>+#include "WebEvent.h"
>+#include "WebPageProxy.h"
>+#include <WebCore/AffineTransform.h>
>+#endif
>+
> using namespace WebCore;
> 
> namespace WebKit {
>@@ -113,7 +120,11 @@ void TapGestureHandler::cancel()
> 
> void TapGestureHandler::processSingleTap()
> {
>-    notImplemented();
>+#if ENABLE(GESTURE_EVENTS)
>+    IntPoint position = m_viewImpl->transformFromScene().mapPoint(m_viewImpl->transformToScreen().inverse().mapPoint(m_firstPressedPoint));
>+    WebGestureEvent gesture(WebEvent::GestureSingleTap, position, m_firstPressedPoint, WebEvent::Modifiers(0), ecore_time_get());
>+    m_viewImpl->page()->handleGestureEvent(gesture);
>+#endif
> }
> 
> void TapGestureHandler::processDoubleTap()
>diff --git a/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp b/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
>index 30a0e86cdb1cead117217ddecfa866529238c396..079b73a7fb9c9a4c881ff462643142b89ae4e90d 100644
>--- a/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
>+++ b/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
>@@ -529,6 +529,7 @@ bool NetscapePlugin::platformHandleMouseEvent(const WebMouseEvent& event)
> #if ENABLE(GESTURE_EVENTS)
>     case WebEvent::GestureScrollBegin:
>     case WebEvent::GestureScrollEnd:
>+    case WebEvent::GestureSingleTap:
> #endif
> #if ENABLE(TOUCH_EVENTS)
>     case WebEvent::TouchStart:
>diff --git a/Source/cmake/OptionsEfl.cmake b/Source/cmake/OptionsEfl.cmake
>index d36a904c3d601c5090d75d54d941c24f7d36449f..3573101d6dbb7151435e7528f9ca2a58fb861c17 100644
>--- a/Source/cmake/OptionsEfl.cmake
>+++ b/Source/cmake/OptionsEfl.cmake
>@@ -252,3 +252,7 @@ if (ENABLE_ACCESSIBILITY)
> else ()
>     add_definitions(-DHAVE_ACCESSIBILITY=0)
> endif ()
>+
>+if (ENABLE_WEBKIT2 AND WTF_USE_TILED_BACKING_STORE)
>+    add_definitions(-DENABLE_GESTURE_EVENTS=1)
>+endif ()
>diff --git a/ChangeLog b/ChangeLog
>index f7994e75838997af838d24ddd8af06ed6a41857f..d9850b83285811c93d1a634b9de2cacc633d04e4 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,15 @@
>+2013-01-14  Eunmi Lee  <eunmi15.lee@samsung.com>
>+
>+        [EFL][WK2] Process single tap using WebEvent::GestureSingleTap.
>+        https://bugs.webkit.org/show_bug.cgi?id=106864
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Enable GESTURE_EVENTS to use WebEvent::GestureSingleTap when WEBKIT2
>+        and TILED_BACKING_STORE are enabled.
>+
>+        * Source/cmake/OptionsEfl.cmake:
>+
> 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Update NEWS and configure.ac for 1.11.4 release

Actions: View | Formatted Diff | Diff

Attachments on bug 106864: 182692 | 182724 | 191411 | 191646 | 193495 | 193775 | 206055 | 207625 | 208250 | 214552