Attachment 181924 Details for Bug 106457 – Patch

[patch] Patch

bug-106457-20130109103358.patch (text/plain), 2.66 KB, created by Mark Pilgrim (Google) on 2013-01-09 07:37:58 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Pilgrim (Google)

Created: 2013-01-09 07:37:58 PST

Size: 2.66 KB

patch

obsolete

>Index: Source/WebKit/chromium/ChangeLog
>===================================================================
>--- Source/WebKit/chromium/ChangeLog	(revision 139192)
>+++ Source/WebKit/chromium/ChangeLog	(working copy)
>@@ -1,3 +1,22 @@
>+2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
>+
>+        [Chromium] Remove idbFactory from WebKitPlatformSupport
>+        https://bugs.webkit.org/show_bug.cgi?id=106457
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Now that https://codereview.chromium.org/11773005/ and
>+        https://codereview.chromium.org/11817004/ have landed downstream,
>+        the idbFactory method is no longer used. (Embedders must now call
>+        the new setIDBFactory method upon initialization.) Part of a refactoring
>+        series; see tracking bug 82948.
>+
>+        * public/platform/WebKitPlatformSupport.h:
>+        (WebKit):
>+        (WebKitPlatformSupport):
>+        * src/IDBFactoryBackendProxy.cpp:
>+        (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
>+
> 2013-01-09  Mikhail Naganov  <mnaganov@chromium.org>
> 
>         [Chromium] Unreviewed: A trivial fix for WebFrameTest.DivAutoZoomParamsTest after r139177.
>Index: Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
>===================================================================
>--- Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	(revision 139192)
>+++ Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	(working copy)
>@@ -35,15 +35,8 @@
> 
> namespace WebKit {
> 
>-class WebIDBFactory; // FIXME: Does this belong in platform?
>-
>-// FIXME: Eventually all these API will need to move to WebKit::Platform.
> class WebKitPlatformSupport : public Platform {
> public:
>-    // Indexed Database ----------------------------------------------------
>-
>-    virtual WebIDBFactory* idbFactory() { return 0; }
>-
> protected:
>     ~WebKitPlatformSupport() { }
> };
>Index: Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp
>===================================================================
>--- Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	(revision 139192)
>+++ Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	(working copy)
>@@ -53,7 +53,6 @@
> #include "WorkerLoaderProxy.h"
> #include "WorkerScriptController.h"
> #include "WorkerThread.h"
>-#include "platform/WebKitPlatformSupport.h"
> #include <public/WebVector.h>
> 
> 
>@@ -75,10 +74,7 @@ PassRefPtr<IDBFactoryBackendInterface> I
> 
> IDBFactoryBackendProxy::IDBFactoryBackendProxy()
> {
>-    if (s_webIDBFactory)
>-        m_webIDBFactory = s_webIDBFactory;
>-    else
>-        m_webIDBFactory = webKitPlatformSupport()->idbFactory();
>+    m_webIDBFactory = s_webIDBFactory;
> }
> 
> IDBFactoryBackendProxy::~IDBFactoryBackendProxy()

Actions: View | Formatted Diff | Diff

Attachments on bug 106457: 181924 | 182052 | 182228 | 186642 | 189141