Attachment 181888 Details for Bug 106436 – Patch

[patch] Patch

bug-106436-20130109192746.patch (text/plain), 2.52 KB, created by Halton Huo on 2013-01-09 03:27:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Halton Huo

Created: 2013-01-09 03:27:33 PST

Size: 2.52 KB

patch

obsolete

>Subversion Revision: 139163
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a27825d76c167e66555cc3737b82ed2f4e2e24e0..7cac427f8eaf5b57f6bdc44839a90adc61a7ec3f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2013-01-09  Halton Huo  <halton.huo@intel.com>
>+
>+        [GTK] Volume button should not be shown for videos without audio
>+        https://bugs.webkit.org/show_bug.cgi?id=106436
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The volume control is no longer shown for videos with no audio.
>+
>+        No new tests, tested by media/video-no-audio.html.
>+
>+        * platform/gtk/RenderThemeGtk.cpp:
>+        (WebCore::RenderThemeGtk::hasOwnDisabledStateHandlingFor):
>+        (WebCore):
>+        * platform/gtk/RenderThemeGtk.h:
>+
> 2013-01-08  Tony Gentilcore  <tonyg@chromium.org>
> 
>         Remove a few unused includes from HTMLTreeBuilder
>diff --git a/Source/WebCore/platform/gtk/RenderThemeGtk.cpp b/Source/WebCore/platform/gtk/RenderThemeGtk.cpp
>index 00aea2564f44b4e70aeb7b0273732baf3b56e338..81eb5aa94cc4b8c62d1bcca23dd1ec6a34da7087 100644
>--- a/Source/WebCore/platform/gtk/RenderThemeGtk.cpp
>+++ b/Source/WebCore/platform/gtk/RenderThemeGtk.cpp
>@@ -513,6 +513,11 @@ bool RenderThemeGtk::paintMediaButton(RenderObject* renderObject, GraphicsContex
>     return false;
> }
> 
>+bool RenderThemeGtk::hasOwnDisabledStateHandlingFor(ControlPart part) const
>+{
>+    return (part != MediaMuteButtonPart);
>+}
>+
> bool RenderThemeGtk::paintMediaFullscreenButton(RenderObject* renderObject, const PaintInfo& paintInfo, const IntRect& rect)
> {
>     return paintMediaButton(renderObject, paintInfo.context, rect, GTK_STOCK_FULLSCREEN);
>diff --git a/Source/WebCore/platform/gtk/RenderThemeGtk.h b/Source/WebCore/platform/gtk/RenderThemeGtk.h
>index f54588c1efe883785ea8ce38208363285e0f5070..85645f4fef3a81806d7991674327fe32d6059e71 100644
>--- a/Source/WebCore/platform/gtk/RenderThemeGtk.h
>+++ b/Source/WebCore/platform/gtk/RenderThemeGtk.h
>@@ -162,7 +162,7 @@ protected:
>     void initMediaColors();
>     void initMediaButtons();
>     void adjustMediaSliderThumbSize(RenderStyle*) const;
>-    virtual bool hasOwnDisabledStateHandlingFor(ControlPart) const { return true; }
>+    virtual bool hasOwnDisabledStateHandlingFor(ControlPart) const;
>     virtual bool paintMediaFullscreenButton(RenderObject*, const PaintInfo&, const IntRect&);
>     virtual bool paintMediaPlayButton(RenderObject*, const PaintInfo&, const IntRect&);
>     virtual bool paintMediaMuteButton(RenderObject*, const PaintInfo&, const IntRect&);

Actions: View | Formatted Diff | Diff

Attachments on bug 106436: 181888