Attachment 180292 Details for Bug 105505 – ROLLOUT of r138215

[patch] ROLLOUT of r138215

bug-105505-20121220091203.patch (text/plain), 3.13 KB, created by WebKit Review Bot on 2012-12-20 01:05:36 PST

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Review Bot

Created: 2012-12-20 01:05:36 PST

Size: 3.13 KB

patch

obsolete

>Subversion Revision: 138232
>diff --git a/Source/WebKit/chromium/ChangeLog b/Source/WebKit/chromium/ChangeLog
>index 6df282485393d759fdd15771cda153dfb5d3ae2b..1b029b554b04f0797da1a221b5f08a5e1efe7e75 100644
>--- a/Source/WebKit/chromium/ChangeLog
>+++ b/Source/WebKit/chromium/ChangeLog
>@@ -1,3 +1,20 @@
>+2012-12-20  Sheriff Bot  <webkit.review.bot@gmail.com>
>+
>+        Unreviewed, rolling out r138215.
>+        http://trac.webkit.org/changeset/138215
>+        https://bugs.webkit.org/show_bug.cgi?id=105505
>+
>+        it broke downstream compilation with clang (Requested by
>+        loislo on #webkit).
>+
>+        * public/platform/WebKitPlatformSupport.h:
>+        (WebKit):
>+        (WebKitPlatformSupport):
>+        (WebKit::WebKitPlatformSupport::sharedWorkerRepository):
>+        * src/SharedWorkerRepository.cpp:
>+        (WebKit::sharedWorkerRepository):
>+        (WebCore::SharedWorkerRepository::isAvailable):
>+
> 2012-12-19  Mark Pilgrim  <pilgrim@chromium.org>
> 
>         [Chromium] Remove idbFactory from PlatformSupport
>diff --git a/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h b/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
>index b6245b934e9465105d8091b938393072d2df1b34..05199e3adec1d4ee82dd7fe8dced537ecb6d9a16 100644
>--- a/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
>+++ b/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
>@@ -36,6 +36,7 @@
> namespace WebKit {
> 
> class WebIDBFactory; // FIXME: Does this belong in platform?
>+class WebSharedWorkerRepository; // FIXME: Does this belong in platform?
> 
> // FIXME: Eventually all these API will need to move to WebKit::Platform.
> class WebKitPlatformSupport : public Platform {
>@@ -44,6 +45,11 @@ public:
> 
>     virtual WebIDBFactory* idbFactory() { return 0; }
> 
>+
>+    // Shared Workers ------------------------------------------------------
>+
>+    virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; }
>+
> protected:
>     ~WebKitPlatformSupport() { }
> };
>diff --git a/Source/WebKit/chromium/src/SharedWorkerRepository.cpp b/Source/WebKit/chromium/src/SharedWorkerRepository.cpp
>index 844b9056fe3260a5c3c1260b8820f9fe70e2941d..da019b42e472c3f8195e5d39ece121a4ab2be8a4 100644
>--- a/Source/WebKit/chromium/src/SharedWorkerRepository.cpp
>+++ b/Source/WebKit/chromium/src/SharedWorkerRepository.cpp
>@@ -69,8 +69,15 @@ void setSharedWorkerRepository(WebSharedWorkerRepository* repository)
> 
> static WebSharedWorkerRepository* sharedWorkerRepository()
> {
>-    // Will only be non-zero if the embedder has set the shared worker repository upon initialization. Nothing in WebKit sets this.
>-    return s_sharedWorkerRepository;
>+    WebSharedWorkerRepository* repository;
>+
>+    repository = s_sharedWorkerRepository;
>+    if (!repository) {
>+        repository = webKitPlatformSupport()->sharedWorkerRepository();
>+        setSharedWorkerRepository(repository);
>+    }
>+
>+    return repository;
> }
> 
> }
>@@ -211,6 +218,8 @@ void SharedWorkerScriptLoader::connected()
> 
> bool SharedWorkerRepository::isAvailable()
> {
>+    // Allow the WebKitPlatformSupport to determine if SharedWorkers
>+    // are available.
>     return WebKit::sharedWorkerRepository();
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 105505: 180292