Attachment 179300 Details for Bug 98352 – Patch

[patch] Patch

bug-98352-20121213192951.patch (text/plain), 3.21 KB, created by Joanmarie Diggs on 2012-12-13 10:32:31 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joanmarie Diggs

Created: 2012-12-13 10:32:31 PST

Size: 3.21 KB

patch

obsolete

>Subversion Revision: 137458
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index d3ee8ca749319534fede99a7295b9249649704c7..49ce14c50ea2fbc97b54efe1ce45364ae2436bdc 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,20 @@
>+2012-12-13  Joanmarie Diggs  <jdiggs@igalia.com>
>+
>+        [GTK] accessibiltiy/aria-hidden.html is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=98352
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The test is failing due to platform differences in the implementation of
>+        AccessibilityUIElement::allAttributes(). This test does not require this
>+        method as it is only looking at the AXTitle attribute.
>+
>+        * accessibility/aria-hidden-expected.txt: Included the actual reason for
>+        passing/failing in the results output.
>+        * accessibility/aria-hidden.html: Included the actual reason for passing/
>+        failing in the results output.
>+        * platform/gtk/TestExpectations: Unskipped the failing test.
>+
> 2012-12-12  Yury Semikhatsky  <yurys@chromium.org>
> 
>         Unreviewed. Marked inspector-protocol/take-heap-snapshot.html as CRASH only in Debug mode, it passes in Release.
>diff --git a/LayoutTests/accessibility/aria-hidden-expected.txt b/LayoutTests/accessibility/aria-hidden-expected.txt
>index d35734697256da02dcd8fe6abaeedfa8ceb412bd..7134f49cc4a5a197d462585f393c5b3c4d91dc92 100644
>--- a/LayoutTests/accessibility/aria-hidden-expected.txt
>+++ b/LayoutTests/accessibility/aria-hidden-expected.txt
>@@ -7,7 +7,7 @@ This tests that the aria-hidden attribute works correctly with accessibility. Th
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> 
> 
>-PASS succeeded is true
>+PASS h2.title is 'AXTitle: h2'
> PASS successfullyParsed is true
> 
> TEST COMPLETE
>diff --git a/LayoutTests/accessibility/aria-hidden.html b/LayoutTests/accessibility/aria-hidden.html
>index 4b51f6aa536b1846b15d165fbae7c3b39080ffc7..85139095f7c1abc4a6c4cc33a3dd88285d4c3006 100644
>--- a/LayoutTests/accessibility/aria-hidden.html
>+++ b/LayoutTests/accessibility/aria-hidden.html
>@@ -18,9 +18,7 @@
>           var body = document.getElementById("body");
>           body.focus();
>           var h2 = accessibilityController.focusedElement.childAtIndex(0);
>-          var pattern = "AXTitle: h2";
>-          var succeeded = h2.allAttributes().indexOf(pattern) != -1;
>-          shouldBe("succeeded", "true");
>+          shouldBe("h2.title", "'AXTitle: h2'");
>     }
> 
> </script>
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index cbb4c898dcb53a89c37fee1fe5980e98da78dd36..500d66b4e2f4216c37bd2b7ac3ec4ced260650c8 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -754,7 +754,6 @@ webkit.org/b/73766 css3/unicode-bidi-isolate-aharon-failing.html [ ImageOnlyFail
> 
> webkit.org/b/79757 fast/selectors/selection-window-inactive.html [ ImageOnlyFailure ]
> 
>-webkit.org/b/98352 accessibility/aria-hidden.html [ Failure ]
> webkit.org/b/98353 accessibility/aria-hidden-with-elements.html [ Failure ]
> webkit.org/b/98354 accessibility/aria-labelledby-overrides-label.html [ Failure ]
> webkit.org/b/98355 accessibility/aria-link-supports-press.html [ Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 98352: 179300