Attachment 177991 Details for Bug 104251 – ROLLOUT of r136825

[patch] ROLLOUT of r136825

bug-104251-20121206121433.patch (text/plain), 1.63 KB, created by WebKit Review Bot on 2012-12-06 04:08:17 PST

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Review Bot

Created: 2012-12-06 04:08:17 PST

Size: 1.63 KB

patch

obsolete

>Subversion Revision: 136829
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index a598fd2b70f710e5931ab1d3c3f0509193808f20..66be30f8587e4a5ee79a4466eceac5a4cc7a0807 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
>+
>+        Unreviewed, rolling out r136825.
>+        http://trac.webkit.org/changeset/136825
>+        https://bugs.webkit.org/show_bug.cgi?id=104251
>+
>+        It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
>+        flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).
>+
>+        * WebKitTestRunner/TestController.cpp:
>+        (WTR::TestController::resetStateToConsistentValues):
>+
> 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
> 
>         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
>diff --git a/Tools/WebKitTestRunner/TestController.cpp b/Tools/WebKitTestRunner/TestController.cpp
>index c5bf5538ed8ddeee7b776bf170ff77dcddf13b54..0e47f3c240578a491f8ec435fc4c6c5ef852c7b0 100644
>--- a/Tools/WebKitTestRunner/TestController.cpp
>+++ b/Tools/WebKitTestRunner/TestController.cpp
>@@ -564,10 +564,6 @@ bool TestController::resetStateToConsistentValues()
>     // Re-set to the default backing scale factor by setting the custom scale factor to 0.
>     WKPageSetCustomBackingScaleFactor(m_mainWebView->page(), 0);
> 
>-    // Resize the window to original size. This is needed after calls to window.resizeTo.
>-    WKRect rect = m_mainWebView->windowFrame();
>-    m_mainWebView->setWindowFrame(WKRectMake(rect.origin.x, rect.origin.y, 800, 600));
>-
>     // Reset notification permissions
>     m_webNotificationProvider.reset();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 104251: 177991