Attachment 176009 Details for Bug 95969 – Patch

[patch] Patch

bug-95969-20121126184136.patch (text/plain), 6.31 KB, created by Thiago Marcos P. Santos on 2012-11-26 08:39:45 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Thiago Marcos P. Santos

Created: 2012-11-26 08:39:45 PST

Size: 6.31 KB

patch

obsolete

>Subversion Revision: 135711
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 3cc9c7807c0ad5b840d4d26a21f5ce8e1bd69aec..bb0bbad7c5220a5f18b59e30c75a6fe06262d064 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2012-11-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
>+
>+        [Qt] Enable CSS Device Adaptation
>+        https://bugs.webkit.org/show_bug.cgi?id=95969
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Enable CSS Device Adaptation by default.
>+
>+        * Scripts/webkitperl/FeatureList.pm:
>+        * qmake/mkspecs/features/features.pri:
>+
> 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
> 
>         Text Autosizing: Add Text Autosizing APIs for WK2
>diff --git a/Tools/Scripts/webkitperl/FeatureList.pm b/Tools/Scripts/webkitperl/FeatureList.pm
>index f5d02675cd20528035f7608eb7deaaa9cf8ebddf..ef7e432968ac00ca704c4f088d83e0c3eabae989 100644
>--- a/Tools/Scripts/webkitperl/FeatureList.pm
>+++ b/Tools/Scripts/webkitperl/FeatureList.pm
>@@ -169,7 +169,7 @@ my @features = (
>       define => "ENABLE_CSP_NEXT", default => 0, value => \$cspNextSupport },
> 
>     { option => "css-device-adaptation", desc => "Toggle CSS Device Adaptation support",
>-      define => "ENABLE_CSS_DEVICE_ADAPTATION", default => isEfl(), value => \$cssDeviceAdaptation },
>+      define => "ENABLE_CSS_DEVICE_ADAPTATION", default => isEfl() || isQt(), value => \$cssDeviceAdaptation },
> 
>     { option => "css-exclusions", desc => "Toggle CSS Exclusions support",
>       define => "ENABLE_CSS_EXCLUSIONS", default => 1, value => \$cssExclusionsSupport },
>diff --git a/Tools/qmake/mkspecs/features/features.pri b/Tools/qmake/mkspecs/features/features.pri
>index c3688922b7fd92e19c71522ec18d11abcca32503..aedc7d81d4ce493b7ba1a3e1629ef6945f8f628e 100644
>--- a/Tools/qmake/mkspecs/features/features.pri
>+++ b/Tools/qmake/mkspecs/features/features.pri
>@@ -22,6 +22,7 @@ FEATURE_DEFAULTS = \
>     ENABLE_CSP_NEXT=0 \
>     ENABLE_CSS_BOX_DECORATION_BREAK=1 \
>     ENABLE_CSS_COMPOSITING=1 \
>+    ENABLE_CSS_DEVICE_ADAPTATION=1 \
>     ENABLE_CSS_EXCLUSIONS=1 \
>     ENABLE_CSS_FILTERS=1 \
>     ENABLE_CSS_GRID_LAYOUT=0 \
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ebfb8dd5879b0c6ba5235a152969825dc0059bb1..9ecd73dbe7a6e1a789323fa1d028ee948448680b 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,5 +1,20 @@
> 2012-11-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
> 
>+        [Qt] Enable CSS Device Adaptation
>+        https://bugs.webkit.org/show_bug.cgi?id=95969
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Unskip tests that will now pass on WK2. We cannot do the same for
>+        WebKit1 because DRT doesn't support fixed layout.
>+
>+        * platform/qt-4.8/TestExpectations:
>+        * platform/qt-5.0-wk1/TestExpectations:
>+        * platform/qt-5.0-wk2/TestExpectations:
>+        * platform/qt/TestExpectations:
>+
>+2012-11-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
>+
>         Import more CSS Device Adaptation layout tests
>         https://bugs.webkit.org/show_bug.cgi?id=95967
> 
>diff --git a/LayoutTests/platform/qt-4.8/TestExpectations b/LayoutTests/platform/qt-4.8/TestExpectations
>index e0b29757c86c45ca3a8bbe1ed7aec5a11b1eb3a8..5697bf953c5e6ed1c0cf14a5ae3a3a7ed76f91a4 100644
>--- a/LayoutTests/platform/qt-4.8/TestExpectations
>+++ b/LayoutTests/platform/qt-4.8/TestExpectations
>@@ -693,6 +693,9 @@ webkit.org/b/6033 css3/filters/regions-expanding.html [ ImageOnlyFailure Pass ]
> webkit.org/b/6033 css3/filters/simple-filter-rendering.html [ ImageOnlyFailure Pass ]
> webkit.org/b/6033 svg/filters/color-interpolation-filters.svg [ Missing Pass ]
> 
>+# Fixed layout not supported by DRT.
>+css3/device-adapt
>+
> # CSS shaders only work in qt-wk2
> css3/filters/custom
> 
>diff --git a/LayoutTests/platform/qt-5.0-wk1/TestExpectations b/LayoutTests/platform/qt-5.0-wk1/TestExpectations
>index dd977d56ae938d34057782cb296fc4934d309e46..2a511baaecd3979780809545b92b13e70ac2a51e 100644
>--- a/LayoutTests/platform/qt-5.0-wk1/TestExpectations
>+++ b/LayoutTests/platform/qt-5.0-wk1/TestExpectations
>@@ -31,6 +31,9 @@ fast/dom/Window/mozilla-focus-blur.html
> # https://bugs.webkit.org/show_bug.cgi?id=77380
> fast/url/path.html
> 
>+# Fixed layout not supported by DRT.
>+css3/device-adapt
>+
> # [Qt] Tests still fail after the update to new fonts
> # https://bugs.webkit.org/show_bug.cgi?id=91610
> css3/calc/table-calcs.html
>diff --git a/LayoutTests/platform/qt-5.0-wk2/TestExpectations b/LayoutTests/platform/qt-5.0-wk2/TestExpectations
>index 707a064e8f503dd671dd269c28edb8f28c83af1e..cb3a7dcaf7f7ceea299ccfe05ef9e03a2273b83c 100644
>--- a/LayoutTests/platform/qt-5.0-wk2/TestExpectations
>+++ b/LayoutTests/platform/qt-5.0-wk2/TestExpectations
>@@ -640,6 +640,17 @@ webkit.org/b/84893 http/tests/w3c/webperf/submission/Intel/user-timing
> # Resource Timing is not enable yet, skip it.
> webkit.org/b/61138 http/tests/w3c/webperf/submission/Intel/resource-timing
> 
>+# Window size is being reported as screen size.
>+webkit.org/b/103127 css3/device-adapt/opera/constrain-021.xhtml [ Failure ]
>+webkit.org/b/103127 css3/device-adapt/opera/constrain-022.xhtml [ Failure ]
>+
>+# Issue with viewport width and relative units.
>+webkit.org/b/102922 css3/device-adapt/opera/constrain-006.xhtml [ Failure ]
>+webkit.org/b/102922 css3/device-adapt/opera/constrain-007.xhtml [ Failure ]
>+
>+# Page client doesn't react to orientation changes from CSS Viewport rules.
>+css3/device-adapt/opera/orientation-001.xhtml [ Failure ]
>+
> # [Qt] Unidentified pixel failures
> webkit.org/b/99306 animations/3d/state-at-end-event-transform.html [ ImageOnlyFailure ]
> webkit.org/b/99306 animations/additive-transform-animations.html [ ImageOnlyFailure ]
>diff --git a/LayoutTests/platform/qt/TestExpectations b/LayoutTests/platform/qt/TestExpectations
>index 97087534f15895efd3732a72b39354ae2890ab7c..d1c7150b5556367e846035acaa07d698162da1b2 100644
>--- a/LayoutTests/platform/qt/TestExpectations
>+++ b/LayoutTests/platform/qt/TestExpectations
>@@ -2320,9 +2320,6 @@ webkit.org/b/23166 ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.h
> # css3-conditionals support is not yet enabled.
> webkit.org/b/86146 css3/supports.html
> 
>-# CSS Device Adaptation is not enabled.
>-webkit.org/b/95969 css3/device-adapt [ Skip ]
>-
> # Added by bug 89826
> webkit.org/b/94005 css2.1/20110323/word-spacing-remove-space-003.htm [ ImageOnlyFailure ]
> webkit.org/b/94005 css2.1/20110323/word-spacing-remove-space-006.htm [ ImageOnlyFailure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 95969: 176009