Attachment 173540 Details for Bug 96614 – Patch

[patch] Patch

bug-96614-20121112113134.patch (text/plain), 1.69 KB, created by Charles Wei on 2012-11-11 19:33:32 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Charles Wei

Created: 2012-11-11 19:33:32 PST

Size: 1.69 KB

patch

obsolete

>Subversion Revision: 134183
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 836d97e24dcfe0caa0ecd91bae11068340768cdc..9410d2238a16a999ba6bcf9808f08c3c083afbae 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2012-11-11  Charles Wei  <charles.wei@torchmobile.com.cn>
>+
>+        Need to clear exception in JSDictionary for operations that might have.
>+        https://bugs.webkit.org/show_bug.cgi?id=96614
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We need to clear any exceptions before querying the JSDictionary to avoid the
>+        interference of last query which might leave the ExecState of JSDictionary in
>+        Exception state. 
>+
>+        The existing test case LayoutTest/storage/indexeddb/tutorial.html should work
>+        with this patch for JSC binding.
>+
>+        * bindings/js/JSDictionary.cpp:
>+        (WebCore::JSDictionary::tryGetProperty):
>+
> 2012-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
> 
>         Unreviewed, rolling out r134144.
>diff --git a/Source/WebCore/bindings/js/JSDictionary.cpp b/Source/WebCore/bindings/js/JSDictionary.cpp
>index f476d7268e2a73d3d43d0a7fffd6041907c5af01..fb8014fd374d639f3172c250c8b46fa7f2f13872 100644
>--- a/Source/WebCore/bindings/js/JSDictionary.cpp
>+++ b/Source/WebCore/bindings/js/JSDictionary.cpp
>@@ -52,6 +52,9 @@ namespace WebCore {
> JSDictionary::GetPropertyResult JSDictionary::tryGetProperty(const char* propertyName, JSValue& finalResult) const
> {
>     ASSERT(isValid());
>+    if (m_exec->hadException()) // Clear exceptions, if any, left by last query.
>+        m_exec->clearException();
>+
>     Identifier identifier(m_exec, propertyName);
>     PropertySlot slot(m_initializerObject.get());
>

Flags:

sam: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 96614: 163809 | 164065 | 173253 | 173261 | 173304 | 173306 | 173540 | 177806 | 177865 | 177906 | 177907 | 178728 | 179040 | 179158 | 179326 | 179456