Attachment 172586 Details for Bug 101349 – Patch

[patch] Patch

bug-101349-20121106124032.patch (text/plain), 1.83 KB, created by Thiago Santos on 2012-11-06 07:42:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Thiago Santos

Created: 2012-11-06 07:42:20 PST

Size: 1.83 KB

patch

obsolete

>Subversion Revision: 133064
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a4e87e6936c0caaa1dea9bd7de1440ec5abc269e..9964228d0140d2d4522b6edb1b53e0ecab6aec48 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2012-11-06  Thiago Santos  <thiago.sousa.santos@collabora.com>
>+
>+        GStreamer reference handling fix: fix the reference handling for GstPadTemplate creation to avoid an assertion about floating refs
>+        https://bugs.webkit.org/show_bug.cgi?id=101349
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The reference returned by the gst_pad_template_new function is floating, it needs to be reffed before it can be adopted by the GRef smart pointer object.
>+
>+        No new tests (OOPS!).
>+
>+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
>+        (webkit_web_src_init):
>+
> 2012-10-31  Simon Fraser  <simon.fraser@apple.com>
> 
>         REGRESSION (tile cache layers): bits of tiled layers are missing with certain 3D transforms
>diff --git a/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
>index aebb3a732de6ebfc756316c457f9f4880ddb4635..6527d00f9aff56550ded0077485920d0a1847d3a 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
>@@ -217,7 +217,7 @@ static void webkit_web_src_class_init(WebKitWebSrcClass* klass)
> 
> static void webkit_web_src_init(WebKitWebSrc* src)
> {
>-    GRefPtr<GstPadTemplate> padTemplate = adoptGRef(gst_static_pad_template_get(&srcTemplate));
>+    GRefPtr<GstPadTemplate> padTemplate = adoptGRef(WTF::refGPtr(gst_static_pad_template_get(&srcTemplate)));
>     WebKitWebSrcPrivate* priv = WEBKIT_WEB_SRC_GET_PRIVATE(src);
> 
>     src->priv = priv;

Actions: View | Formatted Diff | Diff

Attachments on bug 101349: 172586 | 174439 | 175872 | 175880 | 175882