Attachment 172534 Details for Bug 101215 – fix checkSpellingOfString in TextCheckerEnchant class

[patch] fix checkSpellingOfString in TextCheckerEnchant class

spelling-checkSpellingOfString_Fix.patch (text/plain), 1.67 KB, created by Grzegorz Czajkowski on 2012-11-06 02:48:31 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Grzegorz Czajkowski

Created: 2012-11-06 02:48:31 PST

Size: 1.67 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2b60621..7557ed9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2012-11-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
>+
>+        [WK2][EFL][GTK] early return of checkSpellingOfString treats correct words as misspelled
>+        https://bugs.webkit.org/show_bug.cgi?id=101215
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Save the misspelled location and length of the string to the default values (-1, 0)
>+        at the beginning of the checkSpellingOfString method.
>+        It assumes that the words are spelled correctly and early return of method doesn't
>+        cause assertions in findFirstMisspelling (WebCore/editing/TextCheckingHelper.cpp).
>+
>+        * platform/text/enchant/TextCheckerEnchant.cpp:
>+        (TextCheckerEnchant::checkSpellingOfString):
>+
> 2012-10-29  Alexander Pavlov  <apavlov@chromium.org>
> 
>         Web Inspector: [Styles] Handle non-parsedOk properties as inactive ones
>diff --git a/Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp b/Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp
>index d315ee9..0be47a7 100644
>--- a/Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp
>+++ b/Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp
>@@ -68,6 +68,10 @@ void TextCheckerEnchant::learnWord(const String& word)
> 
> void TextCheckerEnchant::checkSpellingOfString(const String& string, int& misspellingLocation, int& misspellingLength)
> {
>+    // Assume that the words in the @a string are spelled correctly.
>+    misspellingLocation = -1;
>+    misspellingLength = 0;
>+
>     if (m_enchantDictionaries.isEmpty())
>         return;
>

Flags:

gustavo: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 101215: 172534 | 172559