Attachment 172329 Details for Bug 101217 – Patch

[patch] Patch

bug-101217-20121105160305.patch (text/plain), 3.01 KB, created by Kenneth Rohde Christiansen on 2012-11-05 07:04:56 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Kenneth Rohde Christiansen

Created: 2012-11-05 07:04:56 PST

Size: 3.01 KB

patch

obsolete

>Subversion Revision: 133460
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index fb3c08268fb16d4d3386f8e6b2d957739f3e80e0..15d44f35a54c7342f52a362bf0be3af002b33937 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2012-11-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
>+
>+        Remove support for "desktop-width" in the viewport meta tag
>+        https://bugs.webkit.org/show_bug.cgi?id=101217
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This has been removed from the CSS Device Adaptation spec, and
>+        should be safe to remove as it is not documented anywhere (neither
>+        in blog posts).
>+
>+        The viewport meta should only support the legacy features.
>+
>+        * dom/ViewportArguments.cpp:
>+        (WebCore::computeViewportAttributes):
>+        (WebCore::findSizeValue):
>+        * dom/ViewportArguments.h:
>+
> 2012-11-05  Pavel Feldman  <pfeldman@chromium.org>
> 
>         Web Inspector: render message bubbles in CodeMirror experiment.
>diff --git a/Source/WebCore/dom/ViewportArguments.cpp b/Source/WebCore/dom/ViewportArguments.cpp
>index 0151294cc6e2036df4e3dfe01e5bc1bdbf15fa00..8e51f9a1094e785073406b2be4f234baa8e00576 100644
>--- a/Source/WebCore/dom/ViewportArguments.cpp
>+++ b/Source/WebCore/dom/ViewportArguments.cpp
>@@ -61,9 +61,6 @@ ViewportAttributes computeViewportAttributes(ViewportArguments args, int desktop
>     }
> 
>     switch (int(args.width)) {
>-    case ViewportArguments::ValueDesktopWidth:
>-        args.width = desktopWidth;
>-        break;
>     case ViewportArguments::ValueDeviceWidth:
>         args.width = deviceWidth;
>         break;
>@@ -73,9 +70,6 @@ ViewportAttributes computeViewportAttributes(ViewportArguments args, int desktop
>     }
> 
>     switch (int(args.height)) {
>-    case ViewportArguments::ValueDesktopWidth:
>-        args.height = desktopWidth;
>-        break;
>     case ViewportArguments::ValueDeviceWidth:
>         args.height = deviceWidth;
>         break;
>@@ -216,8 +210,6 @@ static float findSizeValue(const String& keyString, const String& valueString, D
>     // 3) device-width and device-height are used as keywords.
>     // 4) Other keywords and unknown values translate to 0.0.
> 
>-    if (equalIgnoringCase(valueString, "desktop-width"))
>-        return ViewportArguments::ValueDesktopWidth;
>     if (equalIgnoringCase(valueString, "device-width"))
>         return ViewportArguments::ValueDeviceWidth;
>     if (equalIgnoringCase(valueString, "device-height"))
>diff --git a/Source/WebCore/dom/ViewportArguments.h b/Source/WebCore/dom/ViewportArguments.h
>index fc0d125f070e4914ae6729d12a6c99eaa6f2aa9f..17dc36bab969e3cb5504861a61d4d81486e2e8ea 100644
>--- a/Source/WebCore/dom/ViewportArguments.h
>+++ b/Source/WebCore/dom/ViewportArguments.h
>@@ -67,9 +67,8 @@ struct ViewportArguments {
> 
>     enum {
>         ValueAuto = -1,
>-        ValueDesktopWidth = -2,
>-        ValueDeviceWidth = -3,
>-        ValueDeviceHeight = -4,
>+        ValueDeviceWidth = -2,
>+        ValueDeviceHeight = -3,
>     };
> 
>     ViewportArguments(Type type = Implicit)

Actions: View | Formatted Diff | Diff

Attachments on bug 101217: 172329 | 172337 | 172567 | 172611