Attachment 171867 Details for Bug 100962 – Patch

[patch] Patch

100962_filePicker_modal.patch (text/plain), 1.61 KB, created by Chris Dumez on 2012-11-01 09:08:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2012-11-01 09:08:27 PDT

Size: 1.61 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 8b1ed1f..966a153 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2012-11-01  Christophe Dumez  <christophe.dumez@intel.com>
>+
>+        [EFL][WK2] Make File Chooser dialog modal in MiniBrowser
>+        https://bugs.webkit.org/show_bug.cgi?id=100962
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make file chooser dialog modal in MiniBrowser.
>+
>+        * MiniBrowser/efl/main.c:
>+        (on_file_chooser_request):
>+
> 2012-10-31  Rob Buis  <rbuis@rim.com>
> 
>         [BlackBerry] Fix editing/text-iterator/findString-expected.html fail
>diff --git a/Tools/MiniBrowser/efl/main.c b/Tools/MiniBrowser/efl/main.c
>index 0e2ea2f..618696d 100644
>--- a/Tools/MiniBrowser/efl/main.c
>+++ b/Tools/MiniBrowser/efl/main.c
>@@ -341,11 +341,14 @@ on_fileselector_done(void *user_data, Evas_Object *file_selector, void *event_in
> static void
> on_file_chooser_request(void *user_data, Evas_Object *webview, void *event_info)
> {
>+    Browser_Window *app_data = (Browser_Window *)user_data;
>     Ewk_File_Chooser_Request *request = (Ewk_File_Chooser_Request *)event_info;
> 
>     // Show basic file picker which does not currently support multiple files
>     // or MIME type filtering.
>-    Evas_Object *window = elm_win_util_standard_add("file-picker-window", "File picker");
>+    Evas_Object *window = elm_win_add(app_data->window, "file-picker-window", ELM_WIN_DIALOG_BASIC);
>+    elm_win_title_set(window, "File picker");
>+    elm_win_modal_set(window, EINA_TRUE);
> 
>     FileSelectorData* fs_data = (FileSelectorData*)malloc(sizeof(FileSelectorData));
>     fs_data->window = window;

Actions: View | Formatted Diff | Diff

Attachments on bug 100962: 171867 | 171903 | 171909