Attachment 171618 Details for Bug 100346 – Patch

[patch] Patch

bug-100346-20121031133000.patch (text/plain), 1.83 KB, created by Thiago Marcos P. Santos on 2012-10-31 04:27:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thiago Marcos P. Santos

Created: 2012-10-31 04:27:47 PDT

Size: 1.83 KB

patch

obsolete

>Subversion Revision: 133007
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 6fd5a14d9492047cad0ac2cce324230f52dabf50..0456743687fd3b0547af14ec9039a3705fa3dfe5 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,21 @@
>+2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
>+
>+        [EFL] DRT doesn't clean up after itself
>+        https://bugs.webkit.org/show_bug.cgi?id=100346
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The test driver exports an environment variable DUMPRENDERTREE_TEMP
>+        which is used by both DRT and WTR as the folder for storing icons,
>+        databases, application cache, etc, overriding the default XDG_* path.
>+
>+        We don't need to create these folders because in fact, they are never
>+        used and also never cleaned. Things created inside DUMPRENDERTREE_TEMP
>+        are automatically removed after the test run.
>+
>+        * Scripts/webkitpy/layout_tests/port/efl.py:
>+        (EflPort.setup_environ_for_server):
>+
> 2012-10-31  Mike West  <mkwst@chromium.org>
> 
>         Script run from an isolated world should bypass a page's CSP.
>diff --git a/Tools/Scripts/webkitpy/layout_tests/port/efl.py b/Tools/Scripts/webkitpy/layout_tests/port/efl.py
>index 1e9ed107926447cc1424750c19ff5302f27fb3c0..0c9acd8d8def810fe40432f4c868ad361442a9c0 100644
>--- a/Tools/Scripts/webkitpy/layout_tests/port/efl.py
>+++ b/Tools/Scripts/webkitpy/layout_tests/port/efl.py
>@@ -62,8 +62,6 @@ class EflPort(Port, PulseAudioSanitizer):
>         if self.webprocess_cmd_prefix:
>             env['WEB_PROCESS_CMD_PREFIX'] = self.webprocess_cmd_prefix
> 
>-        env['XDG_CACHE_HOME'] = str(self._filesystem.mkdtemp(prefix='%s-Efl-CacheDir-' % self.driver_name()))
>-        env['XDG_DATA_HOME'] = str(self._filesystem.mkdtemp(prefix='%s-Efl-DataDir-' % self.driver_name()))
>         return env
> 
>     def default_timeout_ms(self):

Actions: View | Formatted Diff | Diff

Attachments on bug 100346: 171428 | 171618