Attachment 171428 Details for Bug 100346 – Patch

[patch] Patch

bug-100346-20121030143929.patch (text/plain), 1.67 KB, created by Thiago Marcos P. Santos on 2012-10-30 05:37:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thiago Marcos P. Santos

Created: 2012-10-30 05:37:16 PDT

Size: 1.67 KB

patch

obsolete

>Subversion Revision: 132893
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 3163ee1a204a0153b88b0f5ff3feae9184c7bbdd..1c09893d0cc89fa469f884195c5f34a0a0c5fbcc 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,5 +1,19 @@
> 2012-10-30  Thiago Marcos P. Santos  <thiago.santos@intel.com>
> 
>+        [EFL] DRT doesn't clean up after itself
>+        https://bugs.webkit.org/show_bug.cgi?id=100346
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We don't need to create these paths and set these environment
>+        variables because all the data and cache directories are manually
>+        set on both WebKitTestRunner and DumpRenderTree.
>+
>+        * Scripts/webkitpy/layout_tests/port/efl.py:
>+        (EflPort.setup_environ_for_server):
>+
>+2012-10-30  Thiago Marcos P. Santos  <thiago.santos@intel.com>
>+
>         [WTR] WebKitTestRunner is not cleaning up the icon database
>         https://bugs.webkit.org/show_bug.cgi?id=100678
> 
>diff --git a/Tools/Scripts/webkitpy/layout_tests/port/efl.py b/Tools/Scripts/webkitpy/layout_tests/port/efl.py
>index 1022cd7b7031ae0d4950c895332350be0b88e194..6d1de065bfe9226ad9af2918f8a602bce5d33072 100644
>--- a/Tools/Scripts/webkitpy/layout_tests/port/efl.py
>+++ b/Tools/Scripts/webkitpy/layout_tests/port/efl.py
>@@ -62,8 +62,6 @@ class EflPort(Port, PulseAudioSanitizer):
>         if self.webprocess_cmd_prefix:
>             env['WEB_PROCESS_CMD_PREFIX'] = self.webprocess_cmd_prefix
> 
>-        env['XDG_CACHE_HOME'] = str(self._filesystem.mkdtemp(prefix='%s-Efl-CacheDir-' % self.driver_name()))
>-        env['XDG_DATA_HOME'] = str(self._filesystem.mkdtemp(prefix='%s-Efl-DataDir-' % self.driver_name()))
>         return env
> 
>     def default_timeout_ms(self):

Actions: View | Formatted Diff | Diff

Attachments on bug 100346: 171428 | 171618