Attachment 170294 Details for Bug 100181 – Patch

[patch] Patch

bug-100181-20121023192407.patch (text/plain), 1.39 KB, created by Nico Weber on 2012-10-23 19:25:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nico Weber

Created: 2012-10-23 19:25:30 PDT

Size: 1.39 KB

patch

obsolete

>Subversion Revision: 131989
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 44073e35f056175322b3b4a28506443fa94772c1..ae084006c199eb798297b44b0e84282cd7a8e8f3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,5 +1,15 @@
> 2012-10-23  Nico Weber  <thakis@chromium.org>
> 
>+        Address review comments from bug 100144
>+        https://bugs.webkit.org/show_bug.cgi?id=100181
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
>+        (WebCore::JPEGImageReader::JPEGImageReader):
>+
>+2012-10-23  Nico Weber  <thakis@chromium.org>
>+
>         In the open-source jpeg decoder, read image orientation from the exif data
>         https://bugs.webkit.org/show_bug.cgi?id=100144
> 
>diff --git a/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp b/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
>index 141337cf01803b6123f59572f9ad378024851227..8b2373f0f180836dcc25040e2b5f5f830f3f923a 100644
>--- a/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
>+++ b/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
>@@ -291,7 +291,7 @@ public:
>         setup_read_icc_profile(&m_info);
> #endif
> 
>-        // Keep APP1 blocks, for obtaining exif data.
>+        // Retain EXIF metadata marker APP1 for orientation detection.
>         jpeg_save_markers(&m_info, exifMarker, 0xFFFF);
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 100181: 170294 | 170502