Attachment 168311 Details for Bug 98950 – more testfile cleanup

[patch] more testfile cleanup

patch (text/plain), 5.11 KB, created by Rik Cabanier on 2012-10-11 16:30:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rik Cabanier

Created: 2012-10-11 16:30:32 PDT

Size: 5.11 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 131096)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2012-10-11  Rik Cabanier  <cabanier@adobe.com>
>+
>+        Bad copy constructor in StyleRareNonInheritedData
>+        https://bugs.webkit.org/show_bug.cgi?id=98950
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        typo in copy constructor caused blendmode to always be the default
>+
>+        * rendering/style/StyleRareNonInheritedData.cpp:
>+        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
>+
> 2012-10-11  Joshua Bell  <jsbell@chromium.org>
> 
>         IndexedDB: IDL types defined in spec should be visible to scripts
>Index: Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
>===================================================================
>--- Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp	(revision 130695)
>+++ Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp	(working copy)
>@@ -159,7 +159,7 @@ StyleRareNonInheritedData::StyleRareNonI
> #endif
>     , m_hasAspectRatio(o.m_hasAspectRatio)
> #if ENABLE(CSS_COMPOSITING)
>-    , m_effectiveBlendMode(RenderStyle::initialBlendMode())
>+    , m_effectiveBlendMode(o.m_effectiveBlendMode)
> #endif
> {
> }
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 131096)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2012-10-11  Rik Cabanier  <cabanier@adobe.com>
>+
>+        Bad copy constructor in StyleRareNonInheritedData
>+        https://bugs.webkit.org/show_bug.cgi?id=98950
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        typo in copy constructor caused blendmode to always be the default
>+
>+        * platform/chromium/TestExpectations:
>+        * transitions/blendmode-transitions-expected.txt: Added.
>+        * transitions/blendmode-transitions.html: Added.
>+        * transitions/resources/transition-test-helpers.js:
>+        (expected):
>+
> 2012-10-11  Joshua Bell  <jsbell@chromium.org>
> 
>         IndexedDB: IDL types defined in spec should be visible to scripts
>Index: LayoutTests/platform/chromium/TestExpectations
>===================================================================
>--- LayoutTests/platform/chromium/TestExpectations	(revision 130695)
>+++ LayoutTests/platform/chromium/TestExpectations	(working copy)
>@@ -107,6 +107,9 @@ webkit.org/b/94332 http/tests/security/c
> # ever expect to pass this.
> crbug.com/24189 fast/dom/open-and-close-by-DOM.html [ Skip ]
> 
>+# Fails because Blend Mode is not enabled on Chromium yet 
>+webkit.org/b/98950 transitions/blendmode-transitions.html [ Skip ]
>+
> # Implement java testing harness.
> crbug.com/36681 java [ Skip ]
> 
>Index: LayoutTests/transitions/blendmode-transitions-expected.txt
>===================================================================
>--- LayoutTests/transitions/blendmode-transitions-expected.txt	(revision 0)
>+++ LayoutTests/transitions/blendmode-transitions-expected.txt	(revision 0)
>@@ -0,0 +1,3 @@
>+BOX
>+PASS - "-webkit-blend-mode" property for "box" element at 0.5s saw something close to: difference
>+
>Index: LayoutTests/transitions/blendmode-transitions.html
>===================================================================
>--- LayoutTests/transitions/blendmode-transitions.html	(revision 0)
>+++ LayoutTests/transitions/blendmode-transitions.html	(revision 0)
>@@ -0,0 +1,47 @@
>+<!DOCTYPE>
>+
>+<html>
>+<head>
>+  <style>
>+    .box {
>+      height: 100px;
>+      width: 100px;
>+      margin: 50px;
>+      border: 1px solid black;
>+      text-align: center;
>+      padding: 20px;
>+      -webkit-transition-duration: 10s;
>+      -webkit-transition-timing-function: linear;
>+      -webkit-transition-property: opacity;
>+	  opacity:1;
>+	  -webkit-blend-mode: difference;
>+    }
>+    
>+    .final {
>+      opacity: 0;
>+    }
>+  </style>
>+  <script src="resources/transition-test-helpers.js"></script>
>+  <script type="text/javascript">
>+
>+    const expectedValues = [
>+      // [time, element-id, property, expected-value, tolerance]
>+      [0.5, 'box', '-webkit-blend-mode', 'difference', 0],
>+    ];
>+  
>+    function setupTest()
>+    {
>+      document.getElementById('box').className = 'box final';
>+    }
>+  
>+    runTransitionTest(expectedValues, setupTest, false);
>+  </script>
>+</head>
>+<body>
>+
>+  <div id="box" class="box">BOX</div>
>+  <div id="result">
>+  </div>
>+
>+</body>
>+</html>
>Index: LayoutTests/transitions/resources/transition-test-helpers.js
>===================================================================
>--- LayoutTests/transitions/resources/transition-test-helpers.js	(revision 130695)
>+++ LayoutTests/transitions/resources/transition-test-helpers.js	(working copy)
>@@ -163,6 +163,7 @@ function checkExpectedValue(expected, in
>         } else if (computedStyle.cssValueType == CSSValue.CSS_PRIMITIVE_VALUE) {
>             switch (computedStyle.primitiveType) {
>                 case CSSPrimitiveValue.CSS_STRING:
>+                case CSSPrimitiveValue.CSS_IDENT:
>                     computedValue = computedStyle.getStringValue();
>                     pass = computedValue == expectedValue;
>                     break;

Actions: View | Formatted Diff | Diff

Attachments on bug 98950: 168060 | 168281 | 168282 | 168284 | 168289 | 168306 | 168311 | 168314 | 168343 | 168347 | 168355