Attachment 164077 Details for Bug 96739 – ROLLOUT of r128568

[patch] ROLLOUT of r128568

bug-96739-20120914093617.patch (text/plain), 1.42 KB, created by WebKit Review Bot on 2012-09-14 02:29:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Review Bot

Created: 2012-09-14 02:29:53 PDT

Size: 1.42 KB

patch

obsolete

>Subversion Revision: 128573
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d6a837f1983cd747d6453d08a93191c5d44c5f10..2385806a7dc4c867c86d76a2ce2cf37f7b9e84a2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2012-09-14  Sheriff Bot  <webkit.review.bot@gmail.com>
>+
>+        Unreviewed, rolling out r128568.
>+        http://trac.webkit.org/changeset/128568
>+        https://bugs.webkit.org/show_bug.cgi?id=96739
>+
>+        It broke 3 tests everywhere (Requested by Ossy on #webkit).
>+
>+        * bindings/js/JSDictionary.h:
>+        (WebCore::JSDictionary::tryGetPropertyAndResult):
>+
> 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
> 
>         Evas_Object* is a ref'ed structure, so tread it as such
>diff --git a/Source/WebCore/bindings/js/JSDictionary.h b/Source/WebCore/bindings/js/JSDictionary.h
>index 6330df8c7ef2a73321efc1028640ba3c925bd163..febe92472a243d8015ca5f36b9f75d854e223d12 100644
>--- a/Source/WebCore/bindings/js/JSDictionary.h
>+++ b/Source/WebCore/bindings/js/JSDictionary.h
>@@ -145,10 +145,8 @@ JSDictionary::GetPropertyResult JSDictionary::tryGetPropertyAndResult(const char
>         Result result;
>         convertValue(m_exec, value, result);
> 
>-        if (m_exec->hadException()) {
>-            m_exec->clearException();
>+        if (m_exec->hadException())
>             return ExceptionThrown;
>-        }
> 
>         setter(context, result);
>         break;

Actions: View | Formatted Diff | Diff

Attachments on bug 96739: 164077