Attachment 163635 Details for Bug 96521 – Patch

[patch] Patch

bug-96521-20120912111703.patch (text/plain), 4.10 KB, created by Mark Pilgrim (Google) on 2012-09-12 08:18:15 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Pilgrim (Google)

Created: 2012-09-12 08:18:15 PDT

Size: 4.10 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 128311)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2012-09-12  Mark Pilgrim  <pilgrim@chromium.org>
>+
>+        [Chromium] Remove unused popupsAllowed function from PlatformSupport
>+        https://bugs.webkit.org/show_bug.cgi?id=96521
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part of a refactoring series. See tracking bug 82948.
>+
>+        * bindings/v8/NPV8Object.cpp:
>+        (WebCore::v8ObjectToNPObject):
>+        (_NPN_Evaluate):
>+        (_NPN_GetProperty):
>+        * platform/chromium/PlatformSupport.h:
>+        (PlatformSupport):
>+
> 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
> 
>         [EFL] Avoid manual memory management in RenderThemeEfl
>Index: Source/WebCore/bindings/v8/NPV8Object.cpp
>===================================================================
>--- Source/WebCore/bindings/v8/NPV8Object.cpp	(revision 128311)
>+++ Source/WebCore/bindings/v8/NPV8Object.cpp	(working copy)
>@@ -28,7 +28,6 @@
> 
> #include "NPV8Object.h"
> 
>-#include "PlatformSupport.h"
> #include "DOMWindow.h"
> #include "Frame.h"
> #include "NPObjectWrapper.h"
>@@ -130,7 +129,7 @@ static v8::Local<v8::String> npIdentifie
> 
> NPObject* v8ObjectToNPObject(v8::Handle<v8::Object> object)
> {
>-    return reinterpret_cast<NPObject*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex)); 
>+    return reinterpret_cast<NPObject*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
> }
> 
> static NPClass V8NPObjectClass = { NP_CLASS_STRUCT_VERSION,
>@@ -296,7 +295,7 @@ bool _NPN_InvokeDefault(NPP npp, NPObjec
> 
> bool _NPN_Evaluate(NPP npp, NPObject* npObject, NPString* npScript, NPVariant* result)
> {
>-    bool popupsAllowed = PlatformSupport::popupsAllowed(npp);
>+    bool popupsAllowed = false;
>     return _NPN_EvaluateHelper(npp, popupsAllowed, npObject, npScript, result);
> }
> 
>@@ -362,7 +361,7 @@ bool _NPN_GetProperty(NPP npp, NPObject*
> 
>         v8::Handle<v8::Object> obj(object->v8Object);
>         v8::Local<v8::Value> v8result = obj->Get(npIdentifierToV8Identifier(propertyName));
>-        
>+
>         if (v8result.IsEmpty())
>             return false;
> 
>Index: Source/WebCore/platform/chromium/PlatformSupport.h
>===================================================================
>--- Source/WebCore/platform/chromium/PlatformSupport.h	(revision 128311)
>+++ Source/WebCore/platform/chromium/PlatformSupport.h	(working copy)
>@@ -123,7 +123,6 @@ public:
>     // Plugin -------------------------------------------------------------
>     static bool plugins(bool refresh, Vector<PluginInfo>*);
>     static NPObject* pluginScriptableObject(Widget*);
>-    static bool popupsAllowed(NPP);
> 
>     // Screen -------------------------------------------------------------
>     static int screenHorizontalDPI(Widget*);
>Index: Source/WebKit/chromium/ChangeLog
>===================================================================
>--- Source/WebKit/chromium/ChangeLog	(revision 128311)
>+++ Source/WebKit/chromium/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2012-09-12  Mark Pilgrim  <pilgrim@chromium.org>
>+
>+        [Chromium] Remove unused popupsAllowed function from PlatformSupport
>+        https://bugs.webkit.org/show_bug.cgi?id=96521
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part of a refactoring series. See tracking bug 82948.
>+
>+        * src/PlatformSupport.cpp:
>+        (WebCore):
>+
> 2012-09-12  Ilya Tikhonovsky  <loislo@chromium.org>
> 
>         Web Inspector: NMI move String* instrumentation to wtf.
>Index: Source/WebKit/chromium/src/PlatformSupport.cpp
>===================================================================
>--- Source/WebKit/chromium/src/PlatformSupport.cpp	(revision 128311)
>+++ Source/WebKit/chromium/src/PlatformSupport.cpp	(working copy)
>@@ -566,12 +566,6 @@ IntRect PlatformSupport::screenAvailable
>     return client->screenInfo().availableRect;
> }
> 
>-bool PlatformSupport::popupsAllowed(NPP npp)
>-{
>-    // FIXME: Give the embedder a way to control this.
>-    return false;
>-}
>-
> #if ENABLE(WORKERS)
> WorkerContextProxy* WorkerContextProxy::create(Worker* worker)
> {

Actions: View | Formatted Diff | Diff

Attachments on bug 96521: 163635 | 164748