Attachment 160966 Details for Bug 93958 – approach #1 part 2 without move of the tests

[patch] approach #1 part 2 without move of the tests

perftestmemory_2.patch (text/plain), 5.77 KB, created by Zoltan Horvath on 2012-08-28 06:54:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zoltan Horvath

Created: 2012-08-28 06:54:46 PDT

Size: 5.77 KB

patch

obsolete

>diff --git a/PerformanceTests/ChangeLog b/PerformanceTests/ChangeLog
>index 80a8d69..6be69a7 100644
>--- a/PerformanceTests/ChangeLog
>+++ b/PerformanceTests/ChangeLog
>@@ -1,3 +1,58 @@
>+2012-08-28  Zoltan Horvath  <zoltan@webkit.org>
>+
>+        Pageload tests should measure memory usage
>+        https://bugs.webkit.org/show_bug.cgi?id=93958
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add JS and Heap memory measurement to PageLoad tests.
>+
>+        * PageLoad/svg/33041-Samurai.html: Added.
>+        * PageLoad/svg/42450-under the see.html: Added.
>+        * PageLoad/svg/42470-flower_from_my_garden_v2.html: Added.
>+        * PageLoad/svg/44057-drops on a blade.html: Added.
>+        * PageLoad/svg/Harvey_Rayner.html: Added.
>+        * PageLoad/svg/Sierpinski_carpet_6.html: Added.
>+        * PageLoad/svg/az-lizard_benji_park_01.html: Added.
>+        * PageLoad/svg/bamboo_01.html: Added.
>+        * PageLoad/svg/cacuts_01.html: Added.
>+        * PageLoad/svg/cowboy.html: Added.
>+        * PageLoad/svg/crawfish2_ganson.html: Added.
>+        * PageLoad/svg/deb9frac1.html: Added.
>+        * PageLoad/svg/food_leif_lodahl_01.html: Added.
>+        * PageLoad/svg/france.html: Added.
>+        * PageLoad/svg/francobollo_gnome_ezechi_02.html: Added.
>+        * PageLoad/svg/gearflowers.html: Added.
>+        * PageLoad/svg/hereGear4.html: Added.
>+        * PageLoad/svg/mtsthelens.html: Added.
>+        * PageLoad/svg/resources/33041-Samurai.svg: Renamed from PerformanceTests/PageLoad/svg/files/33041-Samurai.svg.
>+        * PageLoad/svg/resources/42450-under the see.svg: Renamed from PerformanceTests/PageLoad/svg/files/42450-under the see.svg.
>+        * PageLoad/svg/resources/42470-flower_from_my_garden_v2.svg: Renamed from PerformanceTests/PageLoad/svg/files/42470-flower_from_my_garden_v2.svg.
>+        * PageLoad/svg/resources/44057-drops on a blade.svg: Renamed from PerformanceTests/PageLoad/svg/files/44057-drops on a blade.svg.
>+        * PageLoad/svg/resources/Harvey_Rayner.svg: Renamed from PerformanceTests/PageLoad/svg/files/Harvey_Rayner.svg.
>+        * PageLoad/svg/resources/Sierpinski_carpet_6.svg: Renamed from PerformanceTests/PageLoad/svg/files/Sierpinski_carpet_6.svg.
>+        * PageLoad/svg/resources/az-lizard_benji_park_01.svg: Renamed from PerformanceTests/PageLoad/svg/files/az-lizard_benji_park_01.svg.
>+        * PageLoad/svg/resources/bamboo_01.svg: Renamed from PerformanceTests/PageLoad/svg/files/bamboo_01.svg.
>+        * PageLoad/svg/resources/cacuts_01.svg: Renamed from PerformanceTests/PageLoad/svg/files/cacuts_01.svg.
>+        * PageLoad/svg/resources/cowboy.svg: Renamed from PerformanceTests/PageLoad/svg/files/cowboy.svg.
>+        * PageLoad/svg/resources/crawfish2_ganson.svg: Renamed from PerformanceTests/PageLoad/svg/files/crawfish2_ganson.svg.
>+        * PageLoad/svg/resources/deb9frac1.svg: Renamed from PerformanceTests/PageLoad/svg/files/deb9frac1.svg.
>+        * PageLoad/svg/resources/food_leif_lodahl_01.svg: Renamed from PerformanceTests/PageLoad/svg/files/food_leif_lodahl_01.svg.
>+        * PageLoad/svg/resources/france.svg: Renamed from PerformanceTests/PageLoad/svg/files/france.svg.
>+        * PageLoad/svg/resources/francobollo_gnome_ezechi_02.svg: Renamed from PerformanceTests/PageLoad/svg/files/francobollo_gnome_ezechi_02.svg.
>+        * PageLoad/svg/resources/gearflowers.svg: Renamed from PerformanceTests/PageLoad/svg/files/gearflowers.svg.
>+        * PageLoad/svg/resources/hereGear4.svg: Renamed from PerformanceTests/PageLoad/svg/files/hereGear4.svg.
>+        * PageLoad/svg/resources/mtsthelens.svg: Renamed from PerformanceTests/PageLoad/svg/files/mtsthelens.svg.
>+        * PageLoad/svg/resources/mtsthelens0.jpg: Renamed from PerformanceTests/PageLoad/svg/files/mtsthelens0.jpg.
>+        * PageLoad/svg/resources/world-iso.svg: Renamed from PerformanceTests/PageLoad/svg/files/world-iso.svg.
>+        * PageLoad/svg/resources/worldcup.svg: Renamed from PerformanceTests/PageLoad/svg/files/worldcup.svg.
>+        * PageLoad/svg/svg.pltsuite: Update paths.
>+        * PageLoad/svg/world-iso.html: Added.
>+        * PageLoad/svg/worldcup.html: Added.
>+        * Skipped: Modify affected test names.
>+        * resources/runner.js:
>+        (PerfTestRunner.getAndPrintMemoryusage): Add pure function to print memory results.
>+
>diff --git a/PerformanceTests/Skipped b/PerformanceTests/Skipped
>index f5b5937..86860b2 100644
>--- a/PerformanceTests/Skipped
>+++ b/PerformanceTests/Skipped
>@@ -2,19 +2,19 @@
> Mutation
> 
> # Unstable SVG page loading tests
>-PageLoad/svg/files/33041-Samurai.svg
>+PageLoad/svg/33041-Samurai.html
> 
> # Takes too long to load
>-PageLoad/svg/files/Sierpinski_carpet_6.svg
>+PageLoad/svg/Sierpinski_carpet_6.html
> 
>-PageLoad/svg/files/az-lizard_benji_park_01.svg
>-PageLoad/svg/files/france.svg
>-PageLoad/svg/files/francobollo_gnome_ezechi_02.svg
>-PageLoad/svg/files/gearflowers.svg
>-PageLoad/svg/files/hereGear4.svg
>+PageLoad/svg/az-lizard_benji_park_01.html
>+PageLoad/svg/france.html
>+PageLoad/svg/francobollo_gnome_ezechi_02.html
>+PageLoad/svg/gearflowers.html
>+PageLoad/svg/hereGear4.html
> 
> # Takes 22s on MacBookPro
>-PageLoad/svg/files/mtsthelens.svg
>+PageLoad/svg/mtsthelens.html
> 
> # Do not conform to WebKit or Chromium perf test styles
> SunSpider
>diff --git a/PerformanceTests/resources/runner.js b/PerformanceTests/resources/runner.js
>index 6bf1f29..1bf79c1 100755
>--- a/PerformanceTests/resources/runner.js
>+++ b/PerformanceTests/resources/runner.js
>@@ -180,6 +180,13 @@ PerfTestRunner.getUsedJSHeap = function() {
>     return console.memory.usedJSHeapSize;
> }
> 
>+PerfTestRunner.getAndPrintMemoryusage = function() {
>+    if (!window.internals)
>+        return;
>+    this.log("JS Heap: " + this.getUsedJSHeap() + " bytes")
>+    this.log("Malloc: " + this.getUsedMallocHeap() + " bytes")
>+}
>+
> PerfTestRunner.getAndPrintMemoryStatistics = function() {
>     if (!window.internals)
>         return;

Actions: View | Formatted Diff | Diff

Attachments on bug 93958: 160965 | 160966 | 167662 | 167802 | 167881 | 169649