Attachment 159319 Details for Bug 94297 – Patch 1

[patch] Patch 1

bug-94297-20120820110809.patch (text/plain), 3.28 KB, created by yosin on 2012-08-19 19:08:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: yosin

Created: 2012-08-19 19:08:48 PDT

Size: 3.28 KB

patch

obsolete

>Subversion Revision: 125984
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 5b6a28c47dbdb9eac5c17109c9ca6dbef07a190c..f560dcbbbd3aa305244a841eafb1473c21e09edf 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,19 @@
>+2012-08-19  Yoshifumi Inoue  <yosin@chromium.org>
>+
>+        [Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
>+        https://bugs.webkit.org/show_bug.cgi?id=94297
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch updates a logic for detcting multiple fields time input UI
>+        has second field or not.
>+
>+        * fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js:
>+        (checkHasShortFormat): Added "<br>" between input elements to avoid rounding error
>+        on calculating rendering width of input elements. When input elements are rendered on
>+        same baseline, width of first one is 126px and second is 125px.
>+        * platform/chromium/TestExpectations: Changed bug id of entries Chromium-Mac specific bug entry, bug 94339.
>+
> 2012-08-19  Mike West  <mkwst@chromium.org>
> 
>         CSP 1.1: Add 'plugin-types' and 'form-action' DOM API.
>diff --git a/LayoutTests/fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js b/LayoutTests/fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js
>index 9ff1b594ec3227077be50d01ffd6a6bb90bd11e5..ef8faf841987f4f1d99718b5e87a2b33a6dc2509 100644
>--- a/LayoutTests/fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js
>+++ b/LayoutTests/fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js
>@@ -1,7 +1,7 @@
> function checkHasShortFormat()
> {
>     var container = document.createElement("span");
>-    container.innerHTML = "<input type=time id=step60 step=60><input type=time id=step1 step=1>";
>+    container.innerHTML = "<input type=time id=step60 step=60><br><input type=time id=step1 step=1>";
>     document.body.appendChild(container);
>     var hasShortFormat = document.getElementById("step60").offsetWidth != document.getElementById("step1").offsetWidth;
>     container.parentElement.removeChild(container);
>diff --git a/LayoutTests/platform/chromium/TestExpectations b/LayoutTests/platform/chromium/TestExpectations
>index 98a795a5df38181511d99a64b2d0a70c1b94d36f..b11931cb2c879c8350e5ce83ad8fbc49b45fe8bd 100644
>--- a/LayoutTests/platform/chromium/TestExpectations
>+++ b/LayoutTests/platform/chromium/TestExpectations
>@@ -176,8 +176,8 @@ BUGWK94287 MAC WIN : fast/forms/time-multiple-fields/time-multiple-fields-appear
> BUGWK94287 MAC WIN : fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html = MISSING TEXT IMAGE IMAGE+TEXT PASS
> 
> // Temporary disabled
>-BUGWK94297 MAC WIN : fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html = IMAGE PASS
>-BUGWK94297 MAC WIN : fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html = IMAGE PASS
>+BUGWK94439 MAC : fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html = IMAGE PASS
>+BUGWK94439 MAC : fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html = IMAGE PASS
> 
> // Proximity Events is not supported.
> BUGWK92942 SKIP : fast/dom/Proximity = PASS

Actions: View | Formatted Diff | Diff

Attachments on bug 94297: 159319