Attachment 157318 Details for Bug 93543 – Patch

[patch] Patch

bug-93543-20120808160131.patch (text/plain), 2.72 KB, created by Erik Arvidsson on 2012-08-08 16:01:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Erik Arvidsson

Created: 2012-08-08 16:01:57 PDT

Size: 2.72 KB

patch

obsolete

>Subversion Revision: 125095
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index a6f19eefe338fc00a44ae77fbb1241e75ff1506f..bfbfcd782824cf161a0c685604b566f737716407 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2012-08-08  Erik Arvidsson  <arv@chromium.org>
>+
>+        Fix invalid test
>+        https://bugs.webkit.org/show_bug.cgi?id=93543
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The HTMLMediaElement.prototype.NETWORK_NO_SOURCE is non writable so assigning to the element instance should
>+        be ignored.
>+
>+        * media/network-no-source-const-shadow-expected.txt:
>+        * media/network-no-source-const-shadow.html:
>+
> 2012-08-08  Xianzhu Wang  <wangxianzhu@chromium.org>
> 
>         [Chromium-Android] Apply all Linux layout test expectations
>diff --git a/LayoutTests/media/network-no-source-const-shadow-expected.txt b/LayoutTests/media/network-no-source-const-shadow-expected.txt
>index 0ee5e78145fa93c6a0fcf5b904a571b69802117f..08e7830b95ebb4fd0c86605427225d2b6c514659 100644
>--- a/LayoutTests/media/network-no-source-const-shadow-expected.txt
>+++ b/LayoutTests/media/network-no-source-const-shadow-expected.txt
>@@ -1,4 +1,4 @@
>-Test that NETWORK_NO_SOURCE is immutable at the appropriate times
>+Test that NETWORK_NO_SOURCE is immutable
> 
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> 
>@@ -8,7 +8,7 @@ PASS HTMLMediaElement.prototype.NETWORK_NO_SOURCE is 3
> PASS element.NETWORK_NO_SOURCE is 3
> PASS HTMLMediaElement.NETWORK_NO_SOURCE is 3
> PASS HTMLAudioElement.prototype.NETWORK_NO_SOURCE is 3
>-PASS element.NETWORK_NO_SOURCE is 15
>+FAIL element.NETWORK_NO_SOURCE should be 3. Was 15.
> PASS successfullyParsed is true
> 
> TEST COMPLETE
>diff --git a/LayoutTests/media/network-no-source-const-shadow.html b/LayoutTests/media/network-no-source-const-shadow.html
>index 4ae7c56ff11f6a432d19e9f01546cc9f4d92618d..c8b4cabb1e94a89a5cf1128f12976ea4bd36840b 100644
>--- a/LayoutTests/media/network-no-source-const-shadow.html
>+++ b/LayoutTests/media/network-no-source-const-shadow.html
>@@ -1,7 +1,7 @@
> <!DOCTYPE html>
> <script src="../fast/js/resources/js-test-pre.js"></script>
> <script>
>-description("Test that NETWORK_NO_SOURCE is immutable at the appropriate times");
>+description("Test that NETWORK_NO_SOURCE is immutable");
> 
> shouldBe("HTMLMediaElement.NETWORK_NO_SOURCE", "3");
> shouldBe("HTMLMediaElement.prototype.NETWORK_NO_SOURCE", "3");
>@@ -16,6 +16,6 @@ element.NETWORK_NO_SOURCE = 15;
> 
> shouldBe("HTMLMediaElement.NETWORK_NO_SOURCE", "3");
> shouldBe("HTMLAudioElement.prototype.NETWORK_NO_SOURCE", "3");
>-shouldBe("element.NETWORK_NO_SOURCE", "15");
>+shouldBe("element.NETWORK_NO_SOURCE", "3");
> </script>
> <script src="../fast/js/resources/js-test-post.js"></script>

Actions: View | Formatted Diff | Diff

Attachments on bug 93543: 157318