Attachment 157038 Details for Bug 93295 – Patch for landing

[patch] Patch for landing

bug-93295-20120807162627.patch (text/plain), 3.30 KB, created by Michelangelo De Simone on 2012-08-07 16:26:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michelangelo De Simone

Created: 2012-08-07 16:26:52 PDT

Size: 3.30 KB

patch

obsolete

>Subversion Revision: 124800
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 473b02812c9a49448c2454800c0b5f7d524031e1..d4c32b37960bb707393e4c5f1d552d9835481e4b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2012-08-07  Michelangelo De Simone  <michelangelo@webkit.org>
>+
>+        CSSParser::parseTransform() refactor to accept valueList as argument
>+        https://bugs.webkit.org/show_bug.cgi?id=93295
>+
>+        Reviewed by Darin Adler.
>+
>+        CSS::parseTranform() is now accepting the related CSSParserValueList as
>+        argument. This change will be used by the code to parse the 3d-transforms
>+        within the custom() function, see bug #71443.
>+
>+        * css/CSSParser.cpp:
>+        (WebCore::CSSParser::parseValue):
>+        (WebCore::CSSParser::parseTransform):
>+        * css/CSSParser.h:
>+
> 2012-08-06  Anna Cavender  <annacc@chromium.org>
> 
>         MediaSource should use it's own list of source URLs
>diff --git a/Source/WebCore/css/CSSParser.cpp b/Source/WebCore/css/CSSParser.cpp
>index 8d28883cef993a3f78a0d2f8917d3aaa1ff742a5..af49c75aee72dc6c8b8b8cf2a6f5a75fbaf630e8 100644
>--- a/Source/WebCore/css/CSSParser.cpp
>+++ b/Source/WebCore/css/CSSParser.cpp
>@@ -2333,9 +2333,9 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important)
>         if (id == CSSValueNone)
>             validPrimitive = true;
>         else {
>-            PassRefPtr<CSSValue> val = parseTransform();
>-            if (val) {
>-                addProperty(propId, val, important);
>+            RefPtr<CSSValue> transformValue = parseTransform(m_valueList.get());
>+            if (transformValue) {
>+                addProperty(propId, transformValue.release(), important);
>                 return true;
>             }
>             return false;
>@@ -7278,15 +7278,15 @@ private:
>     CSSParser::Units m_unit;
> };
> 
>-PassRefPtr<CSSValueList> CSSParser::parseTransform()
>+PassRefPtr<CSSValueList> CSSParser::parseTransform(CSSParserValueList* valueList)
> {
>-    if (!m_valueList)
>+    if (!valueList)
>         return 0;
> 
>     // The transform is a list of functional primitives that specify transform operations.
>     // We collect a list of WebKitCSSTransformValues, where each value specifies a single operation.
>     RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
>-    for (CSSParserValue* value = m_valueList->current(); value; value = m_valueList->next()) {
>+    for (CSSParserValue* value = valueList->current(); value; value = valueList->next()) {
>         if (value->unit != CSSParserValue::Function || !value->function)
>             return 0;
> 
>diff --git a/Source/WebCore/css/CSSParser.h b/Source/WebCore/css/CSSParser.h
>index 6acbba25293055a163392f18d677e1a8a56a84b3..a28512d83d23f5705f27a3d78ca0883f0274c4a5 100644
>--- a/Source/WebCore/css/CSSParser.h
>+++ b/Source/WebCore/css/CSSParser.h
>@@ -217,7 +217,7 @@ public:
> #endif
> #endif
> 
>-    PassRefPtr<CSSValueList> parseTransform();
>+    PassRefPtr<CSSValueList> parseTransform(CSSParserValueList*);
>     bool parseTransformOrigin(CSSPropertyID propId, CSSPropertyID& propId1, CSSPropertyID& propId2, CSSPropertyID& propId3, RefPtr<CSSValue>&, RefPtr<CSSValue>&, RefPtr<CSSValue>&);
>     bool parsePerspectiveOrigin(CSSPropertyID propId, CSSPropertyID& propId1, CSSPropertyID& propId2,  RefPtr<CSSValue>&, RefPtr<CSSValue>&);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 93295: 156813 | 156987 | 157038